From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20085.outbound.protection.outlook.com [40.107.2.85]) by dpdk.org (Postfix) with ESMTP id A32FB2BE1 for ; Mon, 22 Jan 2018 14:22:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=C5cY0NRiqfZJWttbItViqbN3OfXh51gyYHhQgIhOTrM=; b=KkARuqMnngIJNdXIUKX6qmbE5zGy7OvkuP0lUy8NkahI5ThEz1CtZVV6hMQqSpUWcuu7VsIxxQp1ylMShSxc65qctcAWKco11gv0mZFEi/hVlQAO1zMsx7HPBT393jp5mo5gWgGh+gPl7ZNWDN1+F7+2eu27rYfyGteQTnphqtc= Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com (52.133.21.26) by AM6PR0502MB3784.eurprd05.prod.outlook.com (52.133.21.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Mon, 22 Jan 2018 13:22:45 +0000 Received: from AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::6c28:c6b3:de94:a733]) by AM6PR0502MB3797.eurprd05.prod.outlook.com ([fe80::6c28:c6b3:de94:a733%13]) with mapi id 15.20.0428.019; Mon, 22 Jan 2018 13:22:45 +0000 From: Matan Azrad To: "Ananyev, Konstantin" , =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: Thomas Monjalon , "Wu, Jingjing" , "dev@dpdk.org" , Neil Horman , "Richardson, Bruce" Thread-Topic: [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership Thread-Index: AQHTkSJSs9wv4iQCB0Cv+2LP7vySOKN7IsfQgAAIKACAAAHXQIAAHWSAgASMgQCAAAupAA== Date: Mon, 22 Jan 2018 13:22:45 +0000 Message-ID: References: <1515318351-4756-1-git-send-email-matan@mellanox.com> <1516293317-30748-1-git-send-email-matan@mellanox.com> <1516293317-30748-8-git-send-email-matan@mellanox.com> <2601191342CEEE43887BDE71AB97725886280A68@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB97725886280AE8@irsmsx105.ger.corp.intel.com> <20180119150017.mljpcdmldqx32mkq@bidouze.vm.6wind.com> <2601191342CEEE43887BDE71AB97725886281B1D@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725886281B1D@irsmsx105.ger.corp.intel.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR0502MB3784; 7:qNct7ZyUT9LDnDJ7yTPXkhKKUKgCRnPTENxHVGGd9qU78WmV9E68PQ4NrjGuKKtrIKAKGbUpLRtdmd7/gm0z0SfxfSHFUc/YcDsBfVNGl9I826Duo+ewF208zokSZeIf65wAtvizSTXlXBrNR8AX000uzrmETDcCtvVcSCxpCrsuh7vAxxXd7DuHvWm0WCm4gp4ylB2LXWpg264lLfJhJSIdlAnt43TJBeHv0LcwAN+5Y5qyHIdFpLupBAuVqKc7 x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 2ec573c8-33fa-414a-c310-08d5619b3965 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3784; x-ms-traffictypediagnostic: AM6PR0502MB3784: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(60795455431006)(278428928389397)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231023)(2400081)(944501161)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:AM6PR0502MB3784; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM6PR0502MB3784; x-forefront-prvs: 0560A2214D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(346002)(376002)(39380400002)(396003)(199004)(189003)(57704003)(13464003)(51444003)(8676002)(81166006)(2950100002)(7696005)(59450400001)(5890100001)(5250100002)(102836004)(53546011)(6506007)(54906003)(53936002)(97736004)(76176011)(6246003)(81156014)(229853002)(55016002)(110136005)(93886005)(26005)(6436002)(74316002)(305945005)(99286004)(66066001)(316002)(9686003)(478600001)(33656002)(7736002)(2900100001)(68736007)(3280700002)(86362001)(8936002)(105586002)(2906002)(25786009)(6116002)(3660700001)(106356001)(3846002)(4326008)(14454004)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3784; H:AM6PR0502MB3797.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: zC1NXgSYmbpEoKsS9LMEhlIbiNoA3719EW0le2Rkpihw3MsoFt+nM0O8XK8F43FfNhO3lJFNDTNAYzHQiQQZGw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ec573c8-33fa-414a-c310-08d5619b3965 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2018 13:22:45.2807 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3784 Subject: Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 13:22:46 -0000 Hi=20 From: Ananyev, Konstantin [mailto:konstantin.ananyev@intel.com] > Hi lads, >=20 > > > > Hi Matan, > > > > On Fri, Jan 19, 2018 at 01:35:10PM +0000, Matan Azrad wrote: > > > Hi Konstantin > > > > > > From: Ananyev, Konstantin, Friday, January 19, 2018 3:09 PM > > > > > -----Original Message----- > > > > > From: Matan Azrad [mailto:matan@mellanox.com] > > > > > Sent: Friday, January 19, 2018 12:52 PM > > > > > To: Ananyev, Konstantin ; Thomas > > > > > Monjalon ; Gaetan Rivet > > > > ; > > > > > Wu, Jingjing > > > > > Cc: dev@dpdk.org; Neil Horman ; > > > > > Richardson, Bruce > > > > > Subject: RE: [PATCH v3 7/7] app/testpmd: adjust ethdev port > > > > > ownership > > > > > > > > > > Hi Konstantin > > > > > > > > > > From: Ananyev, Konstantin, Friday, January 19, 2018 2:38 PM > > > > > > To: Matan Azrad ; Thomas Monjalon > > > > > > ; Gaetan Rivet > ; > > > > Wu, > > > > > > Jingjing > > > > > > Cc: dev@dpdk.org; Neil Horman ; > > > > > > Richardson, Bruce > > > > > > Subject: RE: [PATCH v3 7/7] app/testpmd: adjust ethdev port > > > > > > ownership > > > > > > > > > > > > Hi Matan, > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Matan Azrad [mailto:matan@mellanox.com] > > > > > > > Sent: Thursday, January 18, 2018 4:35 PM > > > > > > > To: Thomas Monjalon ; Gaetan Rivet > > > > > > > ; Wu, Jingjing > > > > > > > > > > > > > > Cc: dev@dpdk.org; Neil Horman ; > > > > Richardson, > > > > > > > Bruce ; Ananyev, Konstantin > > > > > > > > > > > > > > Subject: [PATCH v3 7/7] app/testpmd: adjust ethdev port > > > > > > > ownership > > > > > > > > > > > > > > Testpmd should not use ethdev ports which are managed by > > > > > > > other DPDK entities. > > > > > > > > > > > > > > Set Testpmd ownership to each port which is not used by > > > > > > > other entity and prevent any usage of ethdev ports which are > > > > > > > not owned by > > > > Testpmd. > > > > > > > > > > > > > > Signed-off-by: Matan Azrad > > > > > > > --- > > > > > > > app/test-pmd/cmdline.c | 89 +++++++++++++++++++--------= -- > ------- > > > > ---- > > > > > > ----- > > > > > > > app/test-pmd/cmdline_flow.c | 2 +- > > > > > > > app/test-pmd/config.c | 37 ++++++++++--------- > > > > > > > app/test-pmd/parameters.c | 4 +- > > > > > > > app/test-pmd/testpmd.c | 63 ++++++++++++++++++++-------= - > ---- > > > > > > > app/test-pmd/testpmd.h | 3 ++ > > > > > > > 6 files changed, 103 insertions(+), 95 deletions(-) > > > > > > > > > > > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > > > > > > > index > > > > > > > 31919ba..6199c64 100644 > > > > > > > --- a/app/test-pmd/cmdline.c > > > > > > > +++ b/app/test-pmd/cmdline.c > > > > > > > @@ -1394,7 +1394,7 @@ struct cmd_config_speed_all { > > > > > > > &link_speed) < 0) > > > > > > > return; > > > > > > > > > > > > > > - RTE_ETH_FOREACH_DEV(pid) { > > > > > > > + RTE_ETH_FOREACH_DEV_OWNED_BY(pid, my_owner.id) { > > > > > > > > > > > > Why do we need all these changes? > > > > > > As I understand you changed definition of > > > > > > RTE_ETH_FOREACH_DEV(), so no testpmd should work ok default > (no_owner case). > > > > > > Am I missing something here? > > > > > > > > > > Now, After Gaetan suggestion RTE_ETH_FOREACH_DEV(pid) will > > > > > iterate > > > > over all valid and ownerless ports. > > > > > > > > Yes. > > > > > > > > > Here Testpmd wants to iterate over its owned ports. > > > > > > > > Why? Why it can't just iterate over all valid and ownerless ports? > > > > As I understand it would be enough to fix current problems and > > > > would allow us to avoid any changes in testmpd (which I think is a = good > thing). > > > > > > Yes, I understand that this big change is very daunted, But I think > > > the current a lot of bugs in testpmd(regarding port ownership) even > > > more > > daunted. > > > > > > Look, > > > Testpmd initiates some of its internal databases depends on specific > > > port iteration, In some time someone may take ownership of Testpmd > ports and testpmd will continue to touch them. >=20 > But if someone will take the ownership (assign new owner_id) that port wi= ll > not appear in RTE_ETH_FOREACH_DEV() any more. >=20 Yes, but testpmd sometimes depends on previous iteration using internal dat= abase. So it uses internal database that was updated by old iteration. =20 > > > > > > > If I look back on the fail-safe, its sole purpose is to have seamless > > hotplug with existing applications. > > > > Port ownership is a genericization of some functions introduced by the > > fail-safe, that could structure DPDK further. It should allow > > applications to have a seamless integration with subsystems using port > > ownership. Without this, port ownership cannot be used. > > > > Testpmd should be fixed, but follow the most common design patterns of > > DPDK applications. Going with port ownership seems like a paradigm > > shift. > > > > > In addition > > > Using the old iterator in some places in testpmd will cause a race fo= r run- > time new ports(can be created by failsafe or any hotplug code): > > > - testpmd finds an ownerless port(just now created) by the old > > > iterator and start traffic there, > > > - failsafe takes ownership of this new port and start traffic there. > > > Problem! >=20 > Could you shed a bit more light here - it would be race condition between > whom and whom? Sure. > As I remember in testpmd all control ops are done within one thread (main > lcore). But other dpdk entity can use another thread, for example: Failsafe uses the host thread(using alarm callback) to create a new port an= d to take ownership of a port. The race: Testpmd iterates over all ports by the master thread. Failsafe takes ownership of a port by the host thread and start using it.=20 =3D> The two dpdk entities may use the device at same time! Obeying the new ownership rules can prevent all these races. > The only way to attach/detach port with it - invoke testpmd CLI > "attach/detach" port. >=20 > Konstantin >=20 > > > > Testpmd does not handle detection of new port. If it did, testing > > fail-safe with it would be wrong. > > > > At startup, RTE_ETH_FOREACH_DEV already fixed the issue of registering > > DEFERRED ports. There are still remaining issues regarding this, but I > > think they should be fixed. The architecture does not need to be > > completely moved to port ownership. > > > > If anything, this should serve as a test for your API with common > > applications. I think you'd prefer to know and debug with testpmd > > instead of firing up VPP or something like that to determine what went > > wrong with using the fail-safe. > > > > > > > > In addition > > > As a good example for well-done application (free from ownership > > > bugs) I tried here to adjust Tespmd to the new rules and BTW to fix > > > a > > lot of bugs. > > > > Testpmd has too much cruft, it won't ever be a good example of a > > well-done application. > > > > If you want to demonstrate ownership, I think you should start an > > example application demonstrating race conditions and their mitigation. > > > > I think that would be interesting for many DPDK users. > > > > > > > > > > > So actually applications which are not aware to the port ownership > > > still are exposed to races, but if there use the old iterator(with > > > the new > > change) the amount of races decreases. > > > > > > Thanks, Matan. > > > > Konstantin > > > > > > > > > > > > > > I added to Testpmd ability to take an ownership of ports as the > > > > > new ownership and synchronization rules suggested, Since Tespmd > > > > > is a DPDK entity which wants that no one will touch its owned > > > > > ports, It must allocate > > > > an unique ID, set owner for its ports (see in main function) and > > > > recognizes them by its owner ID. > > > > > > > > > > > Konstantin > > > > > > > > > > Regards, > > -- > > Ga=EBtan Rivet > > 6WIND