From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BDBDA0562; Sun, 29 Mar 2020 12:18:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A452A1AFF; Sun, 29 Mar 2020 12:18:38 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140057.outbound.protection.outlook.com [40.107.14.57]) by dpdk.org (Postfix) with ESMTP id 959BDF3E; Sun, 29 Mar 2020 12:18:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bwZv0ICrItLFnuIzqV8NphRI4BpjKKGXWh07E9MHrYWpjnlmz1tbdNo/FEK0NGKJQhYvPHduNKTbjzc7xAxBT5zBmgrc6kDkrRRwG6MkfVx09oftmET1Ebh7xSoyj2/pBgaRKualBlcsNvPrE5WiR2Mq+KVljNilYSOjXb/X53YEXiqXUuKGPotyILzKYwU0TdVob0/LEIHqGmbVUwBq+os4IWMyabs+/BPZquiuTTslTYMT8b9UqJ2xun5lvzZ4Ib9XJk6Tdwid5sMGusRsLb5GPJ2XC4fZ+3TL2zDtEBkb8iwfcT6xOatqfLLYZrA0dDGf9kcknNKf0qfzY7b7xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N94/Qr69DC0GNg9Tqm2dc2Sdngu9uBGUQZrF1tgosnI=; b=EUeT6VShybAsrd9jM3jW+6/JYxvmnpM+0tyE+UgATsLV2vGUTNLOR5YGELBkYtTji8HbQExTO8VSPYaEszdR6Od7sEzKg+0YdRVYYKl+h5nWUjOunb9Jl5DhJm5dfOKRIad7fk/NGdP8kWTVEfbMuprf6y0iPkKxyZCklp3OntZtPzp0GnB6veGBzt4xnZRf1Fq5LMVBAGZkxoB+55IYnZ13/EU9MiCZ1CqUK0KMC2GAaVGObpSSwFecgeubOgMhGqMXzw7kKTyw8q8DUeZXxv7S1JNl7KCxzUaE3qXeeZGhYhBaCWrFPmjPBJ9etPRYrNIbkHRMmZoUx1EGejuqxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N94/Qr69DC0GNg9Tqm2dc2Sdngu9uBGUQZrF1tgosnI=; b=Y4WUJmS9SvlNRBsKxpU1qIp2orES6lVyyQQrf9dfoSIFGuX9N1kAXa9Audth767OMiD3bd/qg5cq+oKOM4R91PIQjchFIb7B6XDqJHinEPNiAcvfwcA7/34qcPOakYuOWcgwfr24Kmyj92nVzHa6ax1OiSWNKEjYylj5XD1R5DE= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (20.177.196.158) by AM6PR05MB5079.eurprd05.prod.outlook.com (20.177.36.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 10:18:36 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22%7]) with mapi id 15.20.2856.019; Sun, 29 Mar 2020 10:18:36 +0000 From: Ori Kam To: "Zhang, Xiao" , "dev@dpdk.org" CC: "Wang, Ying A" , "Zhang, Qi Z" , "Zhao1, Wei" , "stable@dpdk.org" Thread-Topic: app/testpmd: fix PPPOES flow API Thread-Index: AQHWBBGaeM8mPPPhN06u+6qAGH787KhfHGRwgAAuDYCAABH+kA== Date: Sun, 29 Mar 2020 10:18:36 +0000 Message-ID: References: <20200327081926.6154-1-xiao.zhang@intel.com> <2966f158164c411e897b3ab741787eea@intel.com> In-Reply-To: <2966f158164c411e897b3ab741787eea@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3e850964-91c2-4899-ee8b-08d7d3ca8afa x-ms-traffictypediagnostic: AM6PR05MB5079: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 035748864E x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(39850400004)(136003)(376002)(346002)(366004)(6506007)(53546011)(55016002)(81166006)(33656002)(110136005)(54906003)(52536014)(81156014)(7696005)(76116006)(26005)(9686003)(478600001)(5660300002)(71200400001)(8936002)(66946007)(64756008)(66556008)(66476007)(66446008)(186003)(2906002)(8676002)(4326008)(86362001)(316002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EYqw6N0zUyyCOxcITeu4jADQeG85BuzktknShz3tRzBgOgbt00w5bNU17Qs02IKs/k0jI6zomhGgSSp8l2oTbRXnWqL7QQXsR/FAfvRWS/LvQYeW/j6+d4lPX8pO7QavG0utUzDNTGbRysHHJ3BjvaWKhUro2QgJhQ6gq/2HB0hqnnQnoUWU89fdUbwfYGuwuSWgir1w+SiKKsR5wbreDxgE2Py6mdklP9yGBnWbKABY2GkspKbX7EA/Cy9J8MXZC1eVJai/J+1amXr/9uTpUty0WhMO5Skse+C8trsmv3+QKco8C9iopT+HliuXPmumzFi21IOBAk9KWAOCuIIGGvsih+MimrhkiKoXeiYBu6DbDcSGoBfMte18ksqvUtvV7yBSNGSIxbUbRqgQu9DcrOJf3IrWks8hahDPrqVqgRn4vZHXOH7JCb7MESZMQUXW x-ms-exchange-antispam-messagedata: B3kLETxIVoMY5USckoboTs4qeVLk/TdwDY1d2+/cvTRB/ld/sfI2JTyl4ADz51wVMT3Lj4JLXHyvNW5Gw/x9WLl7VOmANwjsnLQXv4fWd9+nG1PuHDsZeSOPVfllXR68J2EPiXGBwtPO13RpGeWVOA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e850964-91c2-4899-ee8b-08d7d3ca8afa X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2020 10:18:36.3830 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LA3i7NFsehtD1Ats8kxf51jFPFnaPAcuHWaa2R2m82ZhablGXOFUfBwQFhqUKZLFYApvnmMqJ170/G168dVdTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5079 Subject: Re: [dpdk-dev] app/testpmd: fix PPPOES flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiao, > -----Original Message----- > From: Zhang, Xiao > Sent: Sunday, March 29, 2020 12:06 PM > To: Ori Kam ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; stable@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API >=20 > Hi Ori, >=20 > > -----Original Message----- > > From: Ori Kam > > Sent: Sunday, March 29, 2020 2:28 PM > > To: Zhang, Xiao ; dev@dpdk.org > > Cc: Wang, Ying A ; Zhang, Qi Z > > ; Zhao1, Wei ; > stable@dpdk.org > > Subject: RE: app/testpmd: fix PPPOES flow API > > > > Hi Xiao, > > > > Is the proto_id part of the basic header or not? >=20 > Proto_id is part of PPPOE session header, >=20 Where is the porto_id located? Inside the payload? > > > > From the spec it looks like a different header. > > > > If it is part of the original header then all documentations and rte_st= ructs > should > > be changed, to reflect this. > > > > It will be very helpful if the patch message would explain the bug and = why it > was > > changed. >=20 > Okay, will add more message. The next value of the ITEM_PPPOE_PROTO_ID > should be unsigned value but not item list. >=20 > > > > Also please see inline other comment. > > > > Best, > > Ori > > > > > -----Original Message----- > > > From: Xiao Zhang > > > Sent: Friday, March 27, 2020 11:19 AM > > > To: dev@dpdk.org > > > Cc: Ori Kam ; ying.a.wang@intel.com; > > > qi.z.zhang@intel.com; wei.zhao1@intel.com; Xiao Zhang > > > ; stable@dpdk.org > > > Subject: app/testpmd: fix PPPOES flow API > > > > > > The command line to create RTE flow for specific proto_id of PPPOES i= s > > > not correct. This patch is to fix this issue. > > > > > > Fixes: 226c6e60c35b ("ethdev: add PPPoE to flow API") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Xiao Zhang > > > --- > > > app/test-pmd/cmdline_flow.c | 13 +++---------- > > > 1 file changed, 3 insertions(+), 10 deletions(-) > > > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.= c > > > index a78154502..c25a2598d 100644 > > > --- a/app/test-pmd/cmdline_flow.c > > > +++ b/app/test-pmd/cmdline_flow.c > > > @@ -768,7 +768,6 @@ static const enum index next_item[] =3D { > > > ITEM_GTP_PSC, > > > ITEM_PPPOES, > > > ITEM_PPPOED, > > > - ITEM_PPPOE_PROTO_ID, > > > ITEM_HIGIG2, > > > ITEM_TAG, > > > ITEM_L2TPV3OIP, > > > @@ -1030,11 +1029,6 @@ static const enum index item_pppoed[] =3D { > > > > > > static const enum index item_pppoes[] =3D { > > > ITEM_PPPOE_SEID, > > > - ITEM_NEXT, > > > - ZERO, > > > -}; > > > - > > > -static const enum index item_pppoe_proto_id[] =3D { > > > ITEM_PPPOE_PROTO_ID, > > > ITEM_NEXT, > > > ZERO, > > > @@ -2643,10 +2637,9 @@ static const struct token token_list[] =3D { > > > [ITEM_PPPOE_PROTO_ID] =3D { > > > .name =3D "proto_id", > > > .help =3D "match PPPoE session protocol identifier", > > > - .priv =3D PRIV_ITEM(PPPOE_PROTO_ID, > > > - sizeof(struct rte_flow_item_pppoe_proto_id)), > > > - .next =3D NEXT(item_pppoe_proto_id), > > > - .call =3D parse_vc, > > > + .next =3D NEXT(item_pppoes, NEXT_ENTRY(UNSIGNED), > > > item_param), > > > + .args =3D ARGS(ARGS_ENTRY_HTON > > > + (struct rte_flow_item_pppoe_proto_id, proto_id)), > > > > Where is the memory for this proto_id is defined? >=20 > Do you mean this? > lib/librte_ethdev/rte_flow.h > 1360 struct rte_flow_item_pppoe_proto_id { > 1361 rte_be16_t proto_id; /**< PPP protocol identifier. */ > 1362 }; >=20 Yes. Why don't you use this one? > > > > > }, > > > [ITEM_HIGIG2] =3D { > > > .name =3D "higig2", > > > -- > > > 2.17.1