From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D00ADA0562; Tue, 31 Mar 2020 11:57:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 505B71BFC4; Tue, 31 Mar 2020 11:57:56 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50086.outbound.protection.outlook.com [40.107.5.86]) by dpdk.org (Postfix) with ESMTP id 6F5921BFC1 for ; Tue, 31 Mar 2020 11:57:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lRsmHYtRE8LQZU06HlMBXJRyB6bAkwioVipuOfcmV3I4jISrp71z6dmps6T3kKmDiNd1m8kkob2ZlqKy6vIj3R43oY9g4CgL4ONew2oYoeJV+osDJmueGBTSSn93RUlfUeQEzCjF/NzuNQnTaN+1VDfOpsPE2fWX0a0lJk9AsUESR8vfoeofKtCiXOPB1/lYMeWm8iObekHoLlczAdSL+DhAKoUEDoEbgoFuScLX9fY45h8fQIbEOW1dgM7WcQ0xQrlbuQ4mK7/Za4M6PqkTYtlwAZiBubJ450DDIEDDjFqAnWJPDw683XwKOviebL1e/JOITyvT1a6gG4f/y5gbgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nk/oJfZqK5un2fQuQt0ps9BLJ6H49IXtdgMtNci6jvk=; b=JKCpe7x0ogpoWSgKHi8ru4C6SFhTa6Vvhmd7/2NffyuoJ/uSGC2okEgW5qn7sXvM/g/FdrOwQqSYC0B9ofGpFtB1RwNM1XRAC3Nknh8f2nR9U/JMS9EH5AYvpWZqpdqhafgFQKdbo3KjqvCWqhwUtBMfwi3JK/1srecQvOYqBORy/a6AiJpbsY5X7ostMaW3ZqSkc8rjjAiCWWsW1o1gW0L8vBcvYzFb2+US8QnSRtkLcLoTundCGmmrsWg1t7klK23aEivsVVfXtaesVlpOyitoa81E5hTeNnWDLLAAlStHNyC85qteTIss0fiCOF2vdaIvCb1gAmOYJx0UH9j5Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nk/oJfZqK5un2fQuQt0ps9BLJ6H49IXtdgMtNci6jvk=; b=mRCyUfW2duVcgW1JmgWcGicMbqxEbIZmN2Wqco2LZLcf1bnhZEjq6JLNcH0UG29sIbNUjDnolmrOQuh+3U7y9ciyz/bFyQegf0ZYRBlrgmPRdDkf6WFjo1l7K4V4kslNIS7tUg2m+xtwgPKXBs3I1vOBKVy1SkizJxWjQnDrUVk= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (20.177.196.158) by AM6PR05MB4149.eurprd05.prod.outlook.com (52.135.169.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Tue, 31 Mar 2020 09:57:54 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22%7]) with mapi id 15.20.2856.019; Tue, 31 Mar 2020 09:57:53 +0000 From: Ori Kam To: Bernard Iremonger , "dev@dpdk.org" , "beilei.xing@intel.com" , "qi.z.zhang@intel.com" , "declan.doherty@intel.com" CC: "konstantin.ananyev@intel.com" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH Thread-Index: AQHWAr3wtpy+W/GoAk6l4qcS60WaDahifZ6w Date: Tue, 31 Mar 2020 09:57:53 +0000 Message-ID: References: <1584535089-29499-1-git-send-email-bernard.iremonger@intel.com> <1585151755-15837-3-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1585151755-15837-3-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b1061076-216d-4292-84f5-08d7d559fb35 x-ms-traffictypediagnostic: AM6PR05MB4149: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 0359162B6D x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(346002)(396003)(376002)(136003)(39860400002)(66946007)(7696005)(52536014)(8936002)(86362001)(71200400001)(26005)(53546011)(4326008)(66476007)(6506007)(478600001)(186003)(66556008)(33656002)(81166006)(64756008)(2906002)(81156014)(110136005)(76116006)(66446008)(5660300002)(55016002)(9686003)(316002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Pw5baS40LB5rXVBpZkmVzZJ0Sk/sXVxNFdtcA0hg4D9B4Kzwgj+yr6Gj2/2EWKATNPPtOiXLjaQzJ7zaJADH3N93rR2dCdfd7ncofYllJor1oFIxi9DTvt2DpqBStsk+mAEhqlEeBYiBDSuvcNYzP7UIwsFh1veSwyK/CycCaaneWa/iUKG0oo5+DDv7Oi4sm3g1j/l8EJmC8poaVDDF4H3gnE8xIH/qRIeY6YakjF2ZRGsh4RoxkPGGqK9GvHGvENhhvvzpksGrZh5tOpyenZPIPslhmdNXeUYVGuqJfG9/8J+iU2MOTNjLiHhoDgm34ALAjzizI+EXS/n5T6F01zNryW+plbIdq0nGYeLCX1h8anSB+wx7u2yuSdoNI2Mzb+9ZFJ3120Nh0nhG4mUxgB5TWpAceREtkTaiVkljFkGqfxdhtY0CUuLkuSNhJZJW x-ms-exchange-antispam-messagedata: KirOqx3o8zQ6xrogu9ElHPdvfbOjF2uCRrrz15evADQ+dgqneltIP5CWybf9gCWU9RbCUiu1TQBy2HNMqjumvhdRX3iOInfgGN4bYQ5hZZXNZu129eamiSkkjykWHw2TZs869hbOXvkHFpHGwBzOUg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1061076-216d-4292-84f5-08d7d559fb35 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2020 09:57:53.8209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SJ44fRu2bxUVSAZrsEGlKYSeUQjGZm+Zr/3xvSSCeK24TjbcPYDPllpnvGE5UJRaYc1rSKnMghBGid83RzEqDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4149 Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bernard, > -----Original Message----- > From: dev On Behalf Of Bernard Iremonger > Sent: Wednesday, March 25, 2020 5:56 PM > To: dev@dpdk.org; beilei.xing@intel.com; qi.z.zhang@intel.com; > declan.doherty@intel.com > Cc: konstantin.ananyev@intel.com; Bernard Iremonger > > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types = ESP > and AH >=20 > parse RSS offload types ESP and AH > add printf for rss_hf >=20 > Signed-off-by: Bernard Iremonger > --- > app/test-pmd/cmdline.c | 4 +++- > app/test-pmd/config.c | 6 ++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index a037a55..997f063 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result, > i, -diag, strerror(-diag)); > } > } > - if (all_updated && !use_default) > + if (all_updated && !use_default) { > rss_hf =3D rss_conf.rss_hf; > + printf("rss_hf %#"PRIx64"\n", rss_hf); > + } > } >=20 > cmdline_parse_token_string_t cmd_config_rss_port =3D > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 8cf84cc..df52df9 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -106,6 +106,12 @@ const struct rss_type_info rss_type_table[] =3D { > { "l3-dst-only", ETH_RSS_L3_DST_ONLY }, > { "l4-src-only", ETH_RSS_L4_SRC_ONLY }, > { "l4-dst-only", ETH_RSS_L4_DST_ONLY }, > + { "ipv4-esp", ETH_RSS_ESP }, > + { "ipv6-esp", ETH_RSS_ESP }, > + { "ipv4-udp-esp", ETH_RSS_ESP }, > + { "ipv6-udp-esp", ETH_RSS_ESP }, > + { "ipv4-ah", ETH_RSS_AH }, > + { "ipv6-ah", ETH_RSS_AH }, Why do you have all those variations since they don't have any affect. I think it should be just like your first patch, only esp and ah. For example the udp should look like this:=20 flow create 0 ingress pattern eth / end actions rss queues 0 1 end types ud= p esp end / end Best, Ori > { NULL, 0 }, > }; >=20 > -- > 2.7.4