From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B762BA0562; Sun, 29 Mar 2020 08:28:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64BB42C6E; Sun, 29 Mar 2020 08:28:00 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2065.outbound.protection.outlook.com [40.107.20.65]) by dpdk.org (Postfix) with ESMTP id CBC551AFF; Sun, 29 Mar 2020 08:27:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DtYgofC4cH/fu19ucAN9wQdp0mh1Nhj1hrjoP4tlTKGCoOCrKnemfGd1KHNICIrTI92QrjsAngsFZ0wRG9WhWrEuEtdbosIx25S96amW6gRuB3vc+7Wk3DWgJgTNRj1dycoN0gR5O6ad5oBh8IIvJK9yPsW7JjjhWNb/Vuke6psn34LOLdJ/3KVYc6oArWR/b0NvHaqPLn+ADDobok75HJfujh7o16Cz26+py6i1+Rj41ptd5HFZIzMSx8cZIfkNIW0nQUWg/smiMY1wQs2MJY4s617idmgeZC+v941+sJMYY6E48jFp7UJbOMbFDxpxFyYNnVK1wNEIcIBEzTKhZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3qsPn56EEGYZmAkfY+OQhAJ2N5e9flxzh3NUxfTv5mY=; b=UM17zuAB00Xk/GbN3Oy/qeFWzlsBCVKkokbh12aYQSrQ0H18/cxby/hHoN2Aomg96vgeV0VdwdYUt4kdYlGUKR8Ht0HwF5j5x6Xajg+rurioYRhx/Czy+FIm5nr+I8PO1MePc+NTUgmRTPXLNZyxzsEz7PJ11k7vK0HowbgRgxfRS55zYqbD8VccvQruRZ/Z6Y82XQERnHe+h1uNysoW1qBhCX8PyrY0vbK5gcj+dMj5WEiLvTSrxHVLWqRKGhJUa1MyihzfaZYtF0SKA0YASYzfnwWIZtU1PPo7IiHecT7bfhoszIkmElfApd0GQKWVmlVMRdDyrnAKTpc6QGJWBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3qsPn56EEGYZmAkfY+OQhAJ2N5e9flxzh3NUxfTv5mY=; b=jvxwidLIaVVtJztzWTyRJlgurozsWctB7MiOF/uj3wBpRzNkPnDsi8h3adKZ5Zz66uTrNzMZ3OgxqNw6y80+oDMxQ3wZQ/P1y8JIqbt6iQJKTF7ThrCy8DJUIpPUyYdT6XliGopzwWTVMg4pxTUZ7RFptaYFiobDUR9b5TOwgC4= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (20.177.196.158) by AM6PR05MB6312.eurprd05.prod.outlook.com (20.179.18.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 06:27:58 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22%7]) with mapi id 15.20.2856.019; Sun, 29 Mar 2020 06:27:58 +0000 From: Ori Kam To: Xiao Zhang , "dev@dpdk.org" CC: "ying.a.wang@intel.com" , "qi.z.zhang@intel.com" , "wei.zhao1@intel.com" , "stable@dpdk.org" Thread-Topic: app/testpmd: fix PPPOES flow API Thread-Index: AQHWBBGaeM8mPPPhN06u+6qAGH787KhfHGRw Date: Sun, 29 Mar 2020 06:27:57 +0000 Message-ID: References: <20200327081926.6154-1-xiao.zhang@intel.com> In-Reply-To: <20200327081926.6154-1-xiao.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4c50f175-19b9-44d8-180f-08d7d3aa529b x-ms-traffictypediagnostic: AM6PR05MB6312: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 035748864E x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(376002)(366004)(136003)(39850400004)(396003)(346002)(6506007)(7696005)(53546011)(5660300002)(71200400001)(33656002)(8676002)(478600001)(110136005)(186003)(9686003)(55016002)(54906003)(4326008)(26005)(66946007)(52536014)(66556008)(66446008)(76116006)(64756008)(66476007)(81166006)(86362001)(2906002)(8936002)(81156014)(316002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: udzkMjgqmqqzNccubsgrVtc6RKuxgy2vd1fOUBjNW2h75cplw5NyoIJnIK98a5MmUvYMxjozmC5hDcCpbuch3FTuza/aUtFN6wfZUzWyZMGt+FdrJbof/8kg2qXcA+rIg3t76sfMlLZ3PwqAf4kDZkX48nowMp0yGjSqqq4BPHBnYxRTnWorjqMiy0D+MPn/QNLQgU+wogOvkgxK11412JzL2nC7u28TK30k9PTRVBZTqHgYA1OH0Y8f38fGX60mZqDxfYZxBs/4tEIU04+bookrvnAwJn2ehFwOf1NpVmoujPPpMSoDhGKBzhdyBTVcDvEKfQbDsz4y4Y3Xi2LT9q0vmiNrO7BXU4oGzzQUx6kWMrIQP4rBVw/BgdmlMLjyR2RgQNWGEmPfMWpnuv3qvgU+RSLshBnCVtBc9h0xPbFpUYK6UIKympOuldMuUOrS x-ms-exchange-antispam-messagedata: QS03RTrGyalhl7BEiV3Kt3zeHKVbgwj5Dv+Vazktpbzg23QKlT+RIGtGct8x/3N8C1ZdcDX3JqLEVAQI0NIc7vHttSIBPn/HBC6y2PtSiXaetT/1JGOMbk1y+dCMO5EPbtOk3NImxk8zDDdrutIKzQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c50f175-19b9-44d8-180f-08d7d3aa529b X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2020 06:27:57.8972 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0Ijzp9KKOTZI2hf5J5Rku88UkWLfIYstN+FuP6XHGl1yXhs7kMT0oYeD7ErszUP438v4PmLLDatiYcqLT7uUbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6312 Subject: Re: [dpdk-dev] app/testpmd: fix PPPOES flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiao, Is the proto_id part of the basic header or not? >From the spec it looks like a different header. If it is part of the original header then all documentations and rte_struct= s should be changed, to reflect this. It will be very helpful if the patch message would explain the bug and why = it was changed. Also please see inline other comment. Best, Ori > -----Original Message----- > From: Xiao Zhang > Sent: Friday, March 27, 2020 11:19 AM > To: dev@dpdk.org > Cc: Ori Kam ; ying.a.wang@intel.com; > qi.z.zhang@intel.com; wei.zhao1@intel.com; Xiao Zhang > ; stable@dpdk.org > Subject: app/testpmd: fix PPPOES flow API >=20 > The command line to create RTE flow for specific proto_id of PPPOES is > not correct. This patch is to fix this issue. >=20 > Fixes: 226c6e60c35b ("ethdev: add PPPoE to flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiao Zhang > --- > app/test-pmd/cmdline_flow.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index a78154502..c25a2598d 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -768,7 +768,6 @@ static const enum index next_item[] =3D { > ITEM_GTP_PSC, > ITEM_PPPOES, > ITEM_PPPOED, > - ITEM_PPPOE_PROTO_ID, > ITEM_HIGIG2, > ITEM_TAG, > ITEM_L2TPV3OIP, > @@ -1030,11 +1029,6 @@ static const enum index item_pppoed[] =3D { >=20 > static const enum index item_pppoes[] =3D { > ITEM_PPPOE_SEID, > - ITEM_NEXT, > - ZERO, > -}; > - > -static const enum index item_pppoe_proto_id[] =3D { > ITEM_PPPOE_PROTO_ID, > ITEM_NEXT, > ZERO, > @@ -2643,10 +2637,9 @@ static const struct token token_list[] =3D { > [ITEM_PPPOE_PROTO_ID] =3D { > .name =3D "proto_id", > .help =3D "match PPPoE session protocol identifier", > - .priv =3D PRIV_ITEM(PPPOE_PROTO_ID, > - sizeof(struct rte_flow_item_pppoe_proto_id)), > - .next =3D NEXT(item_pppoe_proto_id), > - .call =3D parse_vc, > + .next =3D NEXT(item_pppoes, NEXT_ENTRY(UNSIGNED), > item_param), > + .args =3D ARGS(ARGS_ENTRY_HTON > + (struct rte_flow_item_pppoe_proto_id, proto_id)), Where is the memory for this proto_id is defined? > }, > [ITEM_HIGIG2] =3D { > .name =3D "higig2", > -- > 2.17.1