From: Ori Kam <orika@mellanox.com>
To: David Christensen <drc@linux.vnet.ibm.com>,
Thomas Monjalon <thomas@monjalon.net>,
Matan Azrad <matan@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal/ppc: fix redefine bool type
Date: Thu, 30 Apr 2020 08:54:57 +0000 [thread overview]
Message-ID: <AM6PR05MB51765C5F72F88B003CCA0225DBAA0@AM6PR05MB5176.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <cdac0c61-b4cb-119f-4b07-a4ffe04d1943@linux.vnet.ibm.com>
Hi David,
I will add your code.
Thanks,
Ori
> -----Original Message-----
> From: David Christensen <drc@linux.vnet.ibm.com>
> Sent: Tuesday, April 28, 2020 9:20 PM
> To: Ori Kam <orika@mellanox.com>; Thomas Monjalon
> <thomas@monjalon.net>; Matan Azrad <matan@mellanox.com>; Shahaf
> Shuler <shahafs@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org; ferruh.yigit@intel.com
> Subject: Re: [PATCH] eal/ppc: fix redefine bool type
>
> > Fixes: 725f5dd0bfb5 ("net/mlx5: fix build on PPC64")
> >
> > Signed-off-by: Ori Kam <orika@mellanox.com>
> > ---
>
> There are a couple of other uses that should be covered in the patch:
>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_altivec.c
> b/drivers/net/i40e/i40e_rxtx_vec_altivec.c
> index 5fa92bf92..72bd410fc 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_altivec.c
> +++ b/drivers/net/i40e/i40e_rxtx_vec_altivec.c
> @@ -13,7 +13,7 @@
> #include "i40e_rxtx.h"
> #include "i40e_rxtx_vec_common.h"
>
> -#include <altivec.h>
> +#include "rte_altivec.h"
>
> #pragma GCC diagnostic ignored "-Wcast-qual"
>
>
> diff --git a/drivers/net/virtio/virtio_rxtx_simple_altivec.c
> b/drivers/net/virtio/virtio_rxtx_simple_altivec.c
> index 47225f412..b2bdd05c8 100644
> --- a/drivers/net/virtio/virtio_rxtx_simple_altivec.c
> +++ b/drivers/net/virtio/virtio_rxtx_simple_altivec.c
> @@ -9,7 +9,7 @@
> #include <string.h>
> #include <errno.h>
>
> -#include <altivec.h>
> +#include "rte_altivec.h"
>
> #include <rte_byteorder.h>
> #include <rte_branch_prediction.h>
>
> Dave
next prev parent reply other threads:[~2020-04-30 8:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 7:58 Ori Kam
2020-04-28 18:20 ` David Christensen
2020-04-30 8:54 ` Ori Kam [this message]
2020-04-29 8:17 ` David Marchand
2020-04-30 8:53 ` Ori Kam
2020-04-30 9:04 ` David Marchand
2020-04-30 9:06 ` Ori Kam
2020-04-30 14:22 ` [dpdk-dev] [PATCH v2] " Ori Kam
2020-04-30 19:41 ` David Christensen
2020-05-03 6:34 ` Raslan Darawsheh
2020-05-03 7:31 ` Matan Azrad
2020-05-06 9:41 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR05MB51765C5F72F88B003CCA0225DBAA0@AM6PR05MB5176.eurprd05.prod.outlook.com \
--to=orika@mellanox.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).