From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C67FEA056B; Tue, 3 Mar 2020 09:48:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 42E001BFF9; Tue, 3 Mar 2020 09:48:40 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20049.outbound.protection.outlook.com [40.107.2.49]) by dpdk.org (Postfix) with ESMTP id 8BECD1BFF2 for ; Tue, 3 Mar 2020 09:48:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mMXpajXSInb257htRhnyitQOJUUxA9buR4mcvQyyhq4koU29F/cc3GRmlgev0jGHEj3JgkIaA+AZ2zS61TJ32D4KDBiZROJLdde2YjmX+/coSnpMKFCGcshYNEWwV/gTiAZnOKYaV3Ls9i3Egy8+5InWcLWTYJ77KbkSzhTExt8A5wkhaIod76oWDBcRF5FjiyG0jjDi4MDPYM8KonRR6MVTpwImMBFGnse35JvMAHN8Iu967Sz71ubH202UABfVU8AYLhljmWcVmDxEmcRzLYqAxyo3WrR3DCbbswcOsIm0Dg3+j1e+6rOa2FfsYuJgJNup1tKj6aD0t2xnDz4ncg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jazJYAiJTXyKBwsurIw0TufWHb7ToLVaYsvzU6Z1ttM=; b=NGreCpVmsCp6wY7fiVGkN7ecxeVWMHyFk1ln0OR2aKNaP998B44Uwx/LBfLyPqKi8oGsNQWkQrvGrD+P2i+S7J/Kjxmn9PgkTbX8tq0y4ZFQgpRuhtBEEn0tyy8GfBvTJBb92a72V9L0FK0lwuM6Y6KPD/jAdPOx7adfqOVAKvH0Tr4mpclDXtXP7Q1tqB/NlYxPTXMJZ4gZPw9C2vsx7Utq71LSr75a92zBoC7IawKnn/kL68FI4pGJEbP3xkdBwepCiuSumFy6Lu6xbTUzjORsPYR2qNs5tZf5kpbireS3ELZIo1qsEgbAhuQg8t5S2mLrnkB1dTomRbaPqSYnaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jazJYAiJTXyKBwsurIw0TufWHb7ToLVaYsvzU6Z1ttM=; b=MXlOxRJYROuAFTphAPnXMI9Z7kvztmiQey3O1D5tRkwuRx72xxYTGbexUi+a3HnsT9ym5mGKKoBZYrJNBFHMYdaHV1IEVA0MoIQIhSbXR1sYoWC4matS3NRFf9YV5rexaV6nQGMfBog9H8T0m1XVFek/865a5i+kH4fv32c7pRU= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (20.177.196.158) by AM6PR05MB5604.eurprd05.prod.outlook.com (20.177.189.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18; Tue, 3 Mar 2020 08:48:38 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::1888:dbf5:a84e:c53b]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::1888:dbf5:a84e:c53b%6]) with mapi id 15.20.2772.019; Tue, 3 Mar 2020 08:48:38 +0000 From: Ori Kam To: Xiao Zhang , "dev@dpdk.org" CC: "arybchenko@solarflare.com" , "ferruh.yigit@intel.com" Thread-Topic: [dpdk-dev] ethdev: add PFCP header to flow API Thread-Index: AQHV56OeHvDNRm/7oE6W0rLADHgT8qg2mK4A Date: Tue, 3 Mar 2020 08:48:38 +0000 Message-ID: References: <1582171324-70188-1-git-send-email-xiao.zhang@intel.com> In-Reply-To: <1582171324-70188-1-git-send-email-xiao.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 97cba407-0772-4ff9-0c18-08d7bf4faabc x-ms-traffictypediagnostic: AM6PR05MB5604: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:862; x-forefront-prvs: 03319F6FEF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(189003)(199004)(8936002)(9686003)(55016002)(81156014)(33656002)(5660300002)(81166006)(66946007)(66556008)(8676002)(66446008)(86362001)(66476007)(76116006)(64756008)(4326008)(6506007)(71200400001)(186003)(53546011)(7696005)(26005)(54906003)(2906002)(316002)(52536014)(110136005)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB5604; H:AM6PR05MB5176.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fWvUSIik9NSKpYw0FskP1BY/Ok7VzNum5WVYE3QwEosg28GjhWRGJkWe+s/6sLm6wabDvN7LsmnDsat7ZuaToNDoGs2CUlvFWCt6qJ9QcQnSaQlAgn/0Vn3YeXWnhlqSe7pEyMmBkADkc5KI7m2YafpR9BY++xpgzukWESqvEUptNWUwgdpD3n4bbj+R7v5SYCXRCFFvukSWZAo+o3+C5enYgSt5UISt2+RzV+ZyECBvnFISGb1DdQaW47lQHQy6/7Lq2owerQL4Nj5Zrek+K4TW/BvTkQWays8ttWwP5NL/vPRK3gGY2fTxo5PZcDJHWK3Tv+pJlzHa77WSBZSW9q6bSDkM9ELIBPnYNqM9UEwk+Xdrrfyz24Lr/zDs8FfrGFlr0roNN5JkaGCm8ejXWQqHUmakxvbF81JvyfcPepujKsTo7zvwoiOypYcynH7w x-ms-exchange-antispam-messagedata: chMVX1NDaZdbVPhMjCd1NHiWtvdXZAiCW6IH7TlVCeuwO2vD+0nCLxK1w8NEhNWzVP9Yv/ZHFCzyrXAU7fVtC9arGkM/RkmVHBXzbNLn8fEhvMLWLiICjoB5hF+oHFudV3iSI0bHWSRa5ZE6Nnl5pw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97cba407-0772-4ff9-0c18-08d7bf4faabc X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2020 08:48:38.2507 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +a1DxbeYIVKZe93ROUGZyIM57+8xGQ9xaatkNyRA92LThxfqekwmGAw18rZKN31dGOhDN4EKB1ezhq8sb0CdtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5604 Subject: Re: [dpdk-dev] ethdev: add PFCP header to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiao, Sorry for delayed response. Thanks, Ori > -----Original Message----- > From: dev On Behalf Of Xiao Zhang > Sent: Thursday, February 20, 2020 6:02 AM > To: dev@dpdk.org > Cc: arybchenko@solarflare.com; ferruh.yigit@intel.com; Xiao Zhang > > Subject: [dpdk-dev] ethdev: add PFCP header to flow API >=20 > This patch adds the new flow item RTE_FLOW_ITEM_TYPE_PFCP to flow API to > match a PFCP header. > Add sample PFCP rules for testpmd guide. Since Session Endpoint > Identifier (SEID) only will be present in PFCP Session header and PFCP > Session headers shall be identified when the S field is equal to 1, when > create rules for PFCP Session header with certain SEID the S field need > be set 1. >=20 > Signed-off-by: Xiao Zhang > --- > app/test-pmd/cmdline_flow.c | 37 > +++++++++++++++++++++++++++++ > doc/guides/prog_guide/rte_flow.rst | 11 +++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 20 ++++++++++++++++ > lib/librte_ethdev/rte_flow.c | 1 + > lib/librte_ethdev/rte_flow.h | 31 +++++++++++++++++++++++= + > 5 files changed, 100 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index c2cc4c5..0b735cd 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -220,6 +220,9 @@ enum index { > ITEM_L2TPV3OIP_SESSION_ID, > ITEM_ESP, > ITEM_ESP_SPI, > + ITEM_PFCP, > + ITEM_PFCP_S_FIELD, > + ITEM_PFCP_SEID, >=20 > /* Validate/create actions. */ > ACTIONS, > @@ -768,6 +771,7 @@ static const enum index next_item[] =3D { > ITEM_TAG, > ITEM_L2TPV3OIP, > ITEM_ESP, > + ITEM_PFCP, > END_SET, > ZERO, > }; > @@ -1046,6 +1050,13 @@ static const enum index item_esp[] =3D { > ZERO, > }; >=20 > +static const enum index item_pfcp[] =3D { > + ITEM_PFCP_S_FIELD, > + ITEM_PFCP_SEID, > + ITEM_NEXT, > + ZERO, > +}; > + > static const enum index next_set_raw[] =3D { > SET_RAW_INDEX, > ITEM_ETH, > @@ -2699,6 +2710,26 @@ static const struct token token_list[] =3D { > .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_esp, > hdr.spi)), > }, > + [ITEM_PFCP] =3D { > + .name =3D "pfcp", > + .help =3D "match pfcp header", > + .priv =3D PRIV_ITEM(PFCP, sizeof(struct rte_flow_item_pfcp)), > + .next =3D NEXT(item_pfcp), > + .call =3D parse_vc, > + }, > + [ITEM_PFCP_S_FIELD] =3D { > + .name =3D "s_field", > + .help =3D "S field", > + .next =3D NEXT(item_pfcp, NEXT_ENTRY(UNSIGNED), > item_param), > + .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_pfcp, > + s_field)), > + }, > + [ITEM_PFCP_SEID] =3D { > + .name =3D "seid", > + .help =3D "session endpoint identifier", > + .next =3D NEXT(item_pfcp, NEXT_ENTRY(UNSIGNED), > item_param), > + .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_pfcp, > seid)), > + }, > /* Validate/create actions. */ > [ACTIONS] =3D { > .name =3D "actions", > @@ -6444,6 +6475,9 @@ flow_item_default_mask(const struct rte_flow_item > *item) > case RTE_FLOW_ITEM_TYPE_ESP: > mask =3D &rte_flow_item_esp_mask; > break; > + case RTE_FLOW_ITEM_TYPE_PFCP: > + mask =3D &rte_flow_item_pfcp_mask; > + break; > default: > break; > } > @@ -6541,6 +6575,9 @@ cmd_set_raw_parsed(const struct buffer *in) > size =3D sizeof(struct rte_flow_item_esp); > proto =3D 0x32; > break; > + case RTE_FLOW_ITEM_TYPE_PFCP: > + size =3D sizeof(struct rte_flow_item_pfcp); > + break; > default: > printf("Error - Not supported item\n"); > *total_size =3D 0; > diff --git a/doc/guides/prog_guide/rte_flow.rst > b/doc/guides/prog_guide/rte_flow.rst > index 371819e..2851cee 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -1344,6 +1344,17 @@ Matches a L2TPv3 over IP header. > - ``session_id``: L2TPv3 over IP session identifier. > - Default ``mask`` matches session_id only. >=20 > +Item: ``PFCP`` > +^^^^^^^^^^^^ > + > +Matches a PFCP Header. > + > +- ``s_field``: S field. > +- ``msg_type``: message type. > +- ``msg_len``: message length. > +- ``seid``: session endpoint identifier. > +- Default ``mask`` matches s_field and seid. > + > Actions > ~~~~~~~ >=20 > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 5103ff9..3d05d5f 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -3987,6 +3987,11 @@ This section lists supported pattern items and the= ir > attributes, if any. >=20 > - ``session_id {unsigned}``: L2TPv3 over IP session identifier. >=20 > +- ``pfcp``: match PFCP header. > + > + - ``s_field {unsigned}``: S field. > + - ``seid {unsigned}``: session endpoint identifier. > + > Actions list > ^^^^^^^^^^^^ >=20 > @@ -4822,6 +4827,21 @@ ESP rules can be created by the following > commands:: > testpmd> flow create 0 ingress pattern eth / ipv6 / udp / esp spi is 1 = / end > actions queue index 3 / end >=20 > +Sample PFCP rules > +~~~~~~~~~~~~~~~~ > + > +PFCP rules can be created by the following commands(s_field need to be 1 > +if seid is set):: > + > + testpmd> flow create 0 ingress pattern eth / ipv4 / pfcp s_field is 0 /= end > + actions queue index 3 / end > + testpmd> flow create 0 ingress pattern eth / ipv4 / pfcp s_field is 1 > + seid is 1 / end actions queue index 3 / end > + testpmd> flow create 0 ingress pattern eth / ipv6 / pfcp s_field is 0 /= end > + actions queue index 3 / end > + testpmd> flow create 0 ingress pattern eth / ipv6 / pfcp s_field is 1 > + seid is 1 / end actions queue index 3 / end > + > BPF Functions > -------------- >=20 > diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c > index 885a7ff..a5ac1c7 100644 > --- a/lib/librte_ethdev/rte_flow.c > +++ b/lib/librte_ethdev/rte_flow.c > @@ -94,6 +94,7 @@ static const struct rte_flow_desc_data > rte_flow_desc_item[] =3D { > MK_FLOW_ITEM(AH, sizeof(struct rte_flow_item_ah)), > MK_FLOW_ITEM(HIGIG2, sizeof(struct rte_flow_item_higig2_hdr)), > MK_FLOW_ITEM(L2TPV3OIP, sizeof(struct rte_flow_item_l2tpv3oip)), > + MK_FLOW_ITEM(PFCP, sizeof(struct rte_flow_item_pfcp)), > }; >=20 > /** Generate flow_action[] entry. */ > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index 5625dc4..9addf1c 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -520,6 +520,13 @@ enum rte_flow_item_type { > */ > RTE_FLOW_ITEM_TYPE_L2TPV3OIP, >=20 > + /** > + * Matches PFCP Header. > + * See struct rte_flow_item_pfcp. > + * > + */ > + RTE_FLOW_ITEM_TYPE_PFCP, > + > }; >=20 > /** > @@ -1509,6 +1516,30 @@ static const struct rte_flow_item_ah > rte_flow_item_ah_mask =3D { > #endif >=20 > /** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * > + * RTE_FLOW_ITEM_TYPE_PFCP > + * > + * Match PFCP Header > + * > + */ > +struct rte_flow_item_pfcp { > + uint8_t s_field; > + uint8_t msg_type; > + uint16_t msg_len; > + uint64_t seid; > +}; I think this should be in BE format. > + > +/** Default mask for RTE_FLOW_ITEM_TYPE_PFCP. */ > +#ifndef __cplusplus > +static const struct rte_flow_item_pfcp rte_flow_item_pfcp_mask =3D { > + .s_field =3D 0x01, > + .seid =3D 0xffffffffffffffff, > +}; > +#endif > + > +/** > * Matching pattern item definition. > * > * A pattern is formed by stacking items starting from the lowest protoc= ol > -- > 2.7.4