From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A11A5A0588; Thu, 16 Apr 2020 12:40:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 270471DBE2; Thu, 16 Apr 2020 12:40:44 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150047.outbound.protection.outlook.com [40.107.15.47]) by dpdk.org (Postfix) with ESMTP id 0659A1DBE0 for ; Thu, 16 Apr 2020 12:40:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eytVhQeu19Ayz+9hAynf7/SeiJhbtenCLYExsGjNBdGNBh0er/xENqyxOtDoKcrlj3cfhDyjFfgOFgrDHS/o9MlqyycxCudpL1UdsMXBaKXJWhd3+atWc7dO/YKeQ6Y0CaIyeJb8n30dSt1wNuACaZqOGirKVd1QPnKIFwaIVWUooBpViNW8INuZq2sKfShI9EfcAgcu9Yn6FbgtqYl4UVF7+eC5l3r9TFgeW2VtOyCorUb3ABl1JMYr/I3DOKGZamh4h4Y+Q1o56fw+YV83dpppJqQIxD8NrM5ksW9ZaqegR4dKkcbaM+B1+mCFBIGQ+k9s/PIrfczJJ2j2/oIclQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b3l8IYMb8G8+SzmyzI3SREbGzoxQCrT7BlWN0GcoZFM=; b=OT7hbz99qZUYu1OTJSPTS7JCybYaJRKdtJ6+wcJWxJEdWFKpNG07afyCKV/EO2RR2ZLPjNelAgCHQe9FpNVKzGO6OgmUM4WkzAG8LOMwJudoLXMnQkWXSKH8Z368klWiKzFe5O2V76MtcFD4LKhVrc2Ujz3Fv+mMeVey+cizy7JZ0NEa5h2IZT1jhEkqbROOF5KVqsBMgsZx9H0Hes41MTWFnaIk4RPs45XGxHKHx0d8EfaTPSkLvqqPf1f+5YnVPYwBwJwyEiqWbCs1dBZDLqF7stXphMb5QJcgfK6Jpw98GJOoNbyoFf7dVlvExLVWl6hTSCV+41LrDRb3v9AUiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b3l8IYMb8G8+SzmyzI3SREbGzoxQCrT7BlWN0GcoZFM=; b=FM0bZ4SfFx3BnswwvCF3fl6Anw4a4GaLECYzIBZZgKA7kIgwebBd5Yk7vaNQPh3HNdEIEkTojV9CCxquSoSv7BVvYd9R2g79QElhw3uJWRgIntYqsfxGDuXUYXDVBlhJ8I2yB3aQnvd4oK+cCUcyQoXi5q7iBGv51skFVBlZlh8= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM6PR05MB4325.eurprd05.prod.outlook.com (2603:10a6:209:4a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.17; Thu, 16 Apr 2020 10:40:41 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22%7]) with mapi id 15.20.2900.028; Thu, 16 Apr 2020 10:40:41 +0000 From: Ori Kam To: Jeff Guo , "bernard.iremonger@intel.com" , "xiaolong.ye@intel.com" , "qi.z.zhang@intel.com" CC: "dev@dpdk.org" , "jingjing.wu@intel.com" , "yahui.cao@intel.com" , "simei.su@intel.com" Thread-Topic: [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash commands Thread-Index: AQHWE9kxK/n9OOPbokKOjIj1qhBdcqh7jdpg Date: Thu, 16 Apr 2020 10:40:41 +0000 Message-ID: References: <20200318170401.7938-5-jia.guo@intel.com> <20200416191944.23284-1-jia.guo@intel.com> <20200416191944.23284-4-jia.guo@intel.com> In-Reply-To: <20200416191944.23284-4-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.149.253.12] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e59c74c6-4ad4-47da-f209-08d7e1f29c5f x-ms-traffictypediagnostic: AM6PR05MB4325: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:53; x-forefront-prvs: 0375972289 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(396003)(346002)(376002)(366004)(39860400002)(9686003)(52536014)(66556008)(4326008)(86362001)(26005)(186003)(54906003)(7696005)(33656002)(316002)(76116006)(66446008)(110136005)(55016002)(6506007)(81156014)(66476007)(8676002)(53546011)(5660300002)(71200400001)(66946007)(2906002)(478600001)(8936002)(64756008); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T7o0wPpNz77DZg8iHIIb6idan2knXIK7pNM9lC8/xCirT4AuBHeWloUw6Y5rRB4d4AdJ35QwJUO/p0MQ8ZVlWo8BTTkFHNBae6sZvBoDvE2Qul7CdCjjt0QmRpsPNpYh0kKqbgBdCQimOvcrIfGk+yOMZMvfBZY1F0ahdZFkgnptXkCpg8ahbwvkopl9w4t93FGhBFSXxYmzftKh1TK0mUKoD/YnHzLmd68seGQr+9TDYpF7XFXAxo3udhHFOcglaqbXsr3Ry4vOzOUuxu1riUYF2CgexyRoB1XMynC4zOctBv6MiSUP7pw974fhzXR9dEorJlZhGcfPgDGpg/esFq25TWAoqHJ+48r4Yn/rWJtAmTi58xxdxpLyRxNEigflfQbcZmdZaFhzR8kJ2u79UABnR5u37OEoRfAXWvdcbnBl08xLbvic4w826Zt+SFhM x-ms-exchange-antispam-messagedata: mJRz6KDFLgG/GTVNXXaJw8ZMr/Xqysx3rMaR64f+uIH/Hr8odVcRaJl2J4mcQ1/f7oqpA2JZdsnqvDvZRlD14b9qYsMMtjYgwr96koUkkPT5oSG9rahc0uHogvpzlIbIIEfJdgp6c4UBG8P5cye8ZA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e59c74c6-4ad4-47da-f209-08d7e1f29c5f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2020 10:40:41.7003 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vREvEEPL1yLAJeaQFDy0waE7ijz4Y5fv++7tN+2pIxejYp+vM2wcz1qfCI2OPFeqrrSlr8dSnh2og4EidYaQdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4325 Subject: Re: [dpdk-dev] [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash commands X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jeff, > -----Original Message----- > From: Jeff Guo > Sent: Thursday, April 16, 2020 10:20 PM > To: bernard.iremonger@intel.com; Ori Kam ; > xiaolong.ye@intel.com; qi.z.zhang@intel.com > Cc: dev@dpdk.org; jingjing.wu@intel.com; yahui.cao@intel.com; > simei.su@intel.com; jia.guo@intel.com > Subject: [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash command= s >=20 > Add some new types, such as eth/l2-src-only/l2-dst-only/svlan/cvlan/ > l2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used > to configure these rss input set by cmdline. >=20 > Example testpmd commands was: > testpmd>flow create 0 ingress pattern eth / ipv4 / l2tpv3oip / end \ > actions rss types l2tpv3 end key_len 0 queues end / end >=20 > Signed-off-by: Jeff Guo > --- > v6->v5: > add some missing part and refine commit log > --- > app/test-pmd/cmdline.c | 34 +++++++++++++++++++++++++++++----- > app/test-pmd/config.c | 15 ++++++++++++--- > 2 files changed, 41 insertions(+), 8 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 863b567c1..4164767b8 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2270,9 +2270,13 @@ cmd_config_rss_parsed(void *parsed_result, > int ret; >=20 > if (!strcmp(res->value, "all")) > - rss_conf.rss_hf =3D ETH_RSS_IP | ETH_RSS_TCP | > - ETH_RSS_UDP | ETH_RSS_SCTP | > - ETH_RSS_L2_PAYLOAD; > + rss_conf.rss_hf =3D ETH_RSS_ETH | ETH_RSS_S_VLAN | > + ETH_RSS_C_VLAN | ETH_RSS_IP | ETH_RSS_TCP | > + ETH_RSS_UDP | ETH_RSS_SCTP | > ETH_RSS_L2_PAYLOAD | > + ETH_RSS_L2TPV3 | ETH_RSS_ESP | ETH_RSS_AH | > + ETH_RSS_PFCP; > + else if (!strcmp(res->value, "eth")) > + rss_conf.rss_hf =3D ETH_RSS_ETH; > else if (!strcmp(res->value, "ip")) > rss_conf.rss_hf =3D ETH_RSS_IP; > else if (!strcmp(res->value, "udp")) > @@ -2299,6 +2303,22 @@ cmd_config_rss_parsed(void *parsed_result, > rss_conf.rss_hf =3D ETH_RSS_L4_SRC_ONLY; > else if (!strcmp(res->value, "l4-dst-only")) > rss_conf.rss_hf =3D ETH_RSS_L4_DST_ONLY; > + else if (!strcmp(res->value, "l2-src-only")) > + rss_conf.rss_hf =3D ETH_RSS_L2_SRC_ONLY; > + else if (!strcmp(res->value, "l2-dst-only")) > + rss_conf.rss_hf =3D ETH_RSS_L2_DST_ONLY; > + else if (!strcmp(res->value, "s-vlan")) > + rss_conf.rss_hf =3D ETH_RSS_S_VLAN; > + else if (!strcmp(res->value, "c-vlan")) > + rss_conf.rss_hf =3D ETH_RSS_C_VLAN; > + else if (!strcmp(res->value, "l2tpv3")) > + rss_conf.rss_hf =3D ETH_RSS_L2TPV3; > + else if (!strcmp(res->value, "esp")) > + rss_conf.rss_hf =3D ETH_RSS_ESP; > + else if (!strcmp(res->value, "ah")) > + rss_conf.rss_hf =3D ETH_RSS_AH; > + else if (!strcmp(res->value, "pfcp")) > + rss_conf.rss_hf =3D ETH_RSS_PFCP; > else if (!strcmp(res->value, "none")) > rss_conf.rss_hf =3D 0; > else if (!strcmp(res->value, "default")) > @@ -2467,7 +2487,9 @@ cmdline_parse_token_string_t > cmd_config_rss_hash_key_rss_type =3D > "ipv4-other#ipv6#ipv6-frag#ipv6-tcp#ipv6- > udp#" > "ipv6-sctp#ipv6-other#l2-payload#ipv6-ex#" > "ipv6-tcp-ex#ipv6-udp-ex#" > - "l3-src-only#l3-dst-only#l4-src-only#l4-dst- > only"); > + "l3-src-only#l3-dst-only#l4-src-only#l4-dst- > only#" > + "l2-src-only#l2-dst-only#s-vlan#c-vlan#" > + "l2tpv3#esp#ah#pfcp"); > cmdline_parse_token_string_t cmd_config_rss_hash_key_value =3D > TOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, > NULL); >=20 > @@ -2478,7 +2500,9 @@ cmdline_parse_inst_t cmd_config_rss_hash_key =3D { > "ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|" > "ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|" > "l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|" > - "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only " > + "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|" > + "l2-src-only|l2-dst-only|s-vlan|c-vlan|" > + "l2tpv3|esp|ah|pfcp " I think you are missing the eth only. Best, Ori > "", > .tokens =3D { > (void *)&cmd_config_rss_hash_key_port, > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 71aeb5413..c8196e47a 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -75,10 +75,15 @@ static const struct { > }; >=20 > const struct rss_type_info rss_type_table[] =3D { > - { "all", ETH_RSS_IP | ETH_RSS_TCP | > - ETH_RSS_UDP | ETH_RSS_SCTP | > - ETH_RSS_L2_PAYLOAD }, > + { "all", ETH_RSS_ETH | ETH_RSS_IP | ETH_RSS_TCP | ETH_RSS_UDP | > + ETH_RSS_SCTP | ETH_RSS_L2_PAYLOAD | ETH_RSS_L2TPV3 | > + ETH_RSS_ESP | ETH_RSS_AH | ETH_RSS_PFCP}, > { "none", 0 }, > + { "eth", ETH_RSS_ETH }, > + { "l2-src-only", ETH_RSS_L2_SRC_ONLY }, > + { "l2-dst-only", ETH_RSS_L2_DST_ONLY }, > + { "s-vlan", ETH_RSS_S_VLAN }, > + { "c-vlan", ETH_RSS_C_VLAN }, > { "ipv4", ETH_RSS_IPV4 }, > { "ipv4-frag", ETH_RSS_FRAG_IPV4 }, > { "ipv4-tcp", ETH_RSS_NONFRAG_IPV4_TCP }, > @@ -108,6 +113,10 @@ const struct rss_type_info rss_type_table[] =3D { > { "l3-dst-only", ETH_RSS_L3_DST_ONLY }, > { "l4-src-only", ETH_RSS_L4_SRC_ONLY }, > { "l4-dst-only", ETH_RSS_L4_DST_ONLY }, > + { "l2tpv3", ETH_RSS_L2TPV3 }, > + { "esp", ETH_RSS_ESP }, > + { "ah", ETH_RSS_AH }, > + { "pfcp", ETH_RSS_PFCP }, > { NULL, 0 }, > }; >=20 > -- > 2.20.1