From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A67C2A00C5; Mon, 6 Jul 2020 21:14:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D6981DC47; Mon, 6 Jul 2020 21:14:48 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80059.outbound.protection.outlook.com [40.107.8.59]) by dpdk.org (Postfix) with ESMTP id B3BB81DC41 for ; Mon, 6 Jul 2020 21:14:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cNhCSJJmA/Z9YlEhkh4HuQ2k49WSRAD88GOXjS6aAyc/ifEROVryD+7Q6IdsJ2sIWcZRF5zswJWXYReKBv4ALOAFqTCBRZ3zHeaUtKRxDl2UdKPi5h2FdSgW5lKY2mUQSRZnsAahUc+BnwW3nempKyIk31fCREbX+0DKNf+UGuwhQ4IobcPqBQfULhI462zy7SZY0Ia1F3Kn1QOEJ7dncpyV6393+VXgOltpmayMe/s3VHMTd319TeyMeVDLj+nTrq4JvD6NkMb7KoV5xTzMuoUDNxT2oHFBteHCiQcfRJ79MJI2GJ1xuH0fp+fXgVCdjxmzV6YTLdDKThqJq+D3XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rZu7+WIqIxOVXo8e1zuOOQP59MDO9QPLA/jCFgDgvRk=; b=Ob9Kad32zCDq+dEDYKZZrbPGC3/tthiAGLkE6WuYFl2FJNFFD3lkW4W45l5roRLC1wZn6oJ5cc2WI6YiO0mlDuDM+mupPb1QT6lJegLTVsjBjH8XLgjO+Wfmjsiu8G9NBQTi+K/4fuD9SqxIo7Ft/SlFMehqgqdcCRpe5fridMwX/+Rji/y3qAZ+BhbHzZQdz1wPJ7dQopdbxihxGWpVLo75q4lr4oTlFpetytA0AnR/g1G4MrwPViIX9MLv9R090MK0ZEjZoWRORF+mErvjWrgKdhRY9WdJpuU6BfhrjAgFrsHCehRqTBi7S3ousbi3IEqvwoigR6YxHML9e360Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rZu7+WIqIxOVXo8e1zuOOQP59MDO9QPLA/jCFgDgvRk=; b=f63oWtQDe+vqUN0IYVt4xi16pLFZ+n+TkVV5W/vtpqSK2p9/e6FV3G9GOVXrv+DeTzL5oHG2PhLynW1AALIbs/PRWLwIiLorPMZ6H89dt4Q4aPUmuXSwwAF3QoDqg5FtTIFxb4ujmwMWs0uMreVhaeDblhj+qt+zwZyRp/fz6Bg= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM7PR05MB6929.eurprd05.prod.outlook.com (2603:10a6:20b:1af::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.28; Mon, 6 Jul 2020 19:14:46 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::9024:accb:4d6b:805f]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::9024:accb:4d6b:805f%3]) with mapi id 15.20.3153.029; Mon, 6 Jul 2020 19:14:46 +0000 From: Ori Kam To: Stephen Hemminger , "Jiawei(Jonny) Wang" CC: Slava Ovsiienko , Matan Azrad , "dev@dpdk.org" , Thomas Monjalon , Raslan Darawsheh , "ian.stokes@intel.com" , "fbl@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v3 0/7] support the flow-based traffic sampling Thread-Index: AQHWU75plfuBNuPDB0CPOfmpK1dynqj63YWAgAALdsA= Date: Mon, 6 Jul 2020 19:14:45 +0000 Message-ID: References: <1593715390-83047-1-git-send-email-jiaweiw@mellanox.com> <1594057868-18724-1-git-send-email-jiaweiw@mellanox.com> <20200706112311.383ba6b2@hermes.lan> In-Reply-To: <20200706112311.383ba6b2@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1eb18a2b-c592-4455-c41b-08d821e0d86e x-ms-traffictypediagnostic: AM7PR05MB6929: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 04569283F9 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NonlwxdmD276MNHuPfjpSYmurSxrLNxUxyiKCtCDqR4ld49gc20cFG6DPYxn/xsHxPQ0kmq1u+GdAjEf3n6E4O3kj+Y3ziIsqWLN4mKBO0/RZw/dT0Na1qwjjsTa52XTOpeOqLzWUfYFTA74TXtv5rlDP1ldBn7gk5OvwOVGtTe/rR1zeVBgjv5gRRQp6EuGUFfeofl+v0IMo2H+5gbdvqIfUemQwrZi40AgQPLaQ7swT+yHxB2CiHWHhz/mR/ySvcWKWAWcfLcmBTBAEMzDKuntXJJGVhtTosvNi7pLoVB49RSmAre9t9cQAHQVxNvdzMIcELpg+Dxp1F2YzS5Qjg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39860400002)(376002)(136003)(346002)(366004)(26005)(8676002)(55016002)(52536014)(76116006)(9686003)(86362001)(33656002)(110136005)(54906003)(71200400001)(478600001)(316002)(8936002)(186003)(2906002)(66556008)(66476007)(66946007)(64756008)(66446008)(6506007)(83380400001)(5660300002)(4326008)(6636002)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: MdghWWwgSEka+kxqFyQUmWX5G7Tj2eNCnz+Apg+VFGM2Aykl4iuofPUodj+/mk95vqgfr/JOtIcTogjfJL5g2UnI1kCAyKxHAPnSQKRmX72GjgoMXnFswI+iXbw+mZOmopX4/Y81B30bpm8rsDM31VwN5WXcvqRy/66/2uJJejiYHvr8yY/HjE+W8QWE1887ZFUz2mdgMu8Qk7jThPawNekP7EqlIixDp6mX7jfeVB3YddXXdB87hGv00Mc1W4epmYVrVtsxgJsJ7Fhd9KjFmHUvEVBb/hHNtiIaePU6HkA6kpq35teldUa88ICCleORWxPTmL6DFR+MuLGFcAZBXSXpuKwn0SM1LQC/ZOgVAVehgJ3Zeg9P4XZlRdBxR8BSvku7ECbn07I9/0HTb9x23GRXI41Np+B7HrTD173APEpLtWTGelbxosId5PjTzY0CptaNPyRdCOVOkxLNs4QhT41/iufuAYVHh7VX1Rw2oFDbliARVCXGUb8HfxgCAkmh Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR05MB5176.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1eb18a2b-c592-4455-c41b-08d821e0d86e X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2020 19:14:45.9544 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JeYqoc/dNl53FcyQZy0IyOZKxHMzIqTOzygnC1fI0DH9Mxj3yOwUThOjaX967BojjepZ/tlg/KwKJrzja/nu5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR05MB6929 Subject: Re: [dpdk-dev] [PATCH v3 0/7] support the flow-based traffic sampling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v3 0/7] support the flow-based traffic sam= pling >=20 > On Mon, 6 Jul 2020 20:51:01 +0300 > Jiawei Wang wrote: >=20 > > This patch set implement the flow sampling for mlx5 driver. > > > > The solution is introduced a new rte_flow action that will sample the > incoming traffic and send a duplicated traffic with the specified ratio t= o the > application, while the original packet will continue to the target destin= ation. > > > > If the sample ratio value be set to 1, means that the packets would be > completely mirrored. The sample packet can be assigned with different set= of > actions from the original packet. > > > > MLX5 PMD driver will be responsible for validate and translate the samp= le > action while creating a flow. > > >=20 > You seem to have ignored my feedback that this could be more useful if it > didn't just support duplication. It should allow sampling and then make > the other rule chain (the one that gets hit after sampling) run. >=20 > By allowing a more general form of sampling it could be used for doing > network emulation (or packet manipulation) as well as simple netflow/ipfi= x > style sampling. >=20 What is network emulation? I think that what you are suggesting is a different feature. There is high = penalty for=20 rules duplication, like I stated in my previous reply. As I can see there is no plan at least in Mellanox to support this kind of = feature you are suggesting, Since this API in any case is experimental. I suggest that = when the need comes or some other vendor will wish to implement such a feature we can ether update the API or create a new one. What do you think? Best, Ori=20