DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ori Kam <orika@mellanox.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Wang Xiang <xiang.w.wang@intel.com>,
	Guy Kaneti <guyk@marvell.com>, dpdk-dev <dev@dpdk.org>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Opher Reviv <opher@mellanox.com>,
	Alex Rosenbaum <alexr@mellanox.com>,
	Dovrat Zifroni <dovrat@marvell.com>,
	Prasun Kapoor <pkapoor@marvell.com>,
	Nipun Gupta <nipun.gupta@nxp.com>,
	"Richardson,  Bruce" <bruce.richardson@intel.com>,
	"yang.a.hong@intel.com" <yang.a.hong@intel.com>,
	"harry.chang@intel.com" <harry.chang@intel.com>,
	"gu.jian1@zte.com.cn" <gu.jian1@zte.com.cn>,
	"shanjiangh@chinatelecom.cn" <shanjiangh@chinatelecom.cn>,
	"zhangy.yun@chinatelecom.cn" <zhangy.yun@chinatelecom.cn>,
	"lixingfu@huachentel.com" <lixingfu@huachentel.com>,
	"wushuai@inspur.com" <wushuai@inspur.com>,
	"yuyingxia@yxlink.com" <yuyingxia@yxlink.com>,
	"fanchenggang@sunyainfo.com" <fanchenggang@sunyainfo.com>,
	"davidfgao@tencent.com" <davidfgao@tencent.com>,
	"liuzhong1@chinaunicom.cn" <liuzhong1@chinaunicom.cn>,
	"zhaoyong11@huawei.com" <zhaoyong11@huawei.com>,
	"oc@yunify.com" <oc@yunify.com>, Jim Thompson <jim@netgate.com>,
	"hongjun.ni@intel.com" <hongjun.ni@intel.com>,
	"j.bromhead@titan-ic.com" <j.bromhead@titan-ic.com>,
	"deri@ntop.org" <deri@ntop.org>,
	"fc@napatech.com" <fc@napatech.com>,
	"arthur.su@lionic.com" <arthur.su@lionic.com>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [RFC] app/test-regex: add RegEx test application.
Date: Thu, 4 Jun 2020 05:51:40 +0000	[thread overview]
Message-ID: <AM6PR05MB51769D7B5853F40B8C3F70B7DB890@AM6PR05MB5176.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1OyKaptSt5AUaVtERDVcTJWOX=os=UFj=5F9E1VPKCWDw@mail.gmail.com>

Hi Jerin,

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Thursday, June 4, 2020 7:56 AM
> Subject: Re: [dpdk-dev] [RFC] app/test-regex: add RegEx test application.
> 
> On Thu, Jun 4, 2020 at 2:59 AM Ori Kam <orika@mellanox.com> wrote:
> >
> > Following the new RegEx class [1].
> > There is a need to create a dedecated test application in order to
> > validate this class and PMD.
> >
> > Unlike net device this application loads data from a file.
> >
> > This commit introduce the new RegEx test app.
> >
> > The basic app flow:
> > 1. query probed RegEx device.
> > 2. configure the probed device accoding to the device caps.
> > 3. read a rule database file.
> > 4. read a data file to be searched.
> > 5. allocate one mbuf.
> > 6. select the request job len, based on the number of jobs requsted.
> > 7. create one RegEx op which uses the mbuf defined in step 5.
> > 8. attach the data buffer at offset 0 with len accoding to request
> >    len to the mbuf as external buffer.
> > 9. enqueue one job.
> > 10. wait for completion of the job.
> > 11. check job results and print them.
> > 12. move the mbuf to point to the next part of the buffer.
> > 13. while there are more parts jump to 9.
> >
> > Future improvments to this application may include:
> > 1. submiting more then one job at a time.
> > 2. working with more then one queue.
> > 3. support out of order.
> > 4. allow runtime rule updating.
> >
> > This commit is only at RFC level, which means that
> > the code is only basic reference and can't be compiled and doesn't
> > include error or edge case handling.
> >
> >
> [1]https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatche
> s.dpdk.org%2Fcover%2F69919%2F&amp;data=02%7C01%7Corika%40mellanox.
> com%7C777869b8df174845154008d80843aa33%7Ca652971c7d2e4d9ba6a4d1
> 49256f461b%7C0%7C0%7C637268433993878386&amp;sdata=GzSEh6O0rqPHBl
> OtkTGx3j6VGOdVykga2zYsuyK%2BxtM%3D&amp;reserved=0
> >
> > Signed-off-by: Ori Kam <orika@mellanox.com>
> 
> IMO, this kind simile application with fixed-function can go in the
> example folder.
> I think, for app/test-regex, it better to have a framework to add new
> tests, modes, parse the modes, etc.
> Please see git log app/test-eventdev/ initial check-ins for the
> skeleton as a reference

Currently all dedicateded tests for example, the crypto are located in this folder.
As I see it the example folder is used for simple programs to be used as a reference, while this app should be used to test the
RegEx class, I assume it will get much more functionality to support all test modes.

Best,
Ori



  reply	other threads:[~2020-06-04  5:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 21:29 Ori Kam
2020-06-04  4:56 ` Jerin Jacob
2020-06-04  5:51   ` Ori Kam [this message]
2020-06-04  6:30     ` Jerin Jacob
2020-06-04 11:31       ` Ori Kam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR05MB51769D7B5853F40B8C3F70B7DB890@AM6PR05MB5176.eurprd05.prod.outlook.com \
    --to=orika@mellanox.com \
    --cc=alexr@mellanox.com \
    --cc=arthur.su@lionic.com \
    --cc=bruce.richardson@intel.com \
    --cc=davidfgao@tencent.com \
    --cc=deri@ntop.org \
    --cc=dev@dpdk.org \
    --cc=dovrat@marvell.com \
    --cc=fanchenggang@sunyainfo.com \
    --cc=fc@napatech.com \
    --cc=gu.jian1@zte.com.cn \
    --cc=guyk@marvell.com \
    --cc=harry.chang@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hongjun.ni@intel.com \
    --cc=j.bromhead@titan-ic.com \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=jim@netgate.com \
    --cc=liuzhong1@chinaunicom.cn \
    --cc=lixingfu@huachentel.com \
    --cc=nipun.gupta@nxp.com \
    --cc=oc@yunify.com \
    --cc=opher@mellanox.com \
    --cc=pbhagavatula@marvell.com \
    --cc=pkapoor@marvell.com \
    --cc=shahafs@mellanox.com \
    --cc=shanjiangh@chinatelecom.cn \
    --cc=thomas@monjalon.net \
    --cc=wushuai@inspur.com \
    --cc=xiang.w.wang@intel.com \
    --cc=yang.a.hong@intel.com \
    --cc=yuyingxia@yxlink.com \
    --cc=zhangy.yun@chinatelecom.cn \
    --cc=zhaoyong11@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).