From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02637A0562; Sun, 29 Mar 2020 10:44:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC83DF3E; Sun, 29 Mar 2020 10:44:18 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50082.outbound.protection.outlook.com [40.107.5.82]) by dpdk.org (Postfix) with ESMTP id C7C4B2AB for ; Sun, 29 Mar 2020 10:44:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m+Fgy2Gax8sSg1TkYl/kKndwllpbgvpReiNECd7TuTNo96g1gUyHNhIVonpKWzaWhIqhwifYfAJ80eSMTc+KDqooOxdoqdxesiSzVvhuyxMGBkyu3kG0rQwMylEBS1N36c0/tCDpLm12lJA1ytyhC4yQbhzeXtKTjSLpB+dseFQyMOEMDsymNj5JOOOsRl6STa6ceSKZhJSotEdFYqKxGfPqtavDE9RUTBrPwmHnnMJyJyuQNiCqWFT/Iz2hB6tT2Ex4ywAa9xYjYNBeS88B/zJ+vpZXOlxvcUuiIX6tpG/+Sm/4l/sCAi8YURJ3m0dmZOZ9etwbBDCbMS3+vv9F3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sxcFBmKrLbm0Tx2wr/ZqMYnOULwFXmyG6lE8FE5520Q=; b=jQceIa+QqI5TX+4kOe70dNCpNxIA/cBG4nWKyv1bWpHcdpTboPHoKLQXEEOmQuQVZVXAdZVmYWkvOxZDOItfNqUA3k5iQCQ0g+xGbipSwNgqhLEOcWZG9s9Gd6MCs5OXevkFuxmpVeqkRA4SWS9uFIWf21048XsnDE2zOjNFqGVCqLv7mZc1ddnBLGCkQibxzcPeUmwTe34TtfGHYv0UYsPQWMwUQLsUN2mGjD+QNKzYFYZ0BfOzFRzWW8fesy3lWpPFwEIyyXQIG+1pJL40qxW2l2zVcR/M4P2APZdaGd5qxNcK6RnfL+DUE/96VNKzof9vWItdfWzsEz2wBddyIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sxcFBmKrLbm0Tx2wr/ZqMYnOULwFXmyG6lE8FE5520Q=; b=ZdsbYmgSO3QQVYMGbZ6DyksraUDworsYKQlAMC9LvAGo6aSpzpYQeP0RQnHj7k0+PQCubVw+WGQlUqabPNfmjwD8xvMQpoHMp6ACk57IBILYC/hGHkVUsX0mv4fpMTp6UYPMaKFZ0CdXQijWbxRTvbGzLklIq0HXcZEI1uAYDIQ= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (20.177.196.158) by AM6PR05MB5653.eurprd05.prod.outlook.com (20.178.86.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 08:44:15 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22%7]) with mapi id 15.20.2856.019; Sun, 29 Mar 2020 08:44:15 +0000 From: Ori Kam To: Jeff Guo , "xiaolong.ye@intel.com" , "qi.z.zhang@intel.com" CC: "dev@dpdk.org" , "jingjing.wu@intel.com" , "yahui.cao@intel.com" , "simei.su@intel.com" Thread-Topic: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type Thread-Index: AQHWA0KHh4rpDo8GUkahaSm3UQmOlahfQubA Date: Sun, 29 Mar 2020 08:44:14 +0000 Message-ID: References: <20200318170401.7938-5-jia.guo@intel.com> <20200326164039.36687-1-jia.guo@intel.com> <20200326164039.36687-4-jia.guo@intel.com> In-Reply-To: <20200326164039.36687-4-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2d110785-080e-4dc1-eecf-08d7d3bd5cf3 x-ms-traffictypediagnostic: AM6PR05MB5653: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 035748864E x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(39860400002)(346002)(376002)(136003)(396003)(366004)(52536014)(81156014)(66946007)(66476007)(66556008)(8676002)(71200400001)(64756008)(66446008)(76116006)(81166006)(9686003)(55016002)(186003)(86362001)(8936002)(4326008)(54906003)(110136005)(6506007)(53546011)(33656002)(316002)(478600001)(2906002)(26005)(5660300002)(7696005); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9DfgjRDcH5XZ/Wf79eGFoQ3dsUQPeb254CXuv3aonQCeCYTmv6FxtSarsAvhIrsZUt/XVF4NIHVldjIevAN4jSvKe+OiUE/7PLXMFqaJ9bySdT6NKi16Uo73LDF0K6EOhAngHJYVNT8c5FAow6DsuRusk966YtNJYTwomYA6UkeCGpO5n21u+WucJAqW7o9fOz4vSgyjzJo2VsLvM+ei7i+/vKjYgLahARgPAaguHysvRTtheN8cHRLpCwfd0aGiPitJ0DT89Xtdga/A9laq4vacXALG/kJYv7joxg3pbEfFnJhHmIKwu/UbueGGhG5LJUZBp644T7D/C9FirrnKAGYzpCBr6yW0tK277C+jYC7A/CJnTRO7ZHYy/oZrCq8e8w7ynqNuIv56AYRUEciTiai/DJuoqUusQBmRisOiS+7tx2IMwxtO116UnXdaxKNW x-ms-exchange-antispam-messagedata: VSsV5kx5x+jQqiJ7/wWfdcCkMIHklWi4BUgT6COrPaScaWZfUXyUlE1kh6rIr4JTqmPhWY5P2kT3js3oyLgcc9LSsZJgsPfiHwmdvAPOECDzgVfXJRRTiZInDA5vELJPpyXMSJmMqPNfnsxmdA04ug== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d110785-080e-4dc1-eecf-08d7d3bd5cf3 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2020 08:44:14.7600 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8IWKLFGU3SsNiLh0/MtYRReZ8wkU+LUoCvVW9Z9S5rWYqNpZs6mJFv399Ubfs62Cb/2XV7m9cwNnihJ0Hs0CGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5653 Subject: Re: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jeff, > -----Original Message----- > From: dev On Behalf Of Jeff Guo > Sent: Thursday, March 26, 2020 6:41 PM > To: xiaolong.ye@intel.com; qi.z.zhang@intel.com > Cc: dev@dpdk.org; jingjing.wu@intel.com; yahui.cao@intel.com; > simei.su@intel.com; jia.guo@intel.com > Subject: [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type >=20 > Add gtp pdu type configure in the cmdline. Why not use ITEM_GTP_PSC_PDU? >=20 > Signed-off-by: Jeff Guo > --- > v1: > no change > --- > app/test-pmd/cmdline_flow.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index a78154502..c1bd02919 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -49,6 +49,7 @@ enum index { > PORT_ID, > GROUP_ID, > PRIORITY_LEVEL, > + GTP_PSC_PDU_T, >=20 > /* Top-level command. */ > SET, > @@ -1626,6 +1627,13 @@ static const struct token token_list[] =3D { > .call =3D parse_int, > .comp =3D comp_none, > }, > + [GTP_PSC_PDU_T] =3D { > + .name =3D "{GTPU pdu type}", > + .type =3D "INTEGER", > + .help =3D "gtpu pdu uplink/downlink identifier", > + .call =3D parse_int, > + .comp =3D comp_none, > + }, Why is this created at this level? This looks like is should be written totally differently. > /* Top-level command. */ > [FLOW] =3D { > .name =3D "flow", > @@ -2615,7 +2623,8 @@ static const struct token token_list[] =3D { > [ITEM_GTP_PSC_PDU_T] =3D { > .name =3D "pdu_t", > .help =3D "PDU type", > - .next =3D NEXT(item_gtp_psc, NEXT_ENTRY(UNSIGNED), > item_param), > + .next =3D NEXT(item_gtp_psc, NEXT_ENTRY(GTP_PSC_PDU_T), > + item_param), > .args =3D ARGS(ARGS_ENTRY_HTON(struct > rte_flow_item_gtp_psc, > pdu_type)), > }, > -- > 2.20.1