From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 573B1A00BE; Mon, 27 Apr 2020 08:52:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F04A41BF9C; Mon, 27 Apr 2020 08:52:26 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20049.outbound.protection.outlook.com [40.107.2.49]) by dpdk.org (Postfix) with ESMTP id A9A6E1BF26 for ; Mon, 27 Apr 2020 08:52:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dNP/tJC2cvgw2CpkSCavyNbEdXQZ2FqeJ4CFtWbOBUSQIsnR5dzxbain4KJ3gA9dNX7eaa0YA5NTSyTQFmIgLRDDkYKDaKu+2XwUcTrf8gkwuUtmTc+jzyy+FY/vYHzWN0pKwPkeAiakg+imAtebC5d7Qof5DN7nf9JMgJHNlVAr540dGRu1MpPGGYVYnJibPk46tJU29cYLnhVybxRinndWmePnJgrqywkUsdgbX+d8wtFaEixco2+9UnVhjVODRWqWd4szg2uBB8iqLncNQxieIwI/G6DaUiavBtAv34hnaCHbCcLa6BR2aa1miirkAxHz1WR6ppu/i6UsvY2UnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EXf+3atwQ1xMvkz1e9Fp89nGwYMTyUwkF8Dml5F/Fgc=; b=UFuPmwSY+OqaMZh8E3qVqlJBj+5GHbjGeUlZVplpxjRo09q3TM2BKFiIDF9iwV1ivZKVU+mk9ln/0teYsMdZPQP3tPGyXVXSj4+vo52lKhas0TOEGLhv4ZPyXdJo5UdGSUBt4KjurdvgWDbF7p6+khkYB6+0Q50YVByKvLTPzTAwThc9JkErANatVkA9oddcFI3CLPmiOVbTLZynXWZpffCG9tXA1K+yXCjfKMN9UHrWsWPwqR0WwS6WSZyrXMCn6dQ906nthjqBtAEmFmqA0/Y6KzXzX5riNXG5DcVE3AacP07cElhkH8wsRssTzVHAqE60iXG45QI2SAfxxtcpow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EXf+3atwQ1xMvkz1e9Fp89nGwYMTyUwkF8Dml5F/Fgc=; b=jWec1justI+nulIXdJuIR0qdeHwvS1gOWG6xgbsH2AXqFfj8uEZm5e3QVTXJP0H3G3izElsy+0Ii7jBH6YyxAGOd5gQgUvjw2HXu9xfNL0WhC6Dwh3NDgL7UCg5XZyPIDsjTJdRrTHiEN87c8YAwjg06N/BC00qJn2f9b+1LqRQ= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM6PR05MB4183.eurprd05.prod.outlook.com (2603:10a6:209:40::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Mon, 27 Apr 2020 06:52:24 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22%7]) with mapi id 15.20.2937.020; Mon, 27 Apr 2020 06:52:24 +0000 From: Ori Kam To: Stephen Hemminger , Dekel Peled CC: Andrew Rybchenko , "john.mcnamara@intel.com" , "marko.kovacevic@intel.com" , Thomas Monjalon , "ferruh.yigit@intel.com" , "dev@dpdk.org" , Asaf Penso Thread-Topic: [dpdk-dev] [PATCH] doc: refine ethernet and VLAN flow rule items Thread-Index: AQHWGwnnKoXxGxf16UOPRjiMI2ravqiLIVUAgACBeQCAAOEYYA== Date: Mon, 27 Apr 2020 06:52:24 +0000 Message-ID: References: <7b474ff0-7e9c-aa01-637b-61cc61d34aa4@solarflare.com> <20200426100218.35d50cfb@hermes.lan> In-Reply-To: <20200426100218.35d50cfb@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [89.208.130.33] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d0ebe7fe-4bbc-4c90-d3f1-08d7ea778aef x-ms-traffictypediagnostic: AM6PR05MB4183:|AM6PR05MB4183: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0386B406AA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(107886003)(71200400001)(55016002)(66476007)(5660300002)(66556008)(9686003)(478600001)(66946007)(54906003)(7696005)(66446008)(76116006)(110136005)(64756008)(2906002)(86362001)(8936002)(316002)(81156014)(33656002)(8676002)(6506007)(26005)(186003)(6636002)(52536014)(4326008)(53546011); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cqkm7HBvPSNPXxRudtq9sCE1jcRamj2pr+jSwrWu0dQ3JcEgns64INxh4cjvxUxbDFddhO5Y/qhzRc74Ab+TwB6nwEV5aFpl6rOVHrCSXATtlA6T2uSGY/dIIJ9aVtVRg4TN1MzKLtDBjESjSCWnSjt+k2r53TtYshho7DaGlqjcexNvEZgD1ysakgPXOquuGwnC42mA5HrPYs6KKkWQJjoOgAOwzd1OgCECGsAOze2JC1jK2kNnE2CE82CqmgwtXH7xzYOSyNcCbL9608nBlyDnI2C0ONs5sVAkzsOX5l7bVoAecb38xgZ6L6K4pqGXL/pEoOaR7ZLq275ESULzlxQNpNuORq3v4PABc2Umw4+2d8or1L6dDmKNLh14uMsuHD1BABJqO6VmlH0VVGXwp8jJeYCH+6vOP8IAV7oA8SsgArBpWJBurGF//1dkHUqH x-ms-exchange-antispam-messagedata: UYPX4w0foAqwGfBT0+bNlEGQ5qBh1guRgKkOH5LlhMGe9blKbMzVtUbxSEW0xuuvfjy/Mau0dY6yBz0omcZwj0UKOvB2MXM29rjy7+56ABhrayDDFqoWFEMHjatb/U3bsExhoYbUNSkFoedZJDokw3NkWWBR3uLIub2HoglxwnOBfbr6ZFM0HngFKmjcsNqeoIPsODqoL0QUqLABY6b8Ozxxq5T6efthUn/sd7HAGAlV2QEHCKzCif1Rdy3VPCpmc5B6gjlzYNoyugSXQotOeoXIW75pyLjzN8LS5yqEg8vZmdPv6kwvEd+eKIfV/NTJaNnEkkI1tnt3hMeENCDQgeG41LTqrXaZB/yL9Ow3HmkNgxgtbVNMEqdJ8aKJRkfY+tiHUU3Fkp++XVdGu0vc4jQOxcynQJyTmwLDSFvY9uKceJNbAugLZtGqUQEE4Elzi9epiZCKw+WjUL7wpfVCDIPTDzCU/nno7FFLjXdXlH6UnG2t6QeFZXjChjMVcF8W021I1ocK37A8wsOZUM6zovgitHxincTr1N5jgtzKEZI8TB463SM9j2pT2+/75W1RjCd2Fr6pbquxCX8OsYjvNxqNc3aXWGyBvkt/ezRiCE6SQxS055mpFh3Ql7/K/TcRQr6DDC2HjI3KtTd/uvqJDbAG8660OmryIL4qJTQN6LLRkPiTiMM3WRfb79+mdNuHOLzqxlHLZo/Y3F5YJFNiCOwAQrnzFZdpw6KP3vLMTU10Gbm2ziZSAbpjrafXEq3VS1QWi38AIo3V/6kcLwRp0nGippB85ZCz7YGIr9xg5Bw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0ebe7fe-4bbc-4c90-d3f1-08d7ea778aef X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 06:52:24.8156 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QFVGAFYGbS9zDoWHAplZY6mnhtTH7oBgLMzoxCyMLCLhmQKozzgYsTzEOg+u7rp2NeHFABpyYCT/kzsL21hdcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4183 Subject: Re: [dpdk-dev] [PATCH] doc: refine ethernet and VLAN flow rule items X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Sent: Sunday, April 26, 2020 8:02 PM > To: Dekel Peled > Cc: Andrew Rybchenko ; Ori Kam > ; john.mcnamara@intel.com; > marko.kovacevic@intel.com; Thomas Monjalon ; > ferruh.yigit@intel.com; dev@dpdk.org; Asaf Penso > Subject: Re: [dpdk-dev] [PATCH] doc: refine ethernet and VLAN flow rule i= tems >=20 > On Sun, 26 Apr 2020 09:18:54 +0000 > Dekel Peled wrote: >=20 > > Thanks, PSB. > > > > > -----Original Message----- > > > From: Andrew Rybchenko > > > Sent: Saturday, April 25, 2020 5:00 PM > > > To: Dekel Peled ; Ori Kam ; > > > john.mcnamara@intel.com; marko.kovacevic@intel.com; Thomas Monjalon > > > ; ferruh.yigit@intel.com > > > Cc: dev@dpdk.org; Asaf Penso > > > Subject: Re: [PATCH] doc: refine ethernet and VLAN flow rule items > > > > > > On 4/23/20 9:30 PM, Dekel Peled wrote: > > > > Specified pattern may be translated in different manner. > > > > For example the pattern "eth / ipv4" can be translated to match > > > > untagged packets only, since the pattern doesn't specify a vlan ite= m. > > > > > > vlan -> VLAN > > > > I will change to uppercase. > > > > > > > > > It can also be translated to match both tagged and untagged packets= , > > > > for the same reason. > > > > This patch updates the rte_flow documentation to clearly specify th= e > > > > required pattern to use. > > > > For example: > > > > To match tagged ipv4 packets, the pattern "eth type is 0x8100 / vla= n / > > > > ipv4 / end" should be used. > > > > > > Isn't eth / vlan / ipv4 /end sufficient? What's the difference? > > > I guess later should allow any VLAN TPID, but it is greyish since it = is HW > > > dependent. > > > > In the example I wanted to show explicit rule, to emphasize the importa= nce of > detailed pattern structure. > > > > > > > > > To match untagged ipv4 packets, the pattern "eth type is 0x0800 / > > > > ipv4 / end" should be used. > > > > > > What about eth / ipv4 / end? > > > Does usage of ipv4 assume that EtherType is 0x0800? > > > > Same as above. > > > > > > > > > To match both tagged and untagged packets, the pattern "eth / end" > > > > should be used. > > > > > > The interesting question is what should be used if I want either tagg= ed or > > > untagged IPv4 packets. I think it worse to mention to make the pictur= e > > > complete. > > > > To match any IPV4 packet, either tagged or untagged, need to apply two > rules. > > One for tagged packets and the other for untagged packets. > > I will add this example as well. > > > > > > > > > Signed-off-by: Dekel Peled >=20 > All this reminds me that "code is the best documentation" and there > is no working code that does a complete software implementation of the > rte_flow engine. This means the actual interpretation of what the rte_flo= w > means is left to documentation and hardware vendors choices in > implementation. I agree with you, that is why I think this patch is important.=20 Best, Ori