From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 745CEA0597; Wed, 8 Apr 2020 10:39:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BE661C0B5; Wed, 8 Apr 2020 10:39:49 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by dpdk.org (Postfix) with ESMTP id 0DE8B1C025 for ; Wed, 8 Apr 2020 10:39:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yr8ofs06eXbEUnUcuzo0ErdnJRBQ2k9zJIzXCdkW+ElCmTpVftj97Oi4+99dZkswEY2Zub+3pEPydWpsR5OsS3nQVW+simyrUSc4wfPgSiJyhYNP8qJalbglY5AyvZSrHyVhwXpQ606+zZ5h6IwjbAikVQdd9Pxx6ercgsaN1I3zaVWmaouFwlC35cY2qGvZZ02ilAZUWFjxFw036rZpgb4D3p7QsqXywluQW4LEgcK7+aZGV8QqUghPLt/EaUWv1c2hiX5c/mcVuTfRH1zatE403Vf/qCyQaUNQMmxvWy05ma2OAnDrc1ed9Ubh8DadXzoAjLjWmcRw1FpaYZbEWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQtXmfRF9cBzKOe0bxv70M/LXVTd6UKJCNrbkjI2HHo=; b=FLuy69iSd+4uX/gX10PVUoszAePtN00tR4gnmp6nIggPzlSOG+zqNp49lS76xOZadZjsFBFrUAaU92EiUYW2FIt7thrg/uN40xqqadj4j+GMgWEmFTMbo2zxYJhbnT9iaDCfMhD6ROlnOjL7kYSJVUn9Km6AXJPvDTv1+FTUh+fEMCCfKvAm2uSI3USLpnupiAOeawI+ITT87RLAPIMUtc41d5V/QbP0E/zh3YjIkV+wpVdZXhE/8b9LnxSfNo/gL03nOxnxctTYNpB4r5U6rzChQXy17ozopZXLLTCH+LPG0b+C4UYD/9e4JO/aKXQPWZZRCnrykZ6B2KgvSpNWDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQtXmfRF9cBzKOe0bxv70M/LXVTd6UKJCNrbkjI2HHo=; b=n4uYXmCbG+9qUe/80RZ72CRfOmzlXimFgAD7uv/3FvLuGy2xTfCMm/Bhyx1XH83JBFJR7LMR8rcZKhFa2RWSALUkf6P5mcKevWMD89Gzor6wUfr7w32EMuBrP58Gkq5RAo6T5+Lw+6ujllJSKw3vjFHorNJefea3soeYxgYYrO8= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM6PR05MB6422.eurprd05.prod.outlook.com (2603:10a6:20b:70::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.16; Wed, 8 Apr 2020 08:39:45 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::f5cd:b10f:5f1b:4b22%7]) with mapi id 15.20.2878.018; Wed, 8 Apr 2020 08:39:45 +0000 From: Ori Kam To: Thomas Monjalon , Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , Pavan Nikhilesh Bhagavatula CC: "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Parav Pandit Thread-Topic: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions Thread-Index: AQHWDBd98r3jIuWPZkeuv5bgYt39GKhu6ZaA Date: Wed, 8 Apr 2020 08:39:45 +0000 Message-ID: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <2061995.157zFVKu8G@xps> In-Reply-To: <2061995.157zFVKu8G@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.149.253.12] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 01c92d99-1061-40ae-1aae-08d7db9863ec x-ms-traffictypediagnostic: AM6PR05MB6422:|AM6PR05MB6422: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0367A50BB1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(136003)(396003)(376002)(39860400002)(346002)(53546011)(66946007)(6506007)(33656002)(26005)(81156014)(66556008)(66476007)(81166007)(52536014)(8936002)(186003)(66446008)(76116006)(55016002)(478600001)(7696005)(7416002)(5660300002)(316002)(64756008)(4326008)(2906002)(110136005)(107886003)(9686003)(86362001)(54906003)(71200400001); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YoHWT2k+ANwMowIdn/w8ZT2oSpKr7cv5dDT+bAb+gTl3RKOOX2bu6p7lWLMOhQiu5C7F3dvNpnpWjKbgsH5dX5btE06Q9wkO0RP2GqObvhICX52vkiPDEmlJjG1cd5zrZ13cPbad+qhWxvUHsdr7aRYePQR89VmuEcCme/XJpuvv6NPxN9pEq8wBY65iHFxOubIZHGWWbHyULuu+q7EBiAl4FZX/weyZB4twFyXAUPE7CXHem6Flu/suPO3YKqsE2br1sZkxI758t40FRiSMVzQDl0eKlyEBnBFLj3Wqn2qK5wzijfGoCRcITrx0jPjyjG3GaIIyFldcK+f8A3eRkFLI+VfxZ0jjo7ln59/YStSa3IQxDUWptxgBO0dZdqut7KPGVX3y9fsOPynS0SSvbw0RkcK+3e8kA+jFHNcLbK9p2peuzKs3Z9SUWc1XH5z0 x-ms-exchange-antispam-messagedata: OCzgtn4UybVhbw6I1VtuBrH9vXfpldQsKEW7UrCgECKCFCkOrd9DYLCGMsHzTjH030aAKyHA6n0tU67YMN/6nuHtamjM+hEmyuha79QAUn/ezgvKOOvidRv2qdS4xjZH+/cbA0YNIEkd4fwDbmkmWw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01c92d99-1061-40ae-1aae-08d7db9863ec X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2020 08:39:45.2125 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0Vv5RxpDALbsPKXt2R+dPP88qnTDH9YIcgqj5340qGtE6f6fvZGeYgUvQMuW3lw3ZXNX+6hGRlDQgho55oUw9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6422 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Thomas Monjalon > Sent: Monday, April 6, 2020 4:30 PM > To: Ori Kam ; Jerin Jacob Kollanukkaran > ; xiang.w.wang@intel.com; Pavan Nikhilesh Bhagavatula > > Cc: dev@dpdk.org; Shahaf Shuler ; > hemant.agrawal@nxp.com; Opher Reviv ; Alex > Rosenbaum ; Dovrat Zifroni ; > Prasun Kapoor ; nipun.gupta@nxp.com; > bruce.richardson@intel.com; yang.a.hong@intel.com; harry.chang@intel.com; > gu.jian1@zte.com.cn; shanjiangh@chinatelecom.cn; > zhangy.yun@chinatelecom.cn; lixingfu@huachentel.com; wushuai@inspur.com; > yuyingxia@yxlink.com; fanchenggang@sunyainfo.com; > davidfgao@tencent.com; liuzhong1@chinaunicom.cn; > zhaoyong11@huawei.com; oc@yunify.com; jim@netgate.com; > hongjun.ni@intel.com; j.bromhead@titan-ic.com; deri@ntop.org; > fc@napatech.com; arthur.su@lionic.com; Parav Pandit > Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core > functions >=20 > 06/04/2020 14:48, Pavan Nikhilesh Bhagavatula: > > > From: Pavan Nikhilesh Bhagavatula > > >> >> From: Pavan Nikhilesh Bhagavatula > > >> >> > > >> >> Looks like this implementation is incomplete? > > >> >> I don't see any pmd specific helper functions for @see > > >> >rte_cryptodev_pmd.c, > > >> >> rte_eventdev_pmd* > > >> >> > > >> >I think the current implementation includes all needed functions, > > >> >at least for the first stage. > > >> >You can find in rte_regexdev_driver.h the functions that should be > > >> >called > > >> >by the PMD. We have the register / unregister which acts the same > > >as > > >> >create > > >> >and destroy. For parsing argument the PMD may call > > >rte_kvargs_parse. > > >> > > > >> > > >> _driver.h should atleast include > > >> rte_regex_dev_pci_generic_probe/rte_regex_pmd_vdev_init > > >> else there would be a lot of code repetition and possibly udefined > > >behavior > > >> at the driver layer. > > >> > > >Why should they be included? At least in this stage, there is no code = to > > >share > > >ethdev why should we add code for the vdev? > > > > Ok I think I failed to communicate my concerns across. > > Let me retry > > > > 1. SW based regex devices such as PCRE/Hyperscan rely on vdev framework > > i.e. user needs to pass an EAL argument --vdev=3D"regex_pcre" for the d= river to > > initialize all the other EAL subsystems (ethdev, eventdev, cryptodev, > etc..)support this. >=20 > vdev helpers do not have to be part of the first patches which define API= . > It should be added when adding the first vdev driver. >=20 > > 2. HW based independent regex devices that are exposed as PCI devices > would need > > pci probe helpers. >=20 > Same, PCI helpers can be added while adding the first PCI driver. >=20 > We can synchronize about how to split the work, avoiding two developers > doing the same thing. But let's not mandate this work to be done > as part of this first series. >=20 >=20 I agree with Thomas, let's discuss this when adding the PMDs.