From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D7B2A053A; Wed, 5 Aug 2020 14:39:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E0422BF2; Wed, 5 Aug 2020 14:39:50 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140078.outbound.protection.outlook.com [40.107.14.78]) by dpdk.org (Postfix) with ESMTP id B2201E07 for ; Wed, 5 Aug 2020 14:39:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K6ATIGnGVh55hDTxeDAIawcT5PaaBEo3quq8AW+s7QocN+2suSBOMAxtl9leTeHAsjfyZeTKDBfy1E7HzI57cY5pTSvzEyJZ5ammbn3ndF3yD6dV5xM8+8MqbjxQvXisZdf9l1evNR10qVjt3vKNFs585qR1Pk1wOtByAolyAg8LRU8vDKvQOM37JJ9rrBTX8+hXc97jjd658RhYQ6PoAXca+kL5YoD2gzUltbwiIbvxneCEiqsFS26uBbozTHLhbex53H73JDqGjWFy+rt7Tr1uJO4Rw96IBPTQPfLWu1ydaXYvcpPPD79fJkqSGo2ko49eRp2kUCVW25fW/6OKvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ZsJ0j1uhfHwnASzXnQ0vh0+2EBwjFz8lFVROnPVZjI=; b=T+udhg4Q4YvXApC/hzRObHthtqZa1iplATXcsSc0Ciu/wAl1qrktaz+vvfTFGmXIpTnzcDNKSLAg2hJN+3W7zKNlVEx6/a1DisfYHMwb5oDzmkVI6GkUqcQPFQCiQc9IAOc1ywyASKeddGBeWB0OfUfnyjTltwYhsmmXyPNjAeHh11G7BmCyZcmadt7n1oEv98kLqnRAcnRszowquykZL0pnX58EzKP0eWVC9II6R1cvl1GGTQvjOs3vJ+x2ENDwxR4+u+0Zxi+3PVuDzlwKpsH8JBF9HZL1U4d+aifes/Ra/RfnwEFfTy0ZFwiQQarUqp7x8AMLldnJlCiwpTLpxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ZsJ0j1uhfHwnASzXnQ0vh0+2EBwjFz8lFVROnPVZjI=; b=kBDi1kSbZFVy6PYhJQrmQ2JWk/+jdLD+gYN1IwwMqqbejFVwUrnp5FNa8nmmlgio2zP2xEJNQMdUpVJS3NUkQ4D0mJ/wsEyu0Dzrsc2WPrkXALulFjxIJDAoSiD9gy0gCcsUwHZNsZHAjcVXht5qrO/88OrrcZSgBaFmYkasgBs= Received: from AM6PR05MB5176.eurprd05.prod.outlook.com (2603:10a6:20b:63::30) by AM7PR05MB6852.eurprd05.prod.outlook.com (2603:10a6:20b:18e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16; Wed, 5 Aug 2020 12:39:47 +0000 Received: from AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::7092:faf6:f77d:802f]) by AM6PR05MB5176.eurprd05.prod.outlook.com ([fe80::7092:faf6:f77d:802f%7]) with mapi id 15.20.3239.022; Wed, 5 Aug 2020 12:39:47 +0000 From: Ori Kam To: Ori Kam , Thomas Monjalon , "arybchenko@solarflare.com" , "david.marchand@redhat.com" , John McNamara , Marko Kovacevic CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] doc: update RSS action with best effort Thread-Index: AQHWajcvtBH1pTpD70yn+fkBdWWAFqkpdlSA Date: Wed, 5 Aug 2020 12:39:46 +0000 Message-ID: References: <1596464905-43867-1-git-send-email-orika@mellanox.com> <1596528811-138806-1-git-send-email-orika@mellanox.com> In-Reply-To: <1596528811-138806-1-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7068f755-a9f7-4b7e-79eb-08d8393ca31c x-ms-traffictypediagnostic: AM7PR05MB6852: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v78TknhfQikwj9biYEhW9/QKCQbaOmJ7BRHLrX9diUtgZh7wVn6rGFwIq9Jd1OpTnHglPTW/RiDQxaU2WPghw+h7Pg5jvbE1HUS/L2VsI6GGOxQjuzFhuhagFCwcX/jO/dzWp3wnqSJyuDcVuZu3LuDxnKtT/ELXtx/J4wR77ShLkMKQ1W+lKw9ZHUJzb8QQAgfAP+iG9nupZ0WR6shVgvbPRvrLYq31L/r0PT0ZfDhEGhJHsAfG4Qb9AMj8a/NIltMIndMSuKRu0YmLGQQUbJu5i2oO9Jnm7sOLUGFv+9aOQFXg0sTvHq+IC3/yxcQm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB5176.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(8676002)(8936002)(33656002)(4326008)(66946007)(76116006)(71200400001)(66446008)(64756008)(66556008)(66476007)(6506007)(26005)(478600001)(7696005)(83380400001)(186003)(55016002)(9686003)(110136005)(2906002)(5660300002)(316002)(52536014)(15650500001)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: gfnx943ktVkuTXNCpVjN4ApVSxE4UKoq4/sM8SJsxydxdv1idWM0Osha78WC9pnzoQGjcunZRrO8uHa99c/p1LIvHLA/LoZktwl1klX0jKpOGNTufbcP6KfidPUbhlzTVcnNgw/C/xwk5MOo0z7U6pjbQTEepXpZNI3/x/RwS0b3m2e1R8v9RGo/jWumOvQlE8+DjUfhOvmdUIvHmYvPaY6tXPEfEY2YwZ3ihl6ltOc8YQxScu84WvA3RfqYfOV+GGbD/8rUrtYfAujMfcQHVhbTZ5JgzUqXmZg5zOMPpnY8iqV3dSTv9f4l5qouMXu3CW6SIjZjKSHUukKGzyk0LV16KfcDd5yYu17o+GTrPr45KY+XKFvEdWq+tedX6V6e1xsurya0lFycCJSdNtkmlbknUCcqCYoPOkYwgjcm/zVbKcd5W25u0yGCM7S2EbePv42sKpaD76ns/7D+YvN7/qkc8/jQV8/jIBqQTZOY/x7T8CrRYwvbr6wF6Ir0SI7zJVNc0ZhJ6udIYvSeD5Ql04UqUcY3OC6+0OyVpLv/ZliSasISIKyzWZpaFTG21CitdGM87o6W5HQxfQAlD5XtoLHqJm/Q5h9O8lpx6ejtaF3D5IxGgknm96QvDEuY255J30wGS4F1PGJJyeUFe5iXGg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR05MB5176.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7068f755-a9f7-4b7e-79eb-08d8393ca31c X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2020 12:39:46.8889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q7N8YnuzNTzfo2P1ctQxV4a5iYMNfaqT5KU6l5jvQjnwbXvM79vQONAWcEzrqNH3nhss6ZIciLHunFXKc3Wngg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR05MB6852 Subject: Re: [dpdk-dev] [PATCH v2] doc: update RSS action with best effort X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi All, Can you please review and ack it? so it will be merged in 20.08 version. Thanks, Ori > -----Original Message----- > From: Ori Kam >=20 > Using the rte_flow action RSS types field, > may result in undefined outcome. >=20 > For example selecting both UDP and TCP, > selecting TCP RSS type but the pattern is targeting UDP traffic. > another option is that the PMD doesn't support all requested types. >=20 > Until now, it wasn't clear what will happen in such cases. > This commit clarify this issue by stating that the PMD > will work in the best-effort mode. >=20 > Signed-off-by: Ori Kam > --- > v2: > * Based on ML, update that using only unsupported hash type > may cause the flow to be rejected by PMD. > --- > doc/guides/prog_guide/rte_flow.rst | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/rte_flow.rst > b/doc/guides/prog_guide/rte_flow.rst > index 3e5cd1e..d730b66 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -1735,6 +1735,17 @@ unspecified "best-effort" settings from the > underlying PMD, which depending > on the flow rule, may result in anything ranging from empty (single queu= e) > to all-inclusive RSS. >=20 > +Best effort will be used, in case there is a conflict inside the rule. > +The conflict can be the result of: > + > +- Conflicting RSS types, for example setting both UDP and TCP. > + > +- Conflicting between RSS types and the requested pattern to match, > + for example matching on UDP and hashing RSS on TCP. > + > +If requested RSS hash type is not supported, > +and no supported hash type is requested then the PMD may reject the flow= . > + > Note: RSS hash result is stored in the ``hash.rss`` mbuf field which > overlaps ``hash.fdir.lo``. Since `Action: MARK`_ sets the ``hash.fdir.hi= `` > field only, both can be requested simultaneously. > -- > 1.8.3.1