From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60075.outbound.protection.outlook.com [40.107.6.75]) by dpdk.org (Postfix) with ESMTP id E02DA4C91 for ; Wed, 28 Nov 2018 06:59:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WKqFFwAbNYv9JbArxAMpjJKBUdpzze+DXogEMSuA/Ms=; b=oQr5T6zjk8U7ldc2o1jjqdRw0UKVbkqRKx2BJ+QMdQJmDF05U60rgDaYGCDpMQ8mka0LvNEJSb+aMHS65h+7MxNbjvsSmKfJKt3nAd7dsZ4rlmkdrAt8FBhj411GblBfYglQCDGgM3F+XrNXt7JafRJfvL9CNuDGUVYVJvca8J0= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3688.eurprd08.prod.outlook.com (20.177.199.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1361.19; Wed, 28 Nov 2018 05:59:05 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::6194:f5dd:48dd:9b1c]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::6194:f5dd:48dd:9b1c%2]) with mapi id 15.20.1361.019; Wed, 28 Nov 2018 05:58:58 +0000 From: Honnappa Nagarahalli To: Stephen Hemminger CC: "dev@dpdk.org" , nd , Dharmik Thakkar , Malvika Gupta , "Gavin Hu (Arm Technology China)" , nd Thread-Topic: [dpdk-dev] [RFC 1/3] log: add TQS log type Thread-Index: AQHUhp/yN/92ae6ZYUKd9gmq28zsY6VksCww Date: Wed, 28 Nov 2018 05:58:58 +0000 Message-ID: References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20181122033055.3431-2-honnappa.nagarahalli@arm.com> <20181127142415.7950ad77@xeon-e3> In-Reply-To: <20181127142415.7950ad77@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3688; 6:ETwrcR2nSQHl7rcJu0FO4rlCke8DJEwM6EO30htk8sQgBKsSev7k132QbRNn+ULcAg2aURz7qLzWAYJ69Zrj+d54YmBPYvB/3lX1M0tF74vDRSLcbytKfaQLwM0Vhq0D6NWELCrxclH2ug14g2ozXLD1Hxh1OpZKVD6oLL0fqhaGYRnJfDxBUM3qEn99q/+XzfDaHv3ceI9L5f1DGFcC5/Z33eTC3+js1RCHqh9hxIXmB3C5Y5Ri2QYxDc67H7/PqGqjsL3YyQNI3K53zJtxS4PAblgAl/OvkYdjk052S3wb2K2hcIXACaKXrHbvwXvUm4377rUij3YbCV4+ujrHGio/N5hAq0TAnqWH0whE676Xiav4OfEpi7Jb5eVyhdpC6wwLAgSrTVrsrwEN0NlWpsON0iMFllisgmsiEEcQYLw2vRi4qSae+eQewj+lj0KxB7fmado0jNyW6FDIQ3lMZA==; 5:nqUo08qG7fJ845u4JaCBGyOE8Rz0XAOHgdWOqnk/yMxdVse65LUVdgPpkuWalfiD16IeSVI1hGdjfZwpLIquwbTKWSFx7NkkDX8l9iRplzsAIQkRot4Ak4oeBgKh1l67Rzm/t8acqtDd91A7w9qxzuOD/4t0B1y3Fzp2uVjhVdI=; 7:7X7rxmh4BZoItINhJAQ8mAl68cSqH00zW+M5yBy00xKDExsom4nYl6l0e+KzqKbxoZV1950W75UouCnIqeLl6BLdLF62dgFf25U3HmWf2pBibQRlscBWaUFidQEIyUFFMNfZMQO+CiOBhOStgyj4KA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 5181a92b-5b9c-40d5-b1f3-08d654f696db x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3688; x-ms-traffictypediagnostic: AM6PR08MB3688: nodisclaimer: True x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231443)(944501410)(52105112)(93006095)(93001095)(10201501046)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB3688; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3688; x-forefront-prvs: 0870212862 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(366004)(346002)(39860400002)(376002)(189003)(199004)(229853002)(53936002)(9686003)(105586002)(256004)(106356001)(4326008)(97736004)(476003)(26005)(25786009)(446003)(11346002)(6916009)(7736002)(305945005)(6436002)(6246003)(486006)(55016002)(186003)(3846002)(33656002)(2906002)(6116002)(6506007)(8936002)(68736007)(5660300001)(86362001)(76176011)(74316002)(102836004)(7696005)(66066001)(71200400001)(72206003)(478600001)(71190400001)(54906003)(99286004)(316002)(8676002)(81156014)(81166006)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3688; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: aQu7ZIe2W7fNwDp5DdprcyO/GUOmuX4n875PST1uhiHAyx+os0LIUF9z4jvjfKHN+Pf1HjihK7B3kNPvGen1DVSZREto0zLJCgL4rJpHKfW3Q14mSUzdNQVUe+NNuy1BeMrCdLfmEMPtBJYdPbfGkLrx1FTF1f0FOnY+OCvf6SoO2vA/i9NI5pC/0OQHwzbMSmBCr891gRp+O/cRLxTjOc1A3lFEmHZT/DGRT0/3jY8fTqoHD7yXyyMWP2hYutYnhHhiexsItIbBcdoi8gyhqFY+fQFyqlJO+yZPcLmZs8VNlATQjCHtn1dbTgH17N7erIXfBPzSm/+TdZ0xd+3kKFPJL/s4JTUck2TpiVRbIGY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5181a92b-5b9c-40d5-b1f3-08d654f696db X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2018 05:58:58.8390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3688 Subject: Re: [dpdk-dev] [RFC 1/3] log: add TQS log type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 05:59:09 -0000 >=20 > On Wed, 21 Nov 2018 21:30:53 -0600 > Honnappa Nagarahalli wrote: >=20 > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Steve Capper > > Reviewed-by: Gavin Hu > > --- > > lib/librte_eal/common/include/rte_log.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_eal/common/include/rte_log.h > b/lib/librte_eal/common/include/rte_log.h > > index 2f789cb90..b4e91a4a5 100644 > > --- a/lib/librte_eal/common/include/rte_log.h > > +++ b/lib/librte_eal/common/include/rte_log.h > > @@ -61,6 +61,7 @@ extern struct rte_logs rte_logs; > > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ > > #define RTE_LOGTYPE_GSO 20 /**< Log related to GSO. */ > > +#define RTE_LOGTYPE_TQS 21 /**< Log related to Thread Quiescent = State. > */ > > > > /* these log types can be used in an application */ > > #define RTE_LOGTYPE_USER1 24 /**< User-defined log type 1. */ >=20 > Sorry, I don't think this is the right way now. Ok. I see some examples for the libraries already. I will change it in next= version. >=20 > All new logging should be using dynamic log types. > We should work on getting rid of others (EFD, EVENTDEV, GSO).