From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80043.outbound.protection.outlook.com [40.107.8.43]) by dpdk.org (Postfix) with ESMTP id 633E05B20 for ; Thu, 27 Sep 2018 06:23:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a4f7tx3bw2X436z2ilKEek8P4Z29lM2SbpuXWk3BcAQ=; b=eUjs2E4BjBIrROterO/3RhhH6F/sONckpwpgYHVKoG2aJuBZZ7lCGuiLXG3dq07Xju0QPx+T9wyYYs9DwmOq6IDmMf/8nkOPLcgR4NtPd+ZZIDfEsPlZ3ZU0qxJ8J9MyqNfliBXuemT/DSI5YRUGZjkrOoqcanvYv7E9rUONgZs= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB2950.eurprd08.prod.outlook.com (52.135.163.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1164.22; Thu, 27 Sep 2018 04:23:30 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::589e:d3cf:9777:5ff9]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::589e:d3cf:9777:5ff9%2]) with mapi id 15.20.1164.024; Thu, 27 Sep 2018 04:23:30 +0000 From: Honnappa Nagarahalli To: Yipeng Wang , "bruce.richardson@intel.com" CC: "dev@dpdk.org" , "michel@digirati.com.br" , nd Thread-Topic: [PATCH v2 1/7] test/hash: fix bucket size in hash perf test Thread-Index: AQHUUgpRGsZS0HmiYEaftZC1sgg4p6T83A4g Date: Thu, 27 Sep 2018 04:23:30 +0000 Message-ID: References: <1536253745-133104-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-2-git-send-email-yipeng1.wang@intel.com> In-Reply-To: <1537550255-252066-2-git-send-email-yipeng1.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB2950; 6:+QXyZHkx8dKxMzmitB6IV4vqsuZvhgA9KQaaT7cYKdBzidBI2kfweqeQsDtW4NnxpLD0pxCBmcKayWgVPjKTtRfoJigy7dTtzqB+eHDoX/8kI700GcQ+BtNtaQQlW68LeUG5b7QQFHLU1f8zUOuAB7Ogd1Mx52Uku1wR1Et6uurqtZPRDKi2l0Vj89g1258r3s29r6lGLHScUtRQogcC+pHUSgVTUwByUho9DEiz5bjXrqIH6crgOgk4dFq/4aX6fKkMi27jbMAhcjjaiqnCGsLUsfKqavCG8v7a+mm5xqntMPyi5eB32SnRr+UCjD1H9Y8pSMql+TLWzpfWtsXdtuj1EPwLaeUTqpNGLN/bX1TtRwikjY/1q64OjwpywlRMkynZrmLytZqyGeE8qETonvfS083xP/9qSUvMjZDNRcjpz732CIknUW7NQFzdyZEoKlXt7VqrNA4awkabmLEpsA==; 5:I7onnmpnJxaNEpe5knd9DYEwxJfZYns4N3N7m4O48Ag6QVQ/vrUyRsJCal36kxlFW6/5R5PGyqLCZpQ09e+RGIMg25gAWyuMyHfozFKnMCZQ2CrEGNGtqU8tw+n8DDR7pIDN1o9FZEe/CcVW5c/TzFviEdFRcQ+W5JNBJicrFF4=; 7:ssfXPYMSv5Gxh76+em6WgOFQzr1AHvsgWbeQiSEzoCmPyXNLS+GaqO+y6ikVZuus84LwY69C8uoky1B4g5zdDPNtygZOl2FW+iwzXPekIK+udG/bad6T+QlnZxHB4nl6nE8avPSL2zPajgREgGDprrccTO4za8MzI65h/S863UbmuuTJv5W3v5FYbmHzxzZvIXme9C65YA+qoGUD2yNdLYDr7H8ZeH8q4iqIA+uyblukWRygHpywzDXXbpodWHsx x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 05830cff-91e1-4b39-b619-08d62430fb1b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB2950; x-ms-traffictypediagnostic: AM6PR08MB2950: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699)(166494164430575)(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(10201501046)(6055026)(149066)(150057)(6041310)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:AM6PR08MB2950; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB2950; x-forefront-prvs: 0808323E97 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(366004)(39860400002)(376002)(346002)(199004)(13464003)(189003)(110136005)(186003)(54906003)(305945005)(66066001)(97736004)(2906002)(68736007)(316002)(8936002)(5250100002)(81156014)(81166006)(74316002)(6246003)(33656002)(8676002)(4326008)(14444005)(6436002)(105586002)(7696005)(7736002)(2501003)(53546011)(72206003)(229853002)(86362001)(106356001)(486006)(446003)(102836004)(478600001)(256004)(9686003)(99286004)(14454004)(55016002)(53936002)(6506007)(25786009)(34290500001)(5660300001)(11346002)(6116002)(3846002)(476003)(76176011)(71200400001)(2900100001)(71190400001)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB2950; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: AK8JdIj2kTrg0WTdenVgAbrzdT3VjQMUBWty7oSLNi/frEFavqoW5wSf7zpc65c+2iU8JNOKK79KdxUSQSOtVjZXZVMbFn+g60DYGjRt+cYT1DljSteYb6h07fUT4/j5ySnpjt2jttdRZ9f8QBEaqGqelJjhgEb7zxrpDnoLoKdTdLa7UPMhU4YBQrtYaShLCe+YehLdSSz9r34gYWkWaTGdRNkRVE8CBJ2C5ZpmQP2V78S/t05Sb3jQDLL1tuAfgqEURNPu3wgn4D8sTpo2b7Cn5owSsT+m9MORyOACWDUDsVfbMtnUxEOX36AIgn/YZimrh0hHknj++vHjYyeWv1AjG7cqEyt5VVJNJMZtHKc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05830cff-91e1-4b39-b619-08d62430fb1b X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2018 04:23:30.8640 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB2950 Subject: Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 04:23:32 -0000 > -----Original Message----- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:17 PM > To: bruce.richardson@intel.com > Cc: dev@dpdk.org; yipeng1.wang@intel.com; michel@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 1/7] test/hash: fix bucket size in hash perf test >=20 > The bucket size was changed from 4 to 8 but the corresponding perf test w= as > not changed accordingly. >=20 > Fixes: 58017c98ed53 ("hash: add vectorized comparison") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yipeng Wang > --- > test/test/test_hash_perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c inde= x > 33dcb9f..9ed7125 100644 > --- a/test/test/test_hash_perf.c > +++ b/test/test/test_hash_perf.c > @@ -20,7 +20,7 @@ > #define MAX_ENTRIES (1 << 19) > #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */ > #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, > several times */ -#define BUCKET_SIZE 4 > +#define BUCKET_SIZE 8 May be we should add a comment to warn that it should be same as ' RTE_HASH= _BUCKET_ENTRIES'? > #define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE) #define > MAX_KEYSIZE 64 #define NUM_KEYSIZES 10 > -- > 2.7.4