From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30063.outbound.protection.outlook.com [40.107.3.63]) by dpdk.org (Postfix) with ESMTP id 3E9561B7D4 for ; Mon, 17 Dec 2018 05:54:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N+xpms3N2xvnn86IOrZ97Cf1hnHlT/ucm963dOqHmDw=; b=ZfM+Sd4PdRlchhqAEnZ8rDX1Kz106csvrKQL5SaeoFHDI2Us2NkeWVO8SAhbBnD9tk/SiQ6vz9xh/R1ClBcIBxmvk+B5rC1o5mVIbGKgM4hp/PPE9/bJSyupLNZkF6Ta8HibGUNB65sqBtlBzcbICRpUD3ces6vBC/WAE87u4N8= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3622.eurprd08.prod.outlook.com (20.177.115.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.18; Mon, 17 Dec 2018 04:54:31 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::78ab:2bf4:5476:6c3e]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::78ab:2bf4:5476:6c3e%2]) with mapi id 15.20.1425.021; Mon, 17 Dec 2018 04:54:31 +0000 From: Honnappa Nagarahalli To: Honnappa Nagarahalli , "Wiles, Keith" , Jakub Grajciar CC: "dev@dpdk.org" , nd , nd Thread-Topic: [dpdk-dev] [RFC v2] /net: memory interface (memif) Thread-Index: AQHUkHAdTxLLFdP63UiBhvEXiZVZG6V4Df4AgAAG7ICACkf34IAACzAA Date: Mon, 17 Dec 2018 04:54:31 +0000 Message-ID: References: <20181210091457.6031-1-jgrajcia@cisco.com> <20181210100639.30244-1-jgrajcia@cisco.com> <92C073C7-AB56-47BE-825B-C3CE30F73EAB@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3622; 6:5DQdE6fUaA6Te2J1bcYeAv9kaNjYPV08GzpGteF4tmc9Zw08N7YkCWuRS1lLJGDu8q4VBxzQnbdvJ1UXyQendmp/0LkYpfBr9hKEiEt9pg/wxly2TO4EQ+CJwWEpxEPQgdj1jsMBxrR4qDlmR35O2JLV0JJqrmXk9iywx9hZH5OFTomC3PgFbi9uocojB4NVQgRZCUBEjc8sQAOBHdJZYoWMDVYsVr4Z5WYeKuY4ri4xlPuxQtIfAa2fver8QqAayp1kpILBmZYLI0PXySm7JBa4ujxUweNDERaQEsQjcLTTx91jKWCCR8W3uRMUyjbautdkqp01HtTJzcw49yLJoCIexVIEREQyHdH5m01+fqQUSVjzT8qNaFdWRf54iMWrYuUjwBkoMgugAXJNj9F9F7etFBMJNvh5WlP01qXMdY4NfYzHJjFCVWqMho7WhPjC/XYlYr+PWSupY00ouM5xBw==; 5:0PxzBY+RxWZXDeFo+FjYmQ9j67ZN1NmtPivNpkoO+J3VYCNqjNgw/VUoGF3nkGoltOWc6/R5kw3ltnBLrf65ARJG81E9egzKeQkiq47sfGMlqIbWyISrQYwFBcOOMbZ4spj12KwRXw4KaFrUVhiz/2GK0dO0wvKZjCEtpJlYHnk=; 7:H+mhChnzStmKYXmvMNZ2fGs+9dOW4wLKWhSLwOjSLEvw+RxIugx/U574AFsQhf5EUOJ4IzPyKQlQydAFOnNQPnVHRsonu873w8pyKoFTN/ocRC5VJJFDsSoGjdJlbs9BWm7fodPMtWpN3cl/kwXBhA== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: 341ae42c-c7fb-4159-177a-08d663dbbb60 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3622; x-ms-traffictypediagnostic: AM6PR08MB3622: nodisclaimer: True x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(6040522)(2401047)(8121501046)(5005006)(3231475)(944501520)(4982022)(52105112)(10201501046)(3002001)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB3622; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3622; x-forefront-prvs: 08897B549D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(366004)(396003)(346002)(39860400002)(136003)(376002)(189003)(199004)(97736004)(6436002)(305945005)(66066001)(55016002)(68736007)(93156006)(2940100002)(478600001)(256004)(6246003)(14454004)(8936002)(966005)(8676002)(72206003)(74316002)(53936002)(6306002)(486006)(4326008)(106356001)(476003)(11346002)(99286004)(446003)(93886005)(33656002)(9686003)(2906002)(7696005)(71190400001)(71200400001)(110136005)(6116002)(3846002)(229853002)(6506007)(5660300001)(53546011)(316002)(54906003)(26005)(186003)(81166006)(81156014)(7736002)(105586002)(86362001)(102836004)(76176011)(25786009)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3622; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Vn1ifee2MkeH3qGlpfZ2Qb1XAfIbsHxactavXz2oPk0/huISgUUe3nowSmJVaVPrgMbvL8i8Y0Cjb4lSzRzrdOkp5T7yqIFijDJ9C1PzGqHxIirN8uUUOmvDP0VpIIZRW5W5b7VZQzx2mK+J2u68LCerI83BdznOM71imb7KoVuHIc2VBqDT/QXmk3VvO+IgiD747+EDR1jjGtVhAiIc5ZTZpzTtkBg21xDei4rF6AgiR4VRvaOcKD4PJMeeeaEtQaX7AGTspVeunGZl2Om3JPlrpJLRAZjEdd/HghN5MU1kj0oDiBx+ZTil0l+1BqNC spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 341ae42c-c7fb-4159-177a-08d663dbbb60 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2018 04:54:31.0817 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3622 Subject: Re: [dpdk-dev] [RFC v2] /net: memory interface (memif) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 04:54:32 -0000 > > >> On Dec 10, 2018, at 4:06 AM, Jakub Grajciar wro= te: > > > > > > I do not like being the coding style police, but that is most of the > > > comments > > here and I will try to test this one later this week. Plus I am sure I > > missed some style problems, if you have not read the coding style for > > DPDK please have a read. > > > > > > http://doc.dpdk.org/guides/contributing/coding_style.html > > > > > > One comment, why did you include all of the code to handle memif > > > instead > > of including the libmemif.a from VPP. I worry if libmemif is changed > > then we have a breakage. I do not mind the PMD being standalone and I > > do like not having the dependence. > Just for my understanding, do you mean to say we could include the > libmemif.a as a binary in DPDK? >=20 > IMO, I would like to view DPDK as the device abstraction and VPP as the > protocol stack built on top. From this perspective, it is good to have > standalone memif in DPDK. >=20 > > > > > > As I did not dive into the code much it does look reasonable and I > > > hope to > > give it a try later this week. > > >> > > > > A couple more items, do you plan on writing the documentation for the > > PMD and provide an example program? > +1, would be good to have a cover letter. Please ignore, I already see V3 having some documentation. > I would like to run this on Arm platforms, mostly in the beginning of Jan= . >=20 > > > > Regards, > > Keith