From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150051.outbound.protection.outlook.com [40.107.15.51]) by dpdk.org (Postfix) with ESMTP id 418841B732 for ; Mon, 17 Dec 2018 05:26:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=08O2tv+BrTq0/Igwo6Vm6SIqPZhu9J412q/zWw/D3hk=; b=AkvH7uUn9BAqIcYvnfAfmwqLvxL2hecqwbZoaw0srQP8MFtDM2F3mXE9YGmIXViYC/pAfKcXaNpsYLZOXcL56MkI5KC19I8ud90k8bLMXSUe1es/WTCLc0zu1xs8Y2Mj4hIRx9UVFZHmrDcJqGFy/87IQvjKRb9Q7542RxkHjLE= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB4551.eurprd08.prod.outlook.com (20.179.18.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.22; Mon, 17 Dec 2018 04:26:02 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::78ab:2bf4:5476:6c3e]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::78ab:2bf4:5476:6c3e%2]) with mapi id 15.20.1425.021; Mon, 17 Dec 2018 04:26:01 +0000 From: Honnappa Nagarahalli To: "Wiles, Keith" , Jakub Grajciar CC: "dev@dpdk.org" , nd Thread-Topic: [dpdk-dev] [RFC v2] /net: memory interface (memif) Thread-Index: AQHUkHAdTxLLFdP63UiBhvEXiZVZG6V4Df4AgAAG7ICACkf34A== Date: Mon, 17 Dec 2018 04:26:01 +0000 Message-ID: References: <20181210091457.6031-1-jgrajcia@cisco.com> <20181210100639.30244-1-jgrajcia@cisco.com> <92C073C7-AB56-47BE-825B-C3CE30F73EAB@intel.com> In-Reply-To: <92C073C7-AB56-47BE-825B-C3CE30F73EAB@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB4551; 6:mXwy9ur5YVEmbaneCIKDDHTtBYCqOE+nSryWRn96PGK2G5N38LzfLZJjauYwXNaPcuNRfE51Ths6pLPUYyMuEgN9PJRrP5jyczkiTzj4wWvMAzvSQ39Va/RiiJKvlqLnITgTJ6ulnayLXK/v7xXsf7zqvrBL9O4fXbEowYcNDkEEmMWBXMp/0j9dIT1HbZsWszn/8ApvdrvTwlI61YtLrhCF2QopQ1doADkH5foYYzzHM0jiW6NY2IdhBcWLNLlycI2fB4ALLDazg0RIhV0+VrO8fMmWvbr91wO/6Fsge8FZbT5oK9dVCpWDSaNYl1Vkb4s0FkQUpahFV7jr8ReCA5aOTWhwQ1DKGZeLTCl7bljJTxNo8KIVZGRp9RncBEchQ7v1XM2YDxJNDSbkz3be31QmsA1RKOoEAJt7HQwmNayr9wlX6TTtkXSTV9qAbb0FvFCzA0V2kchAO/3z1rv23Q==; 5:nPtdy/m7YzWoK8jLIH5D7Yyc0/yR9faH9Jp+LdH8fyjZly4LFOcTUiFW2inqSbEEXMy11nEbJg5o1iX70s7hE47EbDb6yZQmF6Wtmn/Z6b1jH38WP5WmUdORaEpuDDk26Zr9fQXBavkv4R+uh3j1dzVIGgsYQbGfv5d1Z4yPQwI=; 7:pMX7c3MK/SbBfoZ4wd+C5hfpLkLOqp7wdDI9ZKR1vTYNOj0wODoadyMgiGTI7WqOnvJlD4PSbXzqpcOvpWtUER0LTx4V6Q4vFTNGLZkVCNjKNq4ampShq/tWNVXAeR/YUbVcMMd5X/RKQVFg/jE27Q== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: b32005cd-b5a2-445b-bca2-08d663d7c08e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB4551; x-ms-traffictypediagnostic: AM6PR08MB4551: nodisclaimer: True x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(6040522)(2401047)(5005006)(8121501046)(3231475)(944501520)(4982022)(52105112)(93006095)(93001095)(3002001)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB4551; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB4551; x-forefront-prvs: 08897B549D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(39850400004)(366004)(346002)(376002)(396003)(136003)(189003)(199004)(25786009)(97736004)(99286004)(110136005)(305945005)(54906003)(478600001)(66066001)(71190400001)(71200400001)(8936002)(6436002)(33656002)(229853002)(316002)(7736002)(74316002)(966005)(72206003)(6306002)(93886005)(9686003)(55016002)(53546011)(26005)(3846002)(4326008)(6116002)(76176011)(86362001)(186003)(68736007)(2906002)(53936002)(256004)(6246003)(5660300001)(106356001)(81156014)(81166006)(102836004)(8676002)(7696005)(6506007)(14454004)(11346002)(476003)(486006)(105586002)(446003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB4551; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: h68fllLpmjoPNPifSXPd/LJ8oxkUovk+SSfDoiFQWN5qB0Ls8cQ457/iTo+TOuXy2thMC1FqgpHBzIG01QGMtOjLwmO5NyQQYcBovsmcU+A7HxKsS5l2rfVb8lpavnQkKNs+EN0n3SyeSPQ+fg/Ys6n4xFzT2aNmQ+4UebHPjTGCkkJvGinmKGaFCneeqbljuZ2bSAZ2vWjsUQzARZKdUCUMD9NA6SGtAEV7tseMKUo3yfdDpx66Gn9HwXWwSVXise6gAcDtpEAaAstyEHdXN/QJ0+c8yIGU/7/BckrC6UdX4VYwRB8i5xvQzvuQ2sJx spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: b32005cd-b5a2-445b-bca2-08d663d7c08e X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2018 04:26:01.8601 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4551 Subject: Re: [dpdk-dev] [RFC v2] /net: memory interface (memif) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 04:26:03 -0000 > > > >> On Dec 10, 2018, at 4:06 AM, Jakub Grajciar wrote= : > > > > I do not like being the coding style police, but that is most of the co= mments > here and I will try to test this one later this week. Plus I am sure I mi= ssed some > style problems, if you have not read the coding style for DPDK please hav= e a > read. > > > > http://doc.dpdk.org/guides/contributing/coding_style.html > > > > One comment, why did you include all of the code to handle memif instea= d > of including the libmemif.a from VPP. I worry if libmemif is changed then= we > have a breakage. I do not mind the PMD being standalone and I do like not > having the dependence. Just for my understanding, do you mean to say we could include the libmemif= .a as a binary in DPDK? IMO, I would like to view DPDK as the device abstraction and VPP as the pro= tocol stack built on top. From this perspective, it is good to have standal= one memif in DPDK. > > > > As I did not dive into the code much it does look reasonable and I hope= to > give it a try later this week. > >> >=20 > A couple more items, do you plan on writing the documentation for the PMD > and provide an example program? +1, would be good to have a cover letter. I would like to run this on Arm platforms, mostly in the beginning of Jan. >=20 > Regards, > Keith