From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130088.outbound.protection.outlook.com [40.107.13.88]) by dpdk.org (Postfix) with ESMTP id F0CB81B6DC for ; Mon, 17 Dec 2018 06:16:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XFGq9Lg13pbJfLpwGq94F7dkNKIpsoOXf+gwErWmmzI=; b=rwu1xJoN9h2Jlly8WUxn0Uyybc2lcJQ/m/3M8dJjBKbI5cTk0WCLWh/MfJc/f/6ZPnAjHk5KqOPYxDA81TtsD0PWMkm2HAIEBd+jktc10HLBCBFKBr3OWDQVwNsWK8RkS8biuhC6LlibFhDAzRGrpojjOvZrVbP7m2tHVblZg3U= Received: from AM6PR08MB3672.eurprd08.prod.outlook.com (20.177.115.29) by AM6PR08MB3752.eurprd08.prod.outlook.com (20.178.88.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.20; Mon, 17 Dec 2018 05:16:56 +0000 Received: from AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::78ab:2bf4:5476:6c3e]) by AM6PR08MB3672.eurprd08.prod.outlook.com ([fe80::78ab:2bf4:5476:6c3e%2]) with mapi id 15.20.1425.021; Mon, 17 Dec 2018 05:16:55 +0000 From: Honnappa Nagarahalli To: "Gavin Hu (Arm Technology China)" , Stephen Hemminger , "Joyce Kong (Arm Technology China)" CC: "dev@dpdk.org" , nd , "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , Bruce Richardson , "Ananyev, Konstantin" , "chaozhu@linux.vnet.ibm.com" , nd Thread-Topic: [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevant perf test case Thread-Index: AQHUkpU8jZKQzEv7ekS8PWyGlJjUhqV8I9MAgAFPzKCABPU+YA== Date: Mon, 17 Dec 2018 05:16:55 +0000 Message-ID: References: <1544672265-219262-1-git-send-email-joyce.kong@arm.com> <20181212212710.3c9ad4d3@xeon-e3> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR08MB3752; 6:Wbb1w/QZpptvEIK+wcr2yNHJs6YLB7eRXtlQ7VgOyJmxlpOKycgxGqzfKHu2FyycJ12QAF71vAGlq37VzELRoWThueJwjqW2MuXo8GjjOD4HNyH8iuFTBmwORR/hrIVtwpQ2GZF1Cxk+HniKZ+pZ37rKe9ElmXe0PvIGs5SZs6f+kKZNGx63WGe7NH/TfG4aMXSWQs1YcqgCiQaDp2wpol+7sqv6QzYrU/PKppWCdv0OjlRIKmun4exSj+aq2oGBHbb5fcI8GC6Dnr8q7A3mMQ0WCm79l1uaV0hoOnDOi6KR41k2xbvC0mwwdn+2Km+ma3J6lZWi5Rj6C9f5mwV/SjAzuJmd33fxtJId+1FZqNEIJ1yZUkICeGoWyMsPRi3EDDTexX+s9awR+ebKwpklOIeckeE4JxxZ02yBSlAPuu5NP1BxC8cIrOdUQt9YFa/WFpk1oONvxwWl1DbKLp1+RQ==; 5:49E9qW/jrb1U6+iGigQGzKLuWAEzS+LAOd2KpSyvk3A1xc8IThNtNellEFvIFBAO5+RAegBEBGaQF7voqgMtzo5pYmha6gZRqTdQCRUUOMbI0e3sWWDvVkytLODuFRCK296w8AIEihP8+J6gjkZcZnrE7tX+cj6j2Nc2JRuKI7A=; 7:EigOugc8sm8KdQoB5myps6LquNnGEFkDJOra/XnhIBI8LBlT7jgJ48FKBgfPVy56hc/ttbbo9q2jai4zKWn+xUR+D0XVJ19N1tDc67qP37oZ6dZOrspKVk7MQMJ08l90efL/ibYVJideCVLiCeQ4kg== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: 426528d6-6c49-4736-b54a-08d663dedce2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR08MB3752; x-ms-traffictypediagnostic: AM6PR08MB3752: nodisclaimer: True x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:AM6PR08MB3752; BCL:0; PCL:0; RULEID:; SRVR:AM6PR08MB3752; x-forefront-prvs: 08897B549D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(376002)(396003)(366004)(39860400002)(13464003)(189003)(199004)(6506007)(106356001)(71190400001)(7736002)(54906003)(478600001)(6246003)(6436002)(14454004)(97736004)(110136005)(68736007)(4326008)(55016002)(6306002)(53936002)(14444005)(256004)(66066001)(26005)(6116002)(33656002)(2906002)(446003)(476003)(7696005)(486006)(186003)(72206003)(9686003)(25786009)(99286004)(102836004)(966005)(3846002)(6636002)(74316002)(81156014)(81166006)(8676002)(8936002)(229853002)(5660300001)(316002)(86362001)(53546011)(71200400001)(305945005)(11346002)(76176011)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR08MB3752; H:AM6PR08MB3672.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: KxVLfB4/1kVrkfqse6VRJxjh5jklM7z2mjFvW/Ix3bCQq1CYL0QRyq5rtBPMEYWfNnJXx8r0Z9vYcSvr8hQaGCB/El0Bj/mvuB6IKIGnwP8eDjgvl4pDWXj2XpQ+a4YsLP41f8ZldRlRsAyqonXUc0CPpkY0GgKcUdMWgc4Lq47O9J67ZH+A9owVhtgRfeXMoYoT1iyEykFuFGaUEZsBB9g3H3XE9heZfTLvbL6RavGYHPzaLniROAOCChPHMTYwbB6FzdClNYvV6lOPA9Fu7luQBaYeo+jm6wejBn6AWY9odQWpxDD5vHUQOF+DGqPK spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 426528d6-6c49-4736-b54a-08d663dedce2 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2018 05:16:55.8457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3752 Subject: Re: [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevant perf test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 05:16:58 -0000 Adding other platform maintainers as it affects all platforms. > -----Original Message----- > From: Gavin Hu (Arm Technology China) > Sent: Thursday, December 13, 2018 7:30 PM > To: Stephen Hemminger ; Joyce Kong (Arm > Technology China) > Cc: dev@dpdk.org; nd ; thomas@monjalon.net; > jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; Honnappa > Nagarahalli > Subject: RE: [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevan= t > perf test case >=20 > Hi Stephen, >=20 > Thanks for your comment and sharing the link! > We are looking into it and it may take more time for performance profilin= g. >=20 > Best Regards, > Gavin >=20 > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Thursday, December 13, 2018 1:27 PM > > To: Joyce Kong (Arm Technology China) > > Cc: dev@dpdk.org; nd ; thomas@monjalon.net; > > jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; Honnappa > > Nagarahalli ; Gavin Hu (Arm Technology > > China) > > Subject: Re: [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add > > relevant perf test case > > > > On Thu, 13 Dec 2018 11:37:43 +0800 > > Joyce Kong wrote: > > > > > v1: reimplement rwlock with __atomic builtins, and add a rwlock perf = test > > > on all available cores to benchmark the improvement. > > > > > > We tested the patches on three arm64 platforms, ThundeX2 gained 20% > > > performance, Qualcomm gained 36% and the 4-Cortex-A72 Marvell > > MACCHIATObin gained 19.6%. > > > Below is the detailed test result on ThunderX2: > > > > > > *** rwlock_autotest without __atomic builtins *** Rwlock Perf Test > > > on > > > 128 cores... > > > Core [0] count =3D 281 > > > Core [1] count =3D 252 > > > Core [2] count =3D 290 > > > Core [3] count =3D 259 > > > Core [4] count =3D 287 > > > ... > > > Core [209] count =3D 3 > > > Core [210] count =3D 31 > > > Core [211] count =3D 120 > > > Total count =3D 18537 > > > > > > *** rwlock_autotest with __atomic builtins *** Rwlock Perf Test on > > > 128 cores... > > > Core [0] count =3D 346 > > > Core [1] count =3D 355 > > > Core [2] count =3D 259 > > > Core [3] count =3D 285 > > > Core [4] count =3D 320 > > > ... > > > Core [209] count =3D 2 > > > Core [210] count =3D 23 > > > Core [211] count =3D 63 > > > Total count =3D 22194 > > > > > > Gavin Hu (1): > > > rwlock: reimplement with __atomic builtins > > > > > > Joyce Kong (1): > > > test/rwlock: add perf test case > > > > > > lib/librte_eal/common/include/generic/rte_rwlock.h | 16 ++--- > > > test/test/test_rwlock.c | 71 ++++++++++++= ++++++++++ > > > 2 files changed, 79 insertions(+), 8 deletions(-) > > > > > > > Did you consider using a better algorithm not just better primitives. > > See https://locklessinc.com/articles/locks/ for a more complete > > discussion of alternatives like ticket locks.