Re: [dpdk-dev] [PATCH v6 2/5] hash: support do not free on delete

[Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>]

> 24/10/2018 03:32, Honnappa Nagarahalli:
> >  /**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice
> > + *
> > + * Free a hash key in the hash table given the position
> > + * of the key. This operation is not multi-thread safe and should
> > + * only be called from one thread by default. Thread safety
> > + * can be enabled by setting flag during table creation.
> > + * If RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL is enabled,
> > + * this API must be called, with the key index returned by
> > +rte_hash_add_key_xxx
> > + * APIs, after the key is deleted using rte_hash_del_key_xxx APIs.
> > + * This API does not validate if the key is already freed.
> > + *
> > + * @param h
> > + *   Hash table to free the key from.
> > + * @param position
> > + *   Position returned when the key was deleted.
> > + * @return
> > + *   - 0 if freed successfully
> > + *   - -EINVAL if the parameters are invalid.
> > + */
> > +int __rte_experimental
> > +rte_hash_free_key_with_position(const struct rte_hash *h,
> > +                               const int32_t position);
> 
> You need to add this new function to the map file, otherwise linking of shared
> library will fail.
> 
It is messed up. The map file change is in 4/5. I will correct that and submit another version.

>