From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 627D5A0579; Thu, 8 Apr 2021 11:08:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22371140F73; Thu, 8 Apr 2021 11:08:17 +0200 (CEST) Received: from FRA01-PR2-obe.outbound.protection.outlook.com (mail-eopbgr120050.outbound.protection.outlook.com [40.107.12.50]) by mails.dpdk.org (Postfix) with ESMTP id 43C3240138 for ; Thu, 8 Apr 2021 11:08:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=00N3TueK9580AE3cAxaqks7DXsjLOrGbhwLF5pzYCHI=; b=9xqWzYKPf47946t+CHBA73XSMSLYcmZwsP8P6yGPamnqGSY593j8chGRT78Msu4xUz9hpCzPdEPrrxhC426f8O8JSoWbI5LY8pc0wSxsAyXvhZEZ8RQB/Y7SVTLoJmdxJQv4L1xSfTtaLKLs6r2EfOtsIHp8+6mT5xuxIQsAYO4= Received: from AM6P191CA0067.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::44) by PR2PR08MB5225.eurprd08.prod.outlook.com (2603:10a6:101:1c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32; Thu, 8 Apr 2021 09:08:13 +0000 Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::f8) by AM6P191CA0067.outlook.office365.com (2603:10a6:209:7f::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Thu, 8 Apr 2021 09:08:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Thu, 8 Apr 2021 09:08:12 +0000 Received: ("Tessian outbound 700fd1fc53d5:v90"); Thu, 08 Apr 2021 09:08:11 +0000 X-CR-MTA-TID: 64aa7808 Received: from 8d400ab9ff2f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 25F34DDD-C9FA-499F-A0C6-68CC70A672CD.1; Thu, 08 Apr 2021 09:08:05 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8d400ab9ff2f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Apr 2021 09:08:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Py4rfKipF37NxQ4i7FvH3R8vISzAxXH3myGVtcmVfdnUumKkjIVW4plnCiEua03m7X9VkATHYh8b2eQna1T+nTezEzcYoLQ6nh9P7lGpjXAvNqO/DdHi4vo/SSMPXmDUYPX2cy9PgZHHXD448/5+RQo0BFN4TZZJm6ZlZk7hF/y+UYW2lcW7KDo56Q4kViCVGZGuEXtxbBOONPJLaq8bEztAUCzqmVU1iYRmHZfZ8EQ3fWTK3uZPVvHeMfVp8vVToCQc8TFdX3Zur0bHz4eTvzfyhug+iqpCAXBe4fl/5XYr1UWn/7P7Mie1E4pMsguwNqA0FtFKhO4Tlg8BnjmdJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=00N3TueK9580AE3cAxaqks7DXsjLOrGbhwLF5pzYCHI=; b=TlLT8qEzmwck5Lz98r6D8vM0PyGJqOzLnoT++likLpNrl90pyM6aULM2w6WWkGr3Jm2oeVIuRrKb1rA5rb7XV8KEHz6J9kft+bQfqk+YToGoqjhce/QrZLmsXaYBDgknUXC1KQsRnIOs9k648GIsE00lmVgPIY2FMebyp8pHTRg6Fj4T2zXcPzZqqUgM4Yl5X1ZwlDWLiwxCZHxip7Zemb7IT4KEDm+gYWy7l7JqQigN+sEjNMTn62ETsY64Y1YMNBbcp7yMKn9dL5xQDBWWB2TyJcuxmeWpMWT8e4AcG/F1tP4Q3ZZkiDMVnttGMSLrSdYlpRvml3Q/PEJS6BfYnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=00N3TueK9580AE3cAxaqks7DXsjLOrGbhwLF5pzYCHI=; b=9xqWzYKPf47946t+CHBA73XSMSLYcmZwsP8P6yGPamnqGSY593j8chGRT78Msu4xUz9hpCzPdEPrrxhC426f8O8JSoWbI5LY8pc0wSxsAyXvhZEZ8RQB/Y7SVTLoJmdxJQv4L1xSfTtaLKLs6r2EfOtsIHp8+6mT5xuxIQsAYO4= Received: from AM8PR08MB5796.eurprd08.prod.outlook.com (2603:10a6:20b:1d1::22) by AM0PR08MB3923.eurprd08.prod.outlook.com (2603:10a6:208:123::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Thu, 8 Apr 2021 09:08:03 +0000 Received: from AM8PR08MB5796.eurprd08.prod.outlook.com ([fe80::8dde:97cd:c482:ef11]) by AM8PR08MB5796.eurprd08.prod.outlook.com ([fe80::8dde:97cd:c482:ef11%4]) with mapi id 15.20.3999.032; Thu, 8 Apr 2021 09:08:03 +0000 From: Richael Zhuang To: Liang Ma , "dev@dpdk.org" CC: nd , Richael Zhuang , nd Thread-Topic: [dpdk-dev] [PATCH v3 3/3] test/power: add delay before checking cpuinfo cur freq Thread-Index: AQHXK4I/dLaITDxW90Om6eoWJSCbBKqo1p0AgAE+CXCAAC0vgIAAE66w Date: Thu, 8 Apr 2021 09:08:03 +0000 Message-ID: References: <20210407023910.51052-1-richael.zhuang@arm.com> <20210407074636.26891-1-richael.zhuang@arm.com> <20210407074636.26891-4-richael.zhuang@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 15C301D4DE2ED344BC39A99C85453A85.0 x-checkrecipientchecked: true Authentication-Results-Original: liangbit.com; dkim=none (message not signed) header.d=none; liangbit.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.113] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 51fb427e-fff2-462c-25b3-08d8fa6dd642 x-ms-traffictypediagnostic: AM0PR08MB3923:|PR2PR08MB5225: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4303;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: x8laR2ZhGkGpNSCy3Qd3bRSKQFHcC6S2DdRdyywqR4keTid7I3VJx3huckOdQH8WhpkSurSwLbVZbGbEYSNkKGoQpYsMt3YgQ7qKa7DWZVb8HAQYiBYFNYrsEBe1sA1nk+LdNvujtny8vy5N9krXCd+0gVknDW29ie9tYNNkPCOeetDCJU2RnwNl6qOMHSgZhM5uUsuhLicomlXQhdNorIyc5JkXOr6qRyao4IJGsIbtNsiW3xFlgnQqdM0LmluT1y7V0nJRWUXn71yOEzsbCqJVykLzWESJyCNrcmNbtxlEk9yWyBZh+1ONt4l0pMLFwre7f1hI2EZ+uaW1bngUo8BWkQYOzFDnOFynWHm/uOYpVwtlRQjYRxaov0LvQTw4DzK1dLMgXbXuVNhfBjIO1FsA4AwWkLBnZXNNxoKkVCcXs1eowOSgm0bjw/HKXwcx5rmRJgiHbZqOJRsjcwwoDZ905mpbbSJwhuHcbjI+nnr1BFwjBgRp0Z6T0nUwDNpHSD7JIjTQBwfoX2ppQvb2Kx/e25LXwyUMB6WIFFJexaIn3h1YP9DrumXVKXHZsNkD5XXy4qXCPVy0qWDo6AcJrc8wayWstnTsHKVXH0faM4jfpN0MbI5AFadfbxxr6jRMJSet4RbK5iaBL5ykB5IIBVhKhFQUuzS4FLLs1cPpMOA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR08MB5796.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(38100700001)(76116006)(5660300002)(110136005)(7696005)(55016002)(26005)(9686003)(52536014)(4326008)(478600001)(316002)(66446008)(64756008)(86362001)(66556008)(66946007)(66476007)(2906002)(71200400001)(8936002)(186003)(8676002)(53546011)(83380400001)(6506007)(54906003)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?K4Ozkye+V3NrqF9NXmdDSUIS5K7p1DvXDbo8NkLQYukVWSifkmcLSUxlRw3H?= =?us-ascii?Q?rqOgj/O+QjeTO89sQMYVM77evjy2Yhmd8WlpB2bfzNUxTKf1HuPBG2UwgMF3?= =?us-ascii?Q?eQ1e24wKjlZckbEV1JdMneBP8JoE1qVfO6nwdwyc07wUY0O5khi/0scnii/v?= =?us-ascii?Q?3gL2ofUS2gpiSpN9fjzY220Bahou+f1yQw/LEuuvDfIF5Jc265wesvgihLFf?= =?us-ascii?Q?YLXeDQrhXcjtIPMcy9QxSggg7eh9RGPkjJQnT0phrlxTZBTsJuLCt26+boTR?= =?us-ascii?Q?8WMSlu+nxhIg5isLtyNwSKp41ZV78EsIylQs12C6AfqGgIOdckKzKx1KBE9l?= =?us-ascii?Q?VsFkTfsttemKLHUj0vh8VWGHzkL4OTvBRFAU+ErP8DR0dAIfeMrvM6MYdIXC?= =?us-ascii?Q?XUr6xhoiIR1NiH71zeQsBuIEgGyQXWVr+j5NEUdwArVuyEs93XcxUJqHZxV2?= =?us-ascii?Q?oX+/UyQJLB1wy7XUUb1l5ax51OFHfpd+58RLXKe6l0YmwfsgmtWJLtbPWg6Y?= =?us-ascii?Q?gI6vcvuqgXehN3y8PydouLuGYbZg9B1Hv1PrX6etXGvV7Iy/ojXu3A3pZ8jL?= =?us-ascii?Q?sEEkqcynsQPfYLNVxZ0aLFp30kqM82/P5LHrG+1KJG+y9cuIJ86vEISkdAUv?= =?us-ascii?Q?Zi9dk4/FR1rbZDwf9RM6oIM1wPK9YIhX/CDLmEzQV/mRclzKmxJvqm9FoFSc?= =?us-ascii?Q?di7ndgVEIIxxpImy7u07ZOTUjRU3jIA6gzhVe/ZcPOlqjOmxflHLkDP+1F5q?= =?us-ascii?Q?qzaDLvqVRW7Gpl0O9OtO1SBCwYII1UzwRoi6ioobx7hYhn2gqs+a5fxghf0X?= =?us-ascii?Q?TfN+KEoazeYuBL9ubN8wgs5TXR0SV/FHLySRGZP0de+7a5ZxCteaMDW5e27Y?= =?us-ascii?Q?Q4SB95sfDR/1JHb0QUb4qpRoqsmI0L8xYKS+zgxEEx1sNXjHsXsNsd0VEYi8?= =?us-ascii?Q?p4tdO7KoAHU3hnMOH6Wf+Ubh9BdAeUbRipQwl6Ld/xEY/I++eXhoB5ZmmWcn?= =?us-ascii?Q?BJRTF74F0lzYDUKACrOhqSj7utm1+RnLulPVmY8YjA9Cc4Rnhbycu7yODc5+?= =?us-ascii?Q?aPDCNeBHJRNFBOXoudKt4k+I7vxg0pj9n/cofpXB3g/HhX0nPPOQ/+CU9Uxk?= =?us-ascii?Q?iqzb5CRM9bsvUTBXvA5Uh7IkHpQZ4chvyGUuKE7bGQi+4hIubAxOMNP1Juzm?= =?us-ascii?Q?d26s91QQ9fcmVFn8DmL8exB2YME8h0LonL64R6/SqYEW9i65qt2cXsE0GPWw?= =?us-ascii?Q?Rx+i3NL3A1gdZ4FSBmPZHnfGye8k4IbUnrQvq9mwh8wFHQ6T65Atyqb8KcQE?= =?us-ascii?Q?VzvZpLrvHounjxNSVH+mzmyQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3923 Original-Authentication-Results: liangbit.com; dkim=none (message not signed) header.d=none; liangbit.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 14a3617e-2bc8-4e02-9369-08d8fa6dd0b6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ygr74vWeW/yrTlF+/0+c6u/JEHUYJJu/GQFNxGy+qck3fNkT0g0ER36dP8mo6QluEaUgu/Ka3OQyutX6lGWHxkZdiRfoBEYuTbwHEdYNp5hs0UrRopObLU6DCnEia/bEvCC6wPCJcCVbAPbXQCq/PIfu6/On/3FYgSIKcjKp2vSm/mKHQ4tTN455aJhGS28q2F7hUXLKx4LyxK0BNnI6u3fQd97MVu1fMAD1WJfUAWw6NT3Ny7ht56uaRBzh5eEiXAHP896jEpg5rsMVXmzlQJhHQaHRZ0q2WstTrbEbrVg8WAt75gruq1MXUCM31XdWGdcD/dYKEyYao7IXQUdpF9cp6cp3d3ZjTYYIK9Qp15KjFOg2G5ivs4da9bjNi3Jv6iC1HMGEUAHR9TcXtRyI/3NZH3NHLOYNmLZ3uaPH87Exnk9oBcI2Tj/UjC7qd4xpxb4lMY8s654DEm/B9maRrSOx+mNN8ZHnN9bQad1Io4oQ6teJA+RtvyuernMFdDqkDuQgKbzoltX7RwsdQuAmqZDJTNtIZSQgyr7ChT6XrFVDqgXX/R25a9XiM1mrqOvss68DMwC6Pl0MvgIIw4GzsSiDxsZNv1myUNeSSgwXRmRn6CVBGE407EQXYXhR8pyt8NCwE//Kr9KGMrM+NRWTnIijG/pyLpjO8aNZChnbOoY= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(396003)(376002)(136003)(46966006)(36840700001)(70206006)(8676002)(8936002)(7696005)(6506007)(336012)(81166007)(356005)(82310400003)(4326008)(70586007)(2906002)(86362001)(33656002)(5660300002)(55016002)(53546011)(186003)(54906003)(110136005)(9686003)(316002)(26005)(52536014)(83380400001)(47076005)(36860700001)(82740400003)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 09:08:12.5150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51fb427e-fff2-462c-25b3-08d8fa6dd642 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB5225 Subject: Re: [dpdk-dev] [PATCH v3 3/3] test/power: add delay before checking cpuinfo cur freq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Liang Ma > Sent: Thursday, April 8, 2021 3:55 PM > To: Richael Zhuang > Cc: dev@dpdk.org; alan.carew@intel.com; stable@dpdk.org; David Hunt > ; Pablo de Lara ; > nd > Subject: Re: [dpdk-dev] [PATCH v3 3/3] test/power: add delay before > checking cpuinfo cur freq > > On Thu, Apr 08, 2021 at 05:16:34AM +0000, Richael Zhuang wrote: > > Hi Liang, > > Sorry that last email contains "confidential notice", so I resend it. > > > -----Original Message----- > > > From: Liang Ma > > > Sent: Wednesday, April 7, 2021 6:15 PM > > > To: Richael Zhuang > > > Cc: dev@dpdk.org; alan.carew@intel.com; stable@dpdk.org; David Hunt > > > ; Pablo de Lara > > > > > > Subject: Re: [dpdk-dev] [PATCH v3 3/3] test/power: add delay before > > > checking cpuinfo cur freq On Wed, Apr 07, 2021 at 03:46:36PM +0800, > > > Richael Zhuang wrote: > > > > Sleep for 1s before checking the newly updated value from > > > > "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because > > > > for some systems it may not be effective immediately. > > > > > > > > Fixes: ed7c51a6a680 ("app/test: vm power management") > > > > Cc: alan.carew@intel.com > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Richael Zhuang > > > > --- > > > > app/test/test_power_cpufreq.c | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/app/test/test_power_cpufreq.c > > > > b/app/test/test_power_cpufreq.c index cda74bd8a..7a93bc90a 100644 > > > > --- a/app/test/test_power_cpufreq.c > > > > +++ b/app/test/test_power_cpufreq.c > > > > @@ -47,6 +47,9 @@ static uint32_t > > > freqs[TEST_POWER_FREQS_NUM_MAX]; > > > > static int check_cur_freq(unsigned lcore_id, uint32_t idx) { > > > > +/* wait for the value to be updated */ sleep(1); > > > Hi Richael, > > > 1 second looks way too much for CPU frequency swap. > > > The unit should be ms in the worst case regardless the vendor, IMO. > > > Regards > > > Liang > > Thanks for review. Although I also think this time seems too long, it > > needs more than 700ms when I tested on our arm platform. > Hi Richael, > I will suggest you talk with arm cpufreq driver maintainer(kernel). > I don't think HW need 700ms to complete frequency changes. > cpufreq driver might do something here. intel_pstate driver set the > threshold as 10ms, according to the kernel source code. > Regards > Liang Hi Liang, Thanks, I will check this with the driver maintainer. Regards, Richael > > > > + > > > > #define TEST_POWER_CONVERT_TO_DECIMAL 10 FILE *f; char > > > > fullpath[PATH_MAX]; > > > > -- > > > > 2.20.1 > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.