From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDA64A0579; Thu, 8 Apr 2021 07:11:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6090B40698; Thu, 8 Apr 2021 07:11:06 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00053.outbound.protection.outlook.com [40.107.0.53]) by mails.dpdk.org (Postfix) with ESMTP id 750F440138; Thu, 8 Apr 2021 07:11:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NAEKr+6z9Qn8XAoFm4lYv12QAHnAghvtR9vIm7WRMeA=; b=YCzSxe0Q7vzaoW1FwIgifeX/HzyD+/pVIy8X/p6C7XbPygwVbHJOVvyFhF2dojKNpz9DXjRjHqoSevX3ttzs77zzWq5A3KPkp3zrqt4zrulkE/YYTP9ev7pfcojpFUy1O/2Bf/xxwy4UAsmbOgPach8IEFjgArI/eKb1IMA6gsY= Received: from MR1P264CA0019.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::6) by HE1PR0801MB2010.eurprd08.prod.outlook.com (2603:10a6:3:4b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32; Thu, 8 Apr 2021 05:11:04 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:501:2f:cafe::6) by MR1P264CA0019.outlook.office365.com (2603:10a6:501:2f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16 via Frontend Transport; Thu, 8 Apr 2021 05:11:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Thu, 8 Apr 2021 05:11:03 +0000 Received: ("Tessian outbound 82c2d58b350b:v90"); Thu, 08 Apr 2021 05:11:03 +0000 X-CR-MTA-TID: 64aa7808 Received: from 7ac4e18460cc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 08A10244-B574-4868-920E-931B52384225.1; Thu, 08 Apr 2021 05:10:57 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7ac4e18460cc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Apr 2021 05:10:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H8bLkUVWVAyi/0gkb7ftlJlZS2o+F9nkcJrasRRYGGYK1PO5PwKEmJqNNQL8dEn/Kr4RiePincjdn7DxQS1X7uPUlvqla2v3vLJheWapI5v16xK4zplCivm8FYI3UVrH7b7CUzJ91PrWBaXoB9WZX305Nqxlb9x4npBmwrqPayYRR/wM6EQVVcahc9GIHEnB6OhCL445L5duCgr4WufuGuJRdfZ/5pW9ZdKmpaESZcovohopaSBfAq1fUoygebOOq3NTB6V0Pz3+GGoUT28ckPaHBXbHY005hWCDEfVaXyuuIaW0pkaHPLuWg50fKk8+ouUuGZ8sCQEBJbP25Vlouw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NAEKr+6z9Qn8XAoFm4lYv12QAHnAghvtR9vIm7WRMeA=; b=Pv0lCch8IJgig2SQczWNHwrSeVoEnR1mxh6fs66be+e7PYjnoK8MNZllu93ylnnGMIgCJ9i+Yn6ueieuvq6GuLzJNxMXeyaghaitJGp7TA7wa2F/mlHv1BtjcFRZzTGl3oyDgCSxAJN8CveTWzu9V/dV89fMD2Jav7MKrdoYvVV39iRENcLsTpiTp/I08BQNlxz/H0Z5P/rklyz8aeW6nXBuunK9EHzBFwFWdXnLB6w3oyN/hbUo3DSS96F6i9bodKZdg26+6QnI1D81QRf91PZrWIq9We9DKmKGZX9HzMl2litl3lxbxu3pw1LAGL1A86xv3aq7bltvPpJqDM7DLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NAEKr+6z9Qn8XAoFm4lYv12QAHnAghvtR9vIm7WRMeA=; b=YCzSxe0Q7vzaoW1FwIgifeX/HzyD+/pVIy8X/p6C7XbPygwVbHJOVvyFhF2dojKNpz9DXjRjHqoSevX3ttzs77zzWq5A3KPkp3zrqt4zrulkE/YYTP9ev7pfcojpFUy1O/2Bf/xxwy4UAsmbOgPach8IEFjgArI/eKb1IMA6gsY= Received: from AM8PR08MB5796.eurprd08.prod.outlook.com (2603:10a6:20b:1d1::22) by AM0PR08MB4305.eurprd08.prod.outlook.com (2603:10a6:208:140::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Thu, 8 Apr 2021 05:10:56 +0000 Received: from AM8PR08MB5796.eurprd08.prod.outlook.com ([fe80::8dde:97cd:c482:ef11]) by AM8PR08MB5796.eurprd08.prod.outlook.com ([fe80::8dde:97cd:c482:ef11%4]) with mapi id 15.20.3999.032; Thu, 8 Apr 2021 05:10:56 +0000 From: Richael Zhuang To: Liang Ma CC: "dev@dpdk.org" , "alan.carew@intel.com" , "stable@dpdk.org" , David Hunt , Pablo de Lara , nd Thread-Topic: [dpdk-dev] [PATCH v3 3/3] test/power: add delay before checking cpuinfo cur freq Thread-Index: AQHXK4I/dLaITDxW90Om6eoWJSCbBKqo1p0AgAE8OUA= Date: Thu, 8 Apr 2021 05:10:56 +0000 Message-ID: References: <20210407023910.51052-1-richael.zhuang@arm.com> <20210407074636.26891-1-richael.zhuang@arm.com> <20210407074636.26891-4-richael.zhuang@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1850E631BF580B4F8ADCDD2F341A0AD9.0 x-checkrecipientchecked: true Authentication-Results-Original: liangbit.com; dkim=none (message not signed) header.d=none; liangbit.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.113] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: e7e0b554-032d-4630-055a-08d8fa4cb523 x-ms-traffictypediagnostic: AM0PR08MB4305:|HE1PR0801MB2010: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6430;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1DacKXY6TT9jQXsCw6hCWOvhV3fQc32ceVXfsyUqw7ZMVniQsHHWFiRxSNbaH3uTZzjsxY8DiNEjQWFpvS1GoS3bfVUqlBpEv2S7ob53l5ws2nsCQiQEJ7Lz4VCaxbYa2vpTQTTkf2do5s0FzOFOG0ggyvUTN6RAdr39KOJ9se6IrJ85jw4Ank72T7ZaNDs9i8TrefMbuHK0R2dLo4EE8yXgAqfniQbQWZFmDSUiis54cGUcb7sqf8t/tjAkjxvjPpqqORxEotyxfn+PQZdXqfY5JHmjYz+ml3dqyqcPtPnYhw7MPccCzEZziDesGjuC+KC9rrBxCzKcma2CA86JrNMd8hQVS3KL9n9TD7v4tt9KUyLmX2wi73sZM3aPl+gw68raBzjfWFa85o/JVHWsdhu7VasQjrLgoJRRcXtU9utLdZe8rthDBwVb2g2vkFIbUrrkm4p9hNp2Wz/v4H3JNwxcqnHWFIKHFsGQCVAUwT1zA0S98FxHSsB2q8G2wBpjwg/gb5ZEBJht+UV6Y9Irh/tbNB07Puw3uZzcZ4jnp20EB/YCVE0naAZVj5UIaendZm9YavR2bb+Ez6ormk11abMxOL13BydN+XQPJjNDaK6rOM1IrHu7By2+1W/Ep2ZtdBihCEuWVobwPOnJpaJkYTu/9l8RQKso+M4u2oWZBEY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR08MB5796.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(39860400002)(136003)(396003)(83380400001)(76116006)(66946007)(5660300002)(478600001)(55016002)(33656002)(66446008)(9686003)(38100700001)(52536014)(64756008)(66476007)(186003)(26005)(53546011)(8676002)(66556008)(2906002)(4326008)(6506007)(86362001)(71200400001)(7696005)(54906003)(8936002)(316002)(6916009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?R8x59jT0BIGvSWM6SO9pmITWv0k6v7Y9g538Tg5XpSmj2bVR5vkHCuDqWw5G?= =?us-ascii?Q?wqyYj8BLVx26qpdT3iC8BBnivfUxHpm2IOmG4d1JVew1DQIYCCN63J8Zjzmo?= =?us-ascii?Q?bLV92QPQIIqSPYtXDbovGX/py5jTcFPL2wvnp6B+2dqRv/nKRZyN3VPMdpPZ?= =?us-ascii?Q?fjGEYYA5MsezGWkWEskiV5IGfUmUb0CqniNHxkPVPKdzUqGNJuswpiOiEfzV?= =?us-ascii?Q?v57OgcPJ294M1DjeoJbgCwTNZp8uBRGrW+4V7PEBnmebmjf4rEz5t44SQIf5?= =?us-ascii?Q?znLvUcyi7qho020noSIva+AqRnwDbzxXx0ovU8/ULmipm/0Eul96lLExxC8/?= =?us-ascii?Q?J4PxmSC5tldW/3KCGtB75okQ6+7wDgbVmbMHppwG+WUsJp1Ja3as2DCxunnc?= =?us-ascii?Q?Y/jRaFFUrmUIFQON6uB4jCEjLVYEqv8rtAFGuLnFEx4z51iUeN/npyGGkkIg?= =?us-ascii?Q?r3PbgMDj4hLkDTqDcRzHAFl615/xX2VA7RVQkerZs6ahbpBKIvYOs6AxwmW6?= =?us-ascii?Q?XYy863EV/dMeasY//gLKKgsOuuiYfdOwivksAXaszRIf4yg3+MB+Nks7g78X?= =?us-ascii?Q?T4X9ZWvheHSy4n25fF677dVbsyCv4ik2myKveivDu9vB1VcenYEO1XZjn+bD?= =?us-ascii?Q?uuaovVfhmojMLi1JkXNidOi5AwlTYJRJyoFBwFQMoatJ55ohMWD1Ad99Bi+L?= =?us-ascii?Q?A8Bz5qyY9SXQCJy3iB7vyL3V2XlX78l60l3vPLI1ihJD+p4LIvF8auEo5jyW?= =?us-ascii?Q?XKlzTcx/xtAHD8JmgzlKy+n5hhJMmuV55t6/yDv9IUtzKhHZ543SSM5DiCuN?= =?us-ascii?Q?Zo1c4OVRcIrKOKxTFAWySA4JeHdDWqy7xDyRkKgyxlqCMnhTvdPmBmnENFUB?= =?us-ascii?Q?WcIevWsBoGhqaF7lUMH0NDWu6aHU2jv6yJA8sLuhyxtTGOsQm8MpcXQ5qooH?= =?us-ascii?Q?YJiuWfJc56Law4buALYLJ7KTEYwot20mzfC1yQHgjJnqLFe76h90qNHtaaYA?= =?us-ascii?Q?FJhfcmRdd24RXyvFHDkqjA0NiNLtRF48wiCQoZg233fKvOZboU7qSy87EPZ+?= =?us-ascii?Q?zsKyvqhYWpJ80WQukUdHqejzVk1UhKGv0X1YYBeBMVrbtUBsn0dz2W3/4q0P?= =?us-ascii?Q?guhx140PN7lLaW+U5yXCvQ+i3rb/nK1SAylyrjBQ6XnXgMUhlyza372q0A7s?= =?us-ascii?Q?9iSNXeYMVvuLZtBz60ugjpenS/mvBZsMuD+1ucslFQAdrNF46cBfZ3Thq/1Z?= =?us-ascii?Q?3kIJBEZhptT8qLuiONY57pYbmvjYmj/3urk9RIzNudBXE4cpNV8d34Co9ech?= =?us-ascii?Q?DzBmbbdt7VQJINrP8ZQlg7u9?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4305 Original-Authentication-Results: liangbit.com; dkim=none (message not signed) header.d=none; liangbit.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 47468cc9-5edd-42f3-0548-08d8fa4cb0cb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lalfpsgYG/IJZ6SVqcD0MjhaxLFC9AHEEansZKSUzMeaINrjcZR12G44MUlvRGjDy4EFUhNkidAnesh3B9+KPM4NWyt2aJ6s4tqECff5W7PX92xPmL0mY/tfFoGg9TdbTkn9PbIpljWWju8MB0V1Yk+jExlwOBQAdn7rii4zjxQFhDUA7KaZ+CgKx1LwuVG6CowOaIk1zBjm5ByeytCxCHZumihtK97yKVeiwiBQotkHJblKMMy3vF4JWsBWlpuB1TbBBTEF2C50PckoDEboSpfnjJprV/d8qac1uCTACWBW80ggzo0e89MXiiRPju3FxAreKLUSJD0XW7WKcWB6qv0l/y3MjXF6KCxTVOmVHQwW3drPwdDjvmzj2xmhfimBgwWo0okDuMQesMGWYSzaveVDWEU2oJ3B/eHFmy+wvraTbdxltFpHUEnLh2krUXVKwRYTY5KGwQH8jmZLFY73B+IUysR4k8FOM0z1Rbzcgaw2aw2HA5SMqJQ3FV7CiCxgtlvdG0cobS5c1Rwbw5GLh+sWafBlXJdZ2doXG1DXDtH8U9fGSWJElt8dRYpCDlrOZ0PhzMQZhgbZh6gmeg2Cy4a+dysdkRQHzYKVZp1w0oeHQ0/U6QAKmfYqE29jU8hcn7n/hGdmX0ReUom0uo+dPq7pgtLrNpr8AK+GWI8A9K8= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(39860400002)(396003)(376002)(346002)(36840700001)(46966006)(81166007)(47076005)(450100002)(4326008)(86362001)(82740400003)(33656002)(8676002)(8936002)(356005)(6862004)(83380400001)(52536014)(82310400003)(6506007)(53546011)(26005)(54906003)(186003)(7696005)(36860700001)(5660300002)(316002)(9686003)(70206006)(70586007)(478600001)(336012)(55016002)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 05:11:03.4647 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7e0b554-032d-4630-055a-08d8fa4cb523 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2010 Subject: Re: [dpdk-dev] [PATCH v3 3/3] test/power: add delay before checking cpuinfo cur freq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Liang, > -----Original Message----- > From: Liang Ma > Sent: Wednesday, April 7, 2021 6:15 PM > To: Richael Zhuang > Cc: dev@dpdk.org; alan.carew@intel.com; stable@dpdk.org; David Hunt > ; Pablo de Lara > Subject: Re: [dpdk-dev] [PATCH v3 3/3] test/power: add delay before > checking cpuinfo cur freq > > On Wed, Apr 07, 2021 at 03:46:36PM +0800, Richael Zhuang wrote: > > Sleep for 1s before checking the newly updated value from > > "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because for > > some systems it may not be effective immediately. > > > > Fixes: ed7c51a6a680 ("app/test: vm power management") > > Cc: alan.carew@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Richael Zhuang > > --- > > app/test/test_power_cpufreq.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/app/test/test_power_cpufreq.c > > b/app/test/test_power_cpufreq.c index cda74bd8a..7a93bc90a 100644 > > --- a/app/test/test_power_cpufreq.c > > +++ b/app/test/test_power_cpufreq.c > > @@ -47,6 +47,9 @@ static uint32_t > freqs[TEST_POWER_FREQS_NUM_MAX]; > > static int check_cur_freq(unsigned lcore_id, uint32_t idx) { > > +/* wait for the value to be updated */ > > +sleep(1); > Hi Richael, > 1 second looks way too much for CPU frequency swap. > The unit should be ms in the worst case regardless the vendor, IMO. > Regards > Liang Thanks for review. Although I also think this time seems too long, it need= s more than 700ms when I tested on our arm platform. > > + > > #define TEST_POWER_CONVERT_TO_DECIMAL 10 > > FILE *f; > > char fullpath[PATH_MAX]; > > -- > > 2.20.1 > > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.