From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Joyce Kong <Joyce.Kong@arm.com>,
Robert Sanford <rsanford@akamai.com>,
Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Joyce Kong <Joyce.Kong@arm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>, nd <nd@arm.com>
Subject: RE: [PATCH v2 03/12] test/timer: use compiler atomic builtins for sync
Date: Tue, 16 Nov 2021 19:52:18 +0000 [thread overview]
Message-ID: <AM8PR08MB581065189305F1CF8EF88A8F98999@AM8PR08MB5810.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20211116094205.750359-4-joyce.kong@arm.com>
<snip>
>
> Convert rte_atomic usages to compiler atomic built-ins for lcore_state and
> collisions sync.
>
> Also, move 'main_init_workers' outside of 'timer_stress2_main_loop' to
> guarantee lcore_state initialized correctly before the threads launched.
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> app/test/test_timer.c | 30 +++++++++++++-----------------
> app/test/test_timer_secondary.c | 1 -
> 2 files changed, 13 insertions(+), 18 deletions(-)
>
> diff --git a/app/test/test_timer.c b/app/test/test_timer.c index
> a10b2fe9da..c97e5c891c 100644
> --- a/app/test/test_timer.c
> +++ b/app/test/test_timer.c
> @@ -102,7 +102,6 @@
> #include <rte_eal.h>
> #include <rte_per_lcore.h>
> #include <rte_lcore.h>
> -#include <rte_atomic.h>
> #include <rte_timer.h>
> #include <rte_random.h>
> #include <rte_malloc.h>
> @@ -203,7 +202,7 @@ timer_stress_main_loop(__rte_unused void *arg)
>
> /* Need to synchronize worker lcores through multiple steps. */ enum {
> WORKER_WAITING = 1, WORKER_RUN_SIGNAL, WORKER_RUNNING,
> WORKER_FINISHED }; -static rte_atomic16_t lcore_state[RTE_MAX_LCORE];
> +static uint16_t lcore_state[RTE_MAX_LCORE];
>
> static void
> main_init_workers(void)
> @@ -211,7 +210,7 @@ main_init_workers(void)
> unsigned i;
>
> RTE_LCORE_FOREACH_WORKER(i) {
> - rte_atomic16_set(&lcore_state[i], WORKER_WAITING);
> + __atomic_store_n(&lcore_state[i], WORKER_WAITING,
> __ATOMIC_RELAXED);
> }
> }
>
> @@ -221,11 +220,10 @@ main_start_workers(void)
> unsigned i;
>
> RTE_LCORE_FOREACH_WORKER(i) {
> - rte_atomic16_set(&lcore_state[i], WORKER_RUN_SIGNAL);
> + __atomic_store_n(&lcore_state[i], WORKER_RUN_SIGNAL,
> +__ATOMIC_RELEASE);
> }
> RTE_LCORE_FOREACH_WORKER(i) {
> - while (rte_atomic16_read(&lcore_state[i]) !=
> WORKER_RUNNING)
> - rte_pause();
> + rte_wait_until_equal_16(&lcore_state[i], WORKER_RUNNING,
> +__ATOMIC_ACQUIRE);
> }
> }
>
> @@ -235,8 +233,7 @@ main_wait_for_workers(void)
> unsigned i;
>
> RTE_LCORE_FOREACH_WORKER(i) {
> - while (rte_atomic16_read(&lcore_state[i]) !=
> WORKER_FINISHED)
> - rte_pause();
> + rte_wait_until_equal_16(&lcore_state[i], WORKER_FINISHED,
> +__ATOMIC_ACQUIRE);
> }
> }
>
> @@ -245,9 +242,8 @@ worker_wait_to_start(void) {
> unsigned lcore_id = rte_lcore_id();
>
> - while (rte_atomic16_read(&lcore_state[lcore_id]) !=
> WORKER_RUN_SIGNAL)
> - rte_pause();
> - rte_atomic16_set(&lcore_state[lcore_id], WORKER_RUNNING);
> + rte_wait_until_equal_16(&lcore_state[lcore_id],
> WORKER_RUN_SIGNAL, __ATOMIC_ACQUIRE);
> + __atomic_store_n(&lcore_state[lcore_id], WORKER_RUNNING,
> +__ATOMIC_RELEASE);
> }
>
> static void
> @@ -255,7 +251,7 @@ worker_finish(void)
> {
> unsigned lcore_id = rte_lcore_id();
>
> - rte_atomic16_set(&lcore_state[lcore_id], WORKER_FINISHED);
> + __atomic_store_n(&lcore_state[lcore_id], WORKER_FINISHED,
> +__ATOMIC_RELEASE);
> }
>
>
> @@ -281,13 +277,12 @@ timer_stress2_main_loop(__rte_unused void *arg)
> unsigned int lcore_id = rte_lcore_id();
> unsigned int main_lcore = rte_get_main_lcore();
> int32_t my_collisions = 0;
> - static rte_atomic32_t collisions;
> + static uint32_t collisions;
>
> if (lcore_id == main_lcore) {
> cb_count = 0;
> test_failed = 0;
> - rte_atomic32_set(&collisions, 0);
> - main_init_workers();
> + __atomic_store_n(&collisions, 0, __ATOMIC_RELAXED);
> timers = rte_malloc(NULL, sizeof(*timers) *
> NB_STRESS2_TIMERS, 0);
> if (timers == NULL) {
> printf("Test Failed\n");
> @@ -315,7 +310,7 @@ timer_stress2_main_loop(__rte_unused void *arg)
> my_collisions++;
> }
> if (my_collisions != 0)
> - rte_atomic32_add(&collisions, my_collisions);
> + __atomic_fetch_add(&collisions, my_collisions,
> __ATOMIC_RELAXED);
>
> /* wait long enough for timers to expire */
> rte_delay_ms(100);
> @@ -329,7 +324,7 @@ timer_stress2_main_loop(__rte_unused void *arg)
>
> /* now check that we get the right number of callbacks */
> if (lcore_id == main_lcore) {
> - my_collisions = rte_atomic32_read(&collisions);
> + my_collisions = __atomic_load_n(&collisions,
> __ATOMIC_RELAXED);
> if (my_collisions != 0)
> printf("- %d timer reset collisions (OK)\n",
> my_collisions);
> rte_timer_manage();
> @@ -573,6 +568,7 @@ test_timer(void)
> /* run a second, slightly different set of stress tests */
> printf("\nStart timer stress tests 2\n");
> test_failed = 0;
> + main_init_workers();
> rte_eal_mp_remote_launch(timer_stress2_main_loop, NULL,
> CALL_MAIN);
> rte_eal_mp_wait_lcore();
> if (test_failed)
> diff --git a/app/test/test_timer_secondary.c b/app/test/test_timer_secondary.c
> index 16a9f1878b..5795c97f07 100644
> --- a/app/test/test_timer_secondary.c
> +++ b/app/test/test_timer_secondary.c
> @@ -9,7 +9,6 @@
> #include <rte_lcore.h>
> #include <rte_debug.h>
> #include <rte_memzone.h>
> -#include <rte_atomic.h>
> #include <rte_timer.h>
> #include <rte_cycles.h>
> #include <rte_mempool.h>
> --
> 2.25.1
next prev parent reply other threads:[~2021-11-16 19:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 9:41 [PATCH v2 00/12] use compiler atomic builtins for app modules Joyce Kong
2021-11-16 9:41 ` [PATCH v2 01/12] test/pmd_perf: use compiler atomic builtins for polling sync Joyce Kong
2021-11-16 21:30 ` Honnappa Nagarahalli
2021-11-16 9:41 ` [PATCH v2 02/12] test/ring_perf: use compiler atomic builtins for lcores sync Joyce Kong
2021-11-16 9:41 ` [PATCH v2 03/12] test/timer: use compiler atomic builtins for sync Joyce Kong
2021-11-16 19:52 ` Honnappa Nagarahalli [this message]
2021-11-16 20:20 ` David Marchand
2021-11-16 21:21 ` Honnappa Nagarahalli
2021-11-17 9:29 ` David Marchand
2021-11-16 9:41 ` [PATCH v2 04/12] test/stack_perf: use compiler atomics for lcore sync Joyce Kong
2021-11-16 9:41 ` [PATCH v2 05/12] test/bpf: use compiler atomics for calculation Joyce Kong
2021-11-16 9:41 ` [PATCH v2 06/12] test/func_reentrancy: use compiler atomics for data sync Joyce Kong
2021-11-16 9:42 ` [PATCH v2 07/12] app/eventdev: use compiler atomics for shared " Joyce Kong
2021-11-16 9:42 ` [PATCH v2 08/12] app/crypto: use compiler atomic builtins for display sync Joyce Kong
2021-11-16 9:42 ` [PATCH v2 09/12] app/compress: " Joyce Kong
2021-11-16 20:15 ` Honnappa Nagarahalli
2021-11-16 9:42 ` [PATCH v2 10/12] app/testpmd: remove atomic operations for port status Joyce Kong
2021-11-16 21:34 ` Honnappa Nagarahalli
2021-11-16 9:42 ` [PATCH v2 11/12] app/bbdev: use compiler atomics for shared data sync Joyce Kong
2021-11-16 9:42 ` [PATCH v2 12/12] app: remove unnecessary include of atomic header file Joyce Kong
2021-11-16 20:23 ` David Marchand
2021-11-17 7:05 ` Joyce Kong
2021-11-17 8:21 ` [PATCH v3 00/12] use compiler atomic builtins for app modules Joyce Kong
2021-11-17 8:21 ` [PATCH v3 01/12] test/pmd_perf: use compiler atomic builtins for polling sync Joyce Kong
2021-11-17 8:21 ` [PATCH v3 02/12] test/ring_perf: use compiler atomic builtins for lcores sync Joyce Kong
2021-11-17 8:21 ` [PATCH v3 03/12] test/timer: use compiler atomic builtins for sync Joyce Kong
2021-11-17 8:21 ` [PATCH v3 04/12] test/stack_perf: use compiler atomics for lcore sync Joyce Kong
2021-11-17 8:21 ` [PATCH v3 05/12] test/bpf: use compiler atomics for calculation Joyce Kong
2021-11-17 8:21 ` [PATCH v3 06/12] test/func_reentrancy: use compiler atomics for data sync Joyce Kong
2021-11-17 8:21 ` [PATCH v3 07/12] app/eventdev: use compiler atomics for shared " Joyce Kong
2021-11-17 8:21 ` [PATCH v3 08/12] app/crypto: use compiler atomic builtins for display sync Joyce Kong
2021-11-17 8:21 ` [PATCH v3 09/12] app/compress: " Joyce Kong
2021-11-17 8:21 ` [PATCH v3 10/12] app/testpmd: remove atomic operations for port status Joyce Kong
2021-11-17 8:21 ` [PATCH v3 11/12] app/bbdev: use compiler atomics for shared data sync Joyce Kong
2021-11-17 8:22 ` [PATCH v3 12/12] app: remove unnecessary include of atomic header file Joyce Kong
2021-11-17 10:02 ` [PATCH v3 00/12] use compiler atomic builtins for app modules David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM8PR08MB581065189305F1CF8EF88A8F98999@AM8PR08MB5810.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=nd@arm.com \
--cc=rsanford@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).