From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D14543AEB; Mon, 12 Feb 2024 09:38:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8102240274; Mon, 12 Feb 2024 09:38:41 +0100 (CET) Received: from egress-ip11a.ess.de.barracuda.com (egress-ip11a.ess.de.barracuda.com [18.184.203.234]) by mails.dpdk.org (Postfix) with ESMTP id F1FAC40151 for ; Mon, 12 Feb 2024 09:38:39 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2051.outbound.protection.outlook.com [104.47.2.51]) by mx-outbound9-178.eu-central-1a.ess.aws.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 12 Feb 2024 08:37:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MzcIj+JrUUHeTrZGimQdecronhAQlNQAHUNvfHu903H1cvI030Ye5HygJo6aC8OF0+Eave5Ui74ZVH7hvrPKS5G/PqCoP1vmgNT3sV6XQRGhoo7Vxp0FVp/5NnhN99kgJHmhrAAmBKqZX0wbXNLX2laSnrGGXx30rZLep0U3C9F9FEcIR7uArF65t2nDKT0yw4LahZ55MCJf3/HoY0Wbc2HHusQdxZ8t5AHtnHiX4JzgJr9j4/Zk7kcG1aQIMT9S7f1a17JUda3gmWbc+KnzLyARJ94p5Oi+jczhUsUzKQr8By+agcqWIV1XRiDB5SLoMZSF+/U+TMDtcRdtQT721Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jrGja0Rs9xKVT6Bex4Rqsrfvsz1+zRjVdtVDFaLJ48w=; b=fwtzNOZXl7b7+XudEtJJMr91DWS2KSWHLv93wWiIRoewBnRQ1ghPJ660lYYvRMNpK97Jp4ZZ5A2u3ineD6Kdjzv/R2ak+lF07OCL7a3cs8x6p198LUW9rjNn6BvOhH783s04SSNv+WtCw51PG0Fdfz1XeH4FYJLaUItdXtRatuvcZSxJerCvW9BSzDIpIJvfJ5+sAcVbduJBjZrUVPIi3PYExrHlVq/ifwtPDu7JITnwUWC91sEvORmKy7Nz56dbRsjAW71NI+S67blDd20su2/b+Sco5S5AX3qNGB2wDUcWswCiYV8HhEYsS6MFomuOsx2QhVi07OQaQAJn9qHrZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=napatech.com; dmarc=pass action=none header.from=napatech.com; dkim=pass header.d=napatech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jrGja0Rs9xKVT6Bex4Rqsrfvsz1+zRjVdtVDFaLJ48w=; b=b1f8qBfirvpnAzm1fAVe+e4tssn48B6exNS0xvjOAEAd6XhWtMJR4W74cSbQOA2c0STHD+6LpFFiCdZkxBR/Wxb2/L9mYBHDxC4yVLVziSMDdsp9urwJco8TtXNMpoUberlKpUX7McGo3Lo+vBkHD9WkeWg3UR6bd5bvSPaiQvU= Received: from AM9P190MB1057.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:270::15) by AS1P190MB1704.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:4aa::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.33; Mon, 12 Feb 2024 08:37:57 +0000 Received: from AM9P190MB1057.EURP190.PROD.OUTLOOK.COM ([fe80::9e34:cf19:532a:dad2]) by AM9P190MB1057.EURP190.PROD.OUTLOOK.COM ([fe80::9e34:cf19:532a:dad2%3]) with mapi id 15.20.7270.033; Mon, 12 Feb 2024 08:37:57 +0000 From: Oleksandr Kolomeiets To: Dariusz Sosnowski , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Mykola Kostenok , Christian Koue Muf CC: "aman.deep.singh@intel.com" , "yuying.zhang@intel.com" , "dev@dpdk.org" , Ori Kam Subject: Re: [PATCH v2] app/testpmd: support updating flow rule actions Thread-Topic: [PATCH v2] app/testpmd: support updating flow rule actions Thread-Index: AQHaVb5JquFkZi7DmEu9PWv1fsBlBLD8JLMAgApJR70= Date: Mon, 12 Feb 2024 08:37:56 +0000 Message-ID: References: <20240126132142.2649250-1-okl-plv@napatech.com> <20240201095907.3564286-1-okl-plv@napatech.com> <2800280.mvXUDI8C0e@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=napatech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM9P190MB1057:EE_|AS1P190MB1704:EE_ x-ms-office365-filtering-correlation-id: 641f3b93-afe0-4242-23c2-08dc2ba5e9aa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: odmv2QVs+6Q6kaSzfIffFHySLuurN3JDfT0L/KLUUyv5abD4A+LXazVRWXnw0wYwBOiOUPl8Wzs5xK6RM0l/ktSYy9qQwsbrrHf89BQ6CZgcflVBN4kvUU+yk1wBf/XLRndYRqnuBE4KLIplSae98Xheco1sFxki8Bz8R38gZBbeu9Q/Vu53JTqImWpif1gGTyzMCSiBvl5YWxnqaxPFA3SzIaOnfc5QgVwqe8EsKZsSCoBAjLapD05wKQ42oGD7SdJWfinqnxSbwTPsMQCw2P57exOAc2JOvHSl9EkmNNjjDJMlQReej7lu6NmZ9kx3NB2b3VsqYI2ZvGf+0DSlZY/TSJyVeyzAACgK/tWL4YzQvwMRSS5CazCUAXaNFpSE5tRSMnx07n7pXOOzCLrib72VqBim9NBmmfYPM8g0J8B1LdP9/+J0ZIUB5SvYc/eXlKx4K74zAj+0ZSVcauSGj2ToK019hHZ5h7Dt7SfIEfEtf0A2YkOLNWim2p2VVlDsdoFYMvMriJevfmBgI7CyuptU0mrSIesgiHWXHrwGqYngXGqMSFhwlBV7WICnHGUHTvdter2vw/00zPMREP+vUuB0IxnpfTuG3tZcdTjsWbdBOUQfnN0bA1YRIlax0j6F x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9P190MB1057.EURP190.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(136003)(396003)(366004)(39830400003)(230273577357003)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(55016003)(91956017)(54906003)(76116006)(66946007)(316002)(110136005)(6636002)(66556008)(41300700001)(66476007)(38100700002)(66446008)(64756008)(38070700009)(8936002)(8676002)(2906002)(19627405001)(4326008)(83380400001)(5660300002)(7696005)(9686003)(71200400001)(478600001)(6506007)(86362001)(26005)(122000001)(33656002)(52536014)(107886003)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QaiaTRqItDh9Z8/aRbg4slPPsganU48NQRymjvtD8JLar56umRzm/WwJiEtI?= =?us-ascii?Q?kGBFsBASwsZiQBauUcbkRoDgJ6d5OmsT4SUc1y8pvMe3m7tEFNoyFCNVaysx?= =?us-ascii?Q?/LSozCGO3Kql+ETL7OsnC3ROtAlzGKGVIFnb2THG+v9YYsZ8BQCveU3KGUrF?= =?us-ascii?Q?eEnQitL0C8hW/SllrU5gEjIMiFMoNNrEiv+VbEXR9WQN7m57jLou4E3Pwo3d?= =?us-ascii?Q?1eo7b9SE4S1pKF8RMB6P+dAAX67+TlH+0ySG3u39J4ccN0TBORPO4zJXKNEq?= =?us-ascii?Q?6gmlIngMoG8QrBdmx/XxCG+ppUG4yLecsuxDBnJWVrZP4j5vr8xMp7+kM5XM?= =?us-ascii?Q?vVAN0hm7ndiBfm30TQvRacNvLE/nym9/bQtTswgYpRgYagNE/EKkGEl7IQX3?= =?us-ascii?Q?Wpr3g+COLifBGUEzL30t1jiUTMCh2JZWq7kuvARlx1YLt1SyBf6ouq8t/Mcn?= =?us-ascii?Q?nuUNZnuWfZ2Hm11pjpPY4xHTwuKFnTiuPqE8vlKqlcjm5uFvD9CvfSYiHZT6?= =?us-ascii?Q?TY6o1RHWtjb7d9461pSYlaWcRI/H+o0Fovpc5URyDXoymjBWTYNY9BjqHePz?= =?us-ascii?Q?uRmhTHs5lzu2wv/FJRf/Mwqt+lCYHD2p6zrgkLp6Ccs/PpmOJpgYc29o0zQR?= =?us-ascii?Q?KaMtnXtPITN9RVtZ3IzoXhsZznAVw+X/AjrgC7Rsqz+2nHQ64bkwRYOVgazi?= =?us-ascii?Q?X8VJvAhiF+EhZjJJVJ2uSIoSvAER12ctTO7MXgFZpMawSP03ocFsSzqgbSbu?= =?us-ascii?Q?59hUGXNO1w7L4VkxeYXEWqDMiiLC1NYcWyxh+bwSEUfCw623J0QQ7flusuta?= =?us-ascii?Q?MQj0B1xV3LCTrRDMbUpkpGgWqpQoORv5jA13ciYsrBobdwbGC5cXmCddCuRt?= =?us-ascii?Q?dyWmyVF0z3kiNFVU/xDgW2ExwaLpNAvhE+8UBoqAYuTxTRb0b1sUEs7DaTjo?= =?us-ascii?Q?NkPaGUhdf6vGLaSj93HQzPVucwZcDrqzhgyPsuaiXGhCtwVv/Rl74p47gPmX?= =?us-ascii?Q?q/OXxsi5sRRJAlBL1dLfGKm3ElPU2zLVuoiTb2Bntd9g8PTjZnMNfWv+zV5E?= =?us-ascii?Q?4m1VnZea/BM24528o2+W4PzI3sP5kGE/3teG7QrjcnXoV8PkrmqjAvHpZSB0?= =?us-ascii?Q?y+7xPG4i8x8EWfjXSPug8WntVbhRlfftvBfuz/cg6k2tkfoIgGxph57D8T64?= =?us-ascii?Q?ypkL+TdrkGXptCsV1wEi/NckKosCqZphUDucvDU0o+viSUByyBmFrQz86RPe?= =?us-ascii?Q?ZPaeWdkdCy8RB7zJV4ZK2rysPJWdHLGODp3hkvj+2p31Qu5ATjIHz5TqFTbj?= =?us-ascii?Q?A7UBSmfzWGVaG6177Y9vS0zyAqrYJLk1I4g5NX8/kRkL0UGgYhhy0uTK6U9t?= =?us-ascii?Q?kzrstzG7C2AnUvc/VmjPHBRtsr12K3kxL6JXvAki83/n1hF83CIx4kgFxXt3?= =?us-ascii?Q?KCSuKXE0fNYdwD3nKCgo7rEZmbTg7qE0yJpnDtxy65pS6XMfyU1G3w0AKcVv?= =?us-ascii?Q?YkJHRdKZrlY0lKq378X5PClY+Q5X8fS/HiD48XTJR+wBX2/yYXE60CR/bEUO?= =?us-ascii?Q?DSwAJnmDhm0j1TZQXP1M/pTrx5723mdEXEw0DBd7?= Content-Type: multipart/alternative; boundary="_000_AM9P190MB10575CDF082E473E92B1C90E9E482AM9P190MB1057EURP_" MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CyuygHXwzonZIafnE+E1blMG3c7bTtCEmQW0J5uMzKJZVcmJWLEyt8/kOfC3edTTNQ7deIniC98iUmEOE1Oo54shReeR/F3hpWxxoDBccrggH62Ff/i0pHQN+cpzkzrd63BB0Krvv0Ohqz3fvb2qj9LSo/y72d68HelLcGJKmkKVeAilXoqCnHxE+cbmWLpXZxfiW50gchbN2Tcj3tviJWbzIC0qX8IJYRmD3BAjH7P10DvnM1YEAA0Oia0VtvDsrxUL4ddzKXZwXMIbgHjDS2iw5euZdoEUFCGP/3EkcuAn7ZrxwcE50xAa+da/GkgiWkaw1XOlU0o4I4BzguwMGuecocnVzY4al2MfWc5e8QHuJQjjUItEsT5uVSq+aF5dJh3Mp+IaZyOAkr7nEhqdAxLhsBGjbskOlP2DL0gRusVAOHZPd+7ZPDHZYfsUh4qRpkb4PvHZzbRUh40SPLWRYffkOjsbe1RRM46weDS6uD31mpjhRN9zBTNqs5V4cnjSZvGKFjJnPDlbBalB2cbA3phIqTEbMGpPoYc590H831miw/YL6IEK2h7GswGx8sF/2m2YbxjUd1mfQIvq6PZ8REuKJiFUpkXEq6G1pvV0b5Uu8hZ7ezXv2cz3G6RuZZ32X+wPVlI3lcKQtNdPsfvDCw== X-OriginatorOrg: napatech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9P190MB1057.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 641f3b93-afe0-4242-23c2-08dc2ba5e9aa X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2024 08:37:56.9550 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c4540d0b-728a-4233-9da5-9ea30c7ec3ed X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2XCArt/8D2mXnI3LtrGv+lOc0inAAVARnaZLIvpjqFkXXI7rm2ZRw88WdstTk7uStGIOEroSMy2sEFKGxv0wBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1P190MB1704 X-BESS-ID: 1707727079-302482-12655-1215-1 X-BESS-VER: 2019.1_20240210.0037 X-BESS-Apparent-Source-IP: 104.47.2.51 X-BESS-Parts: H4sIAAAAAAACAzXLMQrDMAyF4btoziBLlizlKqWDbSyylA71UCi5ez0ky+Pnwf f4wfhO2GGu3eD9gZ0Y86pjncgtjLqHVDTH1pmqd2JxNZQ84Nxuf8zX5VmLXD6NCMtBCV P2FHUUElXlVrIxk8L5/ANf+mGUgQAAAA== X-BESS-BRTS-Status: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_AM9P190MB10575CDF082E473E92B1C90E9E482AM9P190MB1057EURP_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you for the review. Indeed, shortening the command from "flow actions_update" to "flow update" = seems more natural. However, note that the command updates only the actions of a flow rule and = leaves all other parameters unchanged. My concern is that in the future there can be some "flow pattern_update" co= mmand, thus making "flow update" command ambiguous. Also, the name is consistent with the underlying rte_flow_actions_update() = function. With that in mind, please clarify if the name should still be changed. ________________________________ From: Dariusz Sosnowski Sent: Monday, February 5, 2024 9:18 PM To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; Mykola Ko= stenok ; Christian Koue Muf ; Oleks= andr Kolomeiets Cc: aman.deep.singh@intel.com ; yuying.zhang@int= el.com ; dev@dpdk.org ; Ori Kam Subject: RE: [PATCH v2] app/testpmd: support updating flow rule actions > -----Original Message----- > From: Thomas Monjalon > Sent: Friday, February 2, 2024 10:55 > To: mko-plv@napatech.com; ckm@napatech.com; Oleksandr Kolomeiets > > Cc: aman.deep.singh@intel.com; yuying.zhang@intel.com; dev@dpdk.org; > Ori Kam ; Dariusz Sosnowski > Subject: Re: [PATCH v2] app/testpmd: support updating flow rule actions > > 01/02/2024 10:59, Oleksandr Kolomeiets: > > "flow actions_update" updates a flow rule specified by a rule ID with > > a new action list by making a call to "rte_flow_actions_update()": > > > > flow actions_update {port_id} {rule_id} > > actions {action} [/ {action} [...]] / end [user_id] > > > > Creating, updating and destroying a flow rule: > > > > testpmd> flow create 0 group 1 pattern eth / end actions drop / end > > Flow rule #0 created > > testpmd> flow actions_update 0 0 actions queue index 1 / end > > Flow rule #0 updated with new actions > > testpmd> flow destroy 0 rule 0 > > Flow rule #0 destroyed > > Why not a simple "flow update" command name? +1. This would also make it consistent with async version of this command -= "flow queue {port_id} update ...". --_000_AM9P190MB10575CDF082E473E92B1C90E9E482AM9P190MB1057EURP_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Thank you for the review.
Indeed, shortening the command from "flow actions_update" to &quo= t;flow update" seems more natural.
However, note that the command updates only the actions of a flow rule and = leaves all other parameters unchanged.
My concern is that in the future there can be some "flow pattern_updat= e" command, thus making "flow update" command ambiguous.
Also, the name is consistent with the underlying rte_flow_actions_update() = function.
With that in mind, please clarify if the name should still be changed.
From: Dariusz Sosnowski <= ;dsosnowski@nvidia.com>
Sent: Monday, February 5, 2024 9:18 PM
To: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net&g= t;; Mykola Kostenok <mko-plv@napatech.com>; Christian Koue Muf <ck= m@napatech.com>; Oleksandr Kolomeiets <okl-plv@napatech.com>
Cc: aman.deep.singh@intel.com <aman.deep.singh@intel.com>; yuy= ing.zhang@intel.com <yuying.zhang@intel.com>; dev@dpdk.org <dev@dp= dk.org>; Ori Kam <orika@nvidia.com>
Subject: RE: [PATCH v2] app/testpmd: support updating flow rule acti= ons
 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, February 2, 2024 10:55
> To: mko-plv@napatech.com; ckm@napatech.com; Oleksandr Kolomeiets
> <okl-plv@napatech.com>
> Cc: aman.deep.singh@intel.com; yuying.zhang@intel.com; dev@dpdk.org; > Ori Kam <orika@nvidia.com>; Dariusz Sosnowski <dsosnowski@nvi= dia.com>
> Subject: Re: [PATCH v2] app/testpmd: support updating flow rule action= s
>
> 01/02/2024 10:59, Oleksandr Kolomeiets:
> > "flow actions_update" updates a flow rule specified by = a rule ID with
> > a new action list by making a call to "rte_flow_actions_upda= te()":
> >
> >     flow actions_update {port_id} {rule_id} > >         actions {action} = [/ {action} [...]] / end [user_id]
> >
> > Creating, updating and destroying a flow rule:
> >
> >     testpmd> flow create 0 group 1 pattern= eth / end actions drop / end
> >     Flow rule #0 created
> >     testpmd> flow actions_update 0 0 actio= ns queue index 1 / end
> >     Flow rule #0 updated with new actions
> >     testpmd> flow destroy 0 rule 0
> >     Flow rule #0 destroyed
>
> Why not a simple "flow update" command name?

+1. This would also make it consistent with async version of this command -= "flow queue {port_id} update ...".
--_000_AM9P190MB10575CDF082E473E92B1C90E9E482AM9P190MB1057EURP_--