From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 136CCA054A; Wed, 7 Sep 2022 08:06:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03139400D6; Wed, 7 Sep 2022 08:06:50 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70045.outbound.protection.outlook.com [40.107.7.45]) by mails.dpdk.org (Postfix) with ESMTP id 95DE940042 for ; Wed, 7 Sep 2022 08:06:48 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BZ2k/Ij8Fxo4aTgXDzcOpx/NySmYby5ab8Al4qdZ6vZznZKIlCV8hq0A/b4keWxw+RNKPJZYHCEckyWk2a50n0tbuCv8NXqT2k6W8QnynoStm7sgeQ5EjOcNOrVM/iD+Xv2c2oEH2HlD2EdjyKHRsuCe6VjmxM1LElv5cTCJ0DSgoYqYhZh/fbYt7Q0OYDZ5gTw6G4KLLTZmOYExJR1ALLNXdpAf9fs4l23SAuTbj6OQF7rAK8i6ZinuSxa3XrIUpt2UFqEITQIb5wZPrYmapOs+VLXwfAA0th5/WbI45s7oDZQNpPbazTaaURSGYmWyjL7dlbH9/D86akfolTQ0gg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QA+xhcy55W1cPbYaTbK/yqTyHVZnEsdndyYhBDOIt5U=; b=XpRHDiq35TlMndABzSyPBvd/lELjEDh8prLG9XlSaFWZ1aMQX/NF2Eo2iOz0lcaW7BpXMwsyosbcvOYzc5RNjEYCjRubdtqgrF4jjzwa1kiPBYMtCjjkcis4jCevGE+gLJTC4fw9JxU+Ed0F7WbEYjdRwypvbRQ7nVQP6g4bcnXnH087Xn1RVwcB6W3uNSpAza+0sK/ZCzxWjUI82cBMQky4JmQKYV9dBFjM0h/yzWJP6xdIfvT4g2n/7kci4PzZWn9qrENNffb48pZV+AmHxEUomgVDtkyAviy6Zq+hCzKQW7ZgDDB7r8qHi14MYNUJWxYy7Q9y8zOm1PmhbAe1GQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QA+xhcy55W1cPbYaTbK/yqTyHVZnEsdndyYhBDOIt5U=; b=mc1Uh7Rxmcql6tNUL9LJwnPC+a047t/JxvnIVrFfQOsLJtTt7deibKEgxm/GNX3oRVo/VksGIG1C1n3ggTmCXUT3fENIMOlIl/JzEkccmCSH4el9LX+EwaxqWAUNZibGNl0MBle2KbdIg+l4YdrfJc1bWv3uZDFQ5KflyQZPJd8= Received: from FR3P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::16) by AS8PR08MB9671.eurprd08.prod.outlook.com (2603:10a6:20b:615::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Wed, 7 Sep 2022 06:06:45 +0000 Received: from VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1d:cafe::4d) by FR3P281CA0006.outlook.office365.com (2603:10a6:d10:1d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Wed, 7 Sep 2022 06:06:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT038.mail.protection.outlook.com (10.152.19.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Wed, 7 Sep 2022 06:06:44 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Wed, 07 Sep 2022 06:06:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 06fcf2192138e2d0 X-CR-MTA-TID: 64aa7808 Received: from d63b9753ca15.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F424B6AC-EF6A-499C-922D-AC466F81F1EF.1; Wed, 07 Sep 2022 06:06:34 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d63b9753ca15.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 07 Sep 2022 06:06:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kgA9hmswAE0GuqKr8xkkK0Ubh1MRnmnKKCkjg09tvaDSM2xgolx8OxaC6la1LKRh7hm4RFMt2XMCgCLjZpxVjI4ysdwTqis9Z4KrDUFuqXPNaUoXqP9fMvr2GJZmfSBA6ruVhbUao75LpqIWY130QXugz/AwDlGmX3i/5akERNU4sW/ecptnyEnCv8mfhp37lYl4q7ZGD0aT7b1A1bodfEMkS91GLEzpeVi9bv7QajaI09u/DGB1IADrXyzZ+XbMlk43FAqGGKiYf4jB9m890ndXT3kduuTFEV6cqmTMfki2LGHJ/ZRZ/pA935Rehowddjhp9J5XYFq8hzjdjsQo3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QA+xhcy55W1cPbYaTbK/yqTyHVZnEsdndyYhBDOIt5U=; b=FzMNwxaKZxs1+mTlAlJhvRLadZ9P/zYYU+uZhrRv8VfdFftA1/1M9hddW0JaJlcv+WwDkqxjk/tXmRNaYDQ9wtGFs8lw4n8vd/frGA0GGUukHXC2hAx0Iup15w2Jj2htr2GYGKfYIGr8IZrScf2iTyshCm4Vljg0JOk0UE/9qv2qEhKvprAP0031HU4DU76h5AfSp5Z2KHI+WN44B4arjzsaoELCJKWzr+6IXuaMat5qh9xdKmeVYkZhIpADarE6zr/oSCSOoribpoil1QKdyU+cwDFH8E7jYkuKOfMSHK4qASCe2a6vLKJVPFLaGdTCEVZjJ9jwx9T+PL8h6Mqz8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QA+xhcy55W1cPbYaTbK/yqTyHVZnEsdndyYhBDOIt5U=; b=mc1Uh7Rxmcql6tNUL9LJwnPC+a047t/JxvnIVrFfQOsLJtTt7deibKEgxm/GNX3oRVo/VksGIG1C1n3ggTmCXUT3fENIMOlIl/JzEkccmCSH4el9LX+EwaxqWAUNZibGNl0MBle2KbdIg+l4YdrfJc1bWv3uZDFQ5KflyQZPJd8= Received: from AS4PR08MB7712.eurprd08.prod.outlook.com (2603:10a6:20b:513::6) by DU0PR08MB9534.eurprd08.prod.outlook.com (2603:10a6:10:44e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.11; Wed, 7 Sep 2022 06:06:30 +0000 Received: from AS4PR08MB7712.eurprd08.prod.outlook.com ([fe80::90c2:3df4:ec7b:914e]) by AS4PR08MB7712.eurprd08.prod.outlook.com ([fe80::90c2:3df4:ec7b:914e%5]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 06:06:30 +0000 From: Joyce Kong To: Stephen Hemminger CC: "jgrajcia@cisco.com" , "huzaifa.rahman@emumba.com" , "dev@dpdk.org" , nd , "mb@smartsharesystems.com" , Ruifeng Wang Subject: RE: [PATCH v3 1/2] net/memif: add a Rx fast path Thread-Topic: [PATCH v3 1/2] net/memif: add a Rx fast path Thread-Index: AQHYtdoDn9TcOsoGzEK65jLlf2Sf0K3JQPYAgApSWrA= Date: Wed, 7 Sep 2022 06:06:30 +0000 Message-ID: References: <20220701102815.1444223-2-joyce.kong@arm.com> <20220822034731.528424-1-joyce.kong@arm.com> <20220822034731.528424-2-joyce.kong@arm.com> <20220831092550.788683ac@hermes.local> In-Reply-To: <20220831092550.788683ac@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS4PR08MB7712:EE_|DU0PR08MB9534:EE_|VE1EUR03FT038:EE_|AS8PR08MB9671:EE_ X-MS-Office365-Filtering-Correlation-Id: a74d56fc-f022-42df-99fb-08da90972460 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: sVKIZe3xFFKVp1wJM5YLfODfSlKUszQx2DaTqk+nn3cb9R6cti+1Z9T3bFEzgrKf+aqiK3dpyjeM7u7Jq07a5CGdKUFMmKVDBsnd7XtN2K25ljZ+kPDr3EDwhLDLix77u0aTkcDKtMKTiWOnuzwihvKOo1vGvR8QQ3g8DIXuiKRAkGhZmInBkfCu1wdyTu6XV0fVqecX/Zksx1epz/mciOTSfc3C1t1DMr4SQbed3sDF5w1NuifileDPTyB3LL7IQOIQlSq+1s3hW9gB7o7wgM1fv0WGMi6Sf0jQF5kCjDsxMVE7eX+zlk1h3xthH+Eo9CXhoOAzXdZFfGbIXjgjBVne1TgH9SQtHlLIEHWe81N/JAmlhxLpyseoJqS0ATWS+FQVM2WicyHzC9ijTH5Dape3nBkTBFAziL4/XSOTGTLB9AvNavGTFlpUTgB2OMOtX93NBYR4U565FC3QMWZ08nuzts2YwrK2DV9/zA9fY95PzTXse9cySaxkuLVciV18A61k5gxzKbPosRYa34Z2UFv7QS6KRTHmOuAxpb7nl9Ry35t/8Xnap1NHrPKoics1ePP9qf8MnxaxDDmoE9cMxHIGC68qXBIxsm/MCxXCPVPOGdiRgRKEigsREO9laAD3Ar9BqMT5Mz1N4VdWoS5MxcJe8/g1zumve8LqvojJgb5s8IpLGCn543yu5xlkZZSppj3tOSa+wBl2qEMxK9ItewqQeidqm1dhB2TObYh+DVLOSjx124OpY6NgBmi0xDFjAFT+M4jsriOM0GdLf0aOZg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS4PR08MB7712.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(136003)(346002)(366004)(396003)(376002)(7696005)(66946007)(86362001)(8676002)(6916009)(4326008)(64756008)(76116006)(54906003)(66556008)(316002)(66476007)(66446008)(6506007)(83380400001)(41300700001)(53546011)(26005)(9686003)(38070700005)(2906002)(8936002)(55016003)(38100700002)(478600001)(122000001)(4744005)(186003)(71200400001)(52536014)(5660300002)(33656002); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9534 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4f5af198-a9eb-449b-b7e0-08da90971b85 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2/BAlDX86aouD9GdJ6avdsHFI1BYVgIFjWGnaD2FjJ1Cisk85TVgZD63+2LgzleZnCoASvLK+Gl8c/Uod9uydfOTH8CB00RIbjYnoyWZ+fBX6bGxGCunGmgk1QayxmZA2Uv1lNFHgka0cqx7SCHXY3UclMjNmE72eeFrFcmKka1zbUMPEFz60ZXQTNTDxrMvdOvQnNGAerWNzVigw2IombYzqxJW8OT+jxAvO0KMvESxBYpYg1fTYTRDejOvhh+yNda8sasVTG47cdtQOvrI2me1VMGuKY1MuKrK6lpaLrDcVRiiq2y8denr8qLwYheIyw8k1TaiAh2DTy1OGzgJEgQRmG+caAqPrmoQfu/KEhf5RuuP6TpkcJEVaEeOyXqwXB8253harXm1fZn9UsOv+60DSN0/ZKMTJ7pX2YhAvfnJ8TVwA2zwNeLD9ARgWMXAHAae19RQBldkHugFD3+G9oqF8b9EI5eADV0zdoAKwjMs2wb7aPfMEqA1X/dzNi9UUuhTdDUKBACHEXPSbmzfHuFyJdZkNINi09eJPICHUIZZoH+Nz+1iM61kR4nOU02zBLi4/QGkK7EDwnqV8N6Rh9Pe/gi2a9nWtpV94wsMXdHb9jF6XJgMlc3rkRYvcWOKE9uUfZ4n6xYneEQIwc2OvNiUKFTCAzSOdCTfcjqtWgDY63x5m+uqQDNLh9yGwx1+rHLps6dm76idpjJWLxiknO1DVrJMkMccPuHiVOD/Y4n9QCmabBtT2MaBLy/n9JfZCrOZl9JE7jeZQ2CEH7P3dQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(376002)(39860400002)(136003)(346002)(46966006)(40470700004)(36840700001)(6862004)(8936002)(41300700001)(33656002)(26005)(9686003)(53546011)(2906002)(52536014)(40460700003)(5660300002)(86362001)(6506007)(7696005)(55016003)(82740400003)(40480700001)(36860700001)(82310400005)(336012)(186003)(47076005)(81166007)(356005)(83380400001)(8676002)(4326008)(54906003)(478600001)(70206006)(70586007)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 06:06:44.9868 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a74d56fc-f022-42df-99fb-08da90972460 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9671 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, September 1, 2022 12:26 AM > To: Joyce Kong > Cc: jgrajcia@cisco.com; huzaifa.rahman@emumba.com; dev@dpdk.org; nd > ; mb@smartsharesystems.com; Ruifeng Wang > > Subject: Re: [PATCH v3 1/2] net/memif: add a Rx fast path >=20 > On Mon, 22 Aug 2022 03:47:30 +0000 > Joyce Kong wrote: >=20 > > + if (likely(mbuf_size >=3D pmd->cfg.pkt_buffer_size)) { > > + struct rte_mbuf *mbufs[nb_pkts]; > > + ret =3D rte_pktmbuf_alloc_bulk(mq->mempool, mbufs, > nb_pkts); > > + if (unlikely(ret < 0)) > > + goto no_free_bufs; > > + >=20 > The indentation looks off here, is this because of diff? > Also, my preference is to use blank line after declaration. Will modify the format in next version. >=20 > One more thing, the use of variable length array on stack will cause the > function to get additional overhead if stack-protector strong is enabled. Will fix the array length in next version.