From: Gagandeep Singh <G.Singh@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: RE: [v2 3/3] examples/l3fwd: enhance valid ports checking
Date: Wed, 20 Nov 2024 04:07:53 +0000 [thread overview]
Message-ID: <AS8PR04MB81983A7C1E646C124FFD19EAE1212@AS8PR04MB8198.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <3316748.N7aMVyhfb1@thomas>
Hi,
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, November 19, 2024 10:43 PM
> To: Gagandeep Singh <G.Singh@nxp.com>
> Cc: dev@dpdk.org; Stephen Hemminger <stephen@networkplumber.org>
> Subject: Re: [v2 3/3] examples/l3fwd: enhance valid ports checking
>
> 13/11/2024 20:39, Stephen Hemminger:
> > On Tue, 6 Aug 2024 09:11:20 +0530
> > Gagandeep Singh <g.singh@nxp.com> wrote:
> >
> > > The current port ID validation logic in the routes add code has two
> > > issues:
> > >
> > > - It can pass if port ID in route is 31+.
> > > - It silently skips rules with disabled or invalid
> > > port IDs
> > >
> > > This patch is:
> > > - Improving the enabled port IDs check logic.
> > > - Introducing a user option, "exit_on_failure", to control
> > > the behavior when attempting to add rules for disabled or
> > > invalid port IDs (either exit or skip)
> > > - Creating a port ID validation function for use across
> > > various setup functions
> > >
> > > Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> >
> > Patch looks fine, but other changes in the intervening time have
> > caused conflicts with this patch. Needs to be rebased.
>
> Waiting for a rebase please?
>
I have sent the rebase series as v3.
next prev parent reply other threads:[~2024-11-20 4:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 10:14 [PATCH 1/3] examples/l3fwd: support single route file Gagandeep Singh
2024-07-15 10:14 ` [PATCH 2/3] examples/l3fwd: fix return value on rules add Gagandeep Singh
2024-07-16 6:55 ` Hemant Agrawal
2024-07-15 10:14 ` [PATCH 3/3] examples/l3fwd: fix maximum acceptable port ID in routes Gagandeep Singh
2024-07-17 10:17 ` Konstantin Ananyev
2024-07-18 6:30 ` Gagandeep Singh
2024-07-18 10:01 ` Konstantin Ananyev
2024-07-22 3:28 ` Gagandeep Singh
2024-07-22 4:27 ` Gagandeep Singh
2024-07-23 16:22 ` Konstantin Ananyev
2024-07-24 8:02 ` Konstantin Ananyev
2024-08-02 10:13 ` Gagandeep Singh
2024-08-06 3:41 ` [v2 0/3] L3fwd changes Gagandeep Singh
2024-08-06 3:41 ` [v2 1/3] examples/l3fwd: support single route file Gagandeep Singh
2024-08-06 3:41 ` [v2 2/3] examples/l3fwd: fix return value on rules add Gagandeep Singh
2024-08-06 3:41 ` [v2 3/3] examples/l3fwd: enhance valid ports checking Gagandeep Singh
2024-11-13 19:39 ` Stephen Hemminger
2024-11-19 17:13 ` Thomas Monjalon
2024-11-20 4:07 ` Gagandeep Singh [this message]
2024-11-20 4:05 ` [v3 0/3] L3fwd changes Gagandeep Singh
2024-11-20 4:05 ` [v3 1/3] examples/l3fwd: support single route file Gagandeep Singh
2024-11-20 4:05 ` [v3 2/3] examples/l3fwd: fix return value on rules add Gagandeep Singh
2024-11-20 4:05 ` [v3 3/3] examples/l3fwd: enhance valid ports checking Gagandeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR04MB81983A7C1E646C124FFD19EAE1212@AS8PR04MB8198.eurprd04.prod.outlook.com \
--to=g.singh@nxp.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).