RE: [PATCH v2 5/5] net/dpaa: Fix coverity issue

[Gagandeep Singh <G.Singh@nxp.com>]

Hi

> -----Original Message-----
> From: Hemant Agrawal (OSS) <hemant.agrawal@oss.nxp.com>
> Sent: Thursday, October 9, 2025 3:19 PM
> To: Gagandeep Singh <G.Singh@nxp.com>; dev@dpdk.org; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com>
> Cc: Vanshika Shukla <vanshika.shukla@nxp.com>
> Subject: Re: [PATCH v2 5/5] net/dpaa: Fix coverity issue
> 
> 
> On 08-10-2025 10:05, Gagandeep Singh wrote:
> > From: Vanshika Shukla <vanshika.shukla@nxp.com>
> >
> > Fix Resource leak CID:362787 issue reported by external coverity tool.
> 
> This is internal NXP coverity issue?  can you also add details about the issue here?
> 
No, This issue is reported by DPDK Coverity scan tool: https://scan4.scan.coverity.com/#/project-view/68868/10075?selectedIssue=362787
I will add more details in commit.

> 
> >
> > Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com>
> > ---
> >   drivers/net/dpaa/dpaa_flow.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c
> > index 2a22b23c8f..417b9b6fbb 100644
> > --- a/drivers/net/dpaa/dpaa_flow.c
> > +++ b/drivers/net/dpaa/dpaa_flow.c
> > @@ -1,5 +1,5 @@
> >   /* SPDX-License-Identifier: BSD-3-Clause
> > - * Copyright 2017-2019,2021-2024 NXP
> > + * Copyright 2017-2019,2021-2025 NXP
> >    */
> >
> >   /* System headers */
> > @@ -889,9 +889,9 @@ int dpaa_fm_init(void)
> >   	/* FM PCD Enable */
> >   	ret = fm_pcd_enable(pcd_handle);
> >   	if (ret) {
> > -		fm_close(fman_handle);
> > -		fm_pcd_close(pcd_handle);
> >   		DPAA_PMD_ERR("fm_pcd_enable: Failed");
> > +		fm_pcd_close(pcd_handle);
> > +		fm_close(fman_handle);
> >   		return -1;
> >   	}
> >