From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23A03A00C4; Mon, 18 Apr 2022 13:33:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE2CD40150; Mon, 18 Apr 2022 13:33:04 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150082.outbound.protection.outlook.com [40.107.15.82]) by mails.dpdk.org (Postfix) with ESMTP id 453ED40141 for ; Mon, 18 Apr 2022 13:33:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZB15lPZdgdQMLeixVnP7aaGoWo+6syDpHc8CC2AtpMzL7VV/gs7JL07JV8r3cuFA/+4nvs9x/XUmjC3ykvAyDTHZ2qh4rNT9yT8b4DGg0he8FYMH//82sShtZoLZQorkbxiasBtOEXHyW1QHQRTFN1nEPN2fKKlhKwOYeorKa58npxdzIJnoqXiy/29+MFIC9/axOJhXddJiBLD1AiIBaBiW2HEEfwtgPNoDXFcYmdZ37OymTVRbA5ZMh4cnVF/VZkGIiSPLueG9PUcvib6vv+8RiLIAWtCJN5jB/jR1pWN4K0Ab9kS1Y8VsFE3vMQPgv6Ds7mh1+8vU244109tI6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NP9pHDx2SFVfbJVHj9b8RreLdDisSyh/s9wd3uSauG0=; b=BC13G9lkitKN8vmXnCMAskKBHyv9ySOhgmHPHxkQK1RfTjqoOtYgRvD165dIAD8Y/ol6/0KX+GCx46ZpP5rwFmPSiJuG2SZXgGF64V1SZs/PPprA0qWWYym1Tv96qbEqweVg7PPKL/pNtYZaiPAFUareaeNZqDb3cL7bfjShkTj4G+jnSR8iqBGglq/VPbBdAcZ+TJwiXfHIdsOqSGDlzKbD6W0kATeYU+kYUU85IU1xvX/yGocd1Gx5SDyjSoArtpcOkSXFMpjbJLsd8YHwAQworz2VbfCqCK+ojcFUYx+usWYZ+9WMxExn8BwwepXmlTnFSrkpGPiXJ290AAdKjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NP9pHDx2SFVfbJVHj9b8RreLdDisSyh/s9wd3uSauG0=; b=E+GGjKJTeZdGLUj1rVBgeE4v9o9LQvpcUNJ7fEh3HQ3y0D1P43zHFo3Abv+TAT0fm2hr4WQ3sz5ULyXZj5+JaCoUEkkr3xzXBGLXkqSMck1c+WGXDw7bnmVhJaTU5lgH9qfncYgbJO7U/AGtOQj79DhMmj40qVwvzL8hdANhIvs= Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by DB6PR0402MB2869.eurprd04.prod.outlook.com (2603:10a6:4:95::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Mon, 18 Apr 2022 11:33:01 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::95b4:26a1:d97d:6916]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::95b4:26a1:d97d:6916%7]) with mapi id 15.20.5164.025; Mon, 18 Apr 2022 11:33:01 +0000 From: Gagandeep Singh To: Stephen Hemminger , Ferruh Yigit CC: Harold Huang , "dev@dpdk.org" Subject: RE: [PATCH] kni: update kernel API to receive packets Thread-Topic: [PATCH] kni: update kernel API to receive packets Thread-Index: AQHYT/p6D0Wwt90vhE+TCVFyPdRjMqzwUKCAgAAH3xCAAJC/gIAAKcCAgAR8OeA= Date: Mon, 18 Apr 2022 11:33:01 +0000 Message-ID: References: <20220414122319.3519271-1-g.singh@nxp.com> <20220415075959.27778efd@hermes.local> In-Reply-To: <20220415075959.27778efd@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 26a13f00-8c78-48f9-085d-08da212f3209 x-ms-traffictypediagnostic: DB6PR0402MB2869:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DMgs/aIx5BPwgYv2zosPeHVMf4s9HhK0TTrl6votu88XtBVKBmGvH6Z4jVmh7o7TtkftPujB5bNjJMqpIhy8fa/5QFC0vtJjtwPdZQ1dFuMAuQoV8YVW6XUNodRDgrq9iuHpu5bQkT0k0jbTJAPxKb8nyQGe35l7a7hd9AcKKi7vfvzVAoj+Y86pNvfQCy2FiPvPNHPdKZxIjojtTdDWN45LrZFlVTF+sg5ax9LTUws8wyn6ci3w9H9a6/tKidpDJnWfVjl4GyI7dcwHCP65oReuEn2NfZHvQb7YwaPhjT15iS3Iz+R4GBb9YDC0Qs66M8oC8f5fyJ9NX7Ql9aKFGcgWxCfAvqWkrOGuV2NIZFEaDG0NhrpqCkqNLfqDIDdkwx0PXqkw2QnKwGmd797Ly/Ix0Ssyds6eWBaYKG7J4S0AZPJxmW04f6Usw2u8Fbcf6idZ0qk2MBrbaUI9XG6h7OrplFPm8iz/8PUqDcGgXTu4aFXear2zHArnSsO69TGfqlrEAgxbUUASffGp5k7OA2XYIVda5BeYZgACCaIyNVSBhX/x/YXABzINiAM5h2iRYIPt0BJJx7i/ySFs37y8LSFPppa6UpqUX5tcgglScYYxmALyLsWl/ggbD9+HxK5GKBmvxV8ZfungRDgqRFUCxg27WEUikiKmj0O4f/aTYE8qTnFbGS1erUH2IwA1dZezRnOSKDe/ILfCF81nP41zEw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66476007)(66556008)(66446008)(8936002)(38100700002)(71200400001)(55016003)(76116006)(64756008)(66946007)(9686003)(4326008)(8676002)(122000001)(186003)(26005)(52536014)(15650500001)(54906003)(110136005)(508600001)(2906002)(6506007)(7696005)(83380400001)(55236004)(53546011)(38070700005)(33656002)(86362001)(316002)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SxsmDsjurD/M4YIL0HW7ATwYVkJgljaftShop97EEOV9oRuWLy6bgvkPFyWn?= =?us-ascii?Q?esDOBl97YjqK94ES0cc2o84R2tWObak8AiFjIcLGBZ+B24RLP0Ww2DjiS/Zr?= =?us-ascii?Q?nhrYCi6rkB7qMC+jLyHLLqiHxcq4RTj0QD4380mtYlv5UjRHhdu2ex/fQcyS?= =?us-ascii?Q?USrkRpsNoAlxOtzatDyLcC9gJrd83VZ8r5xXsIEwTonSN9wxiLmilwwS466M?= =?us-ascii?Q?deWL0XcuDbAPTdgia72YEI0Be90i6ESBhIq04zFoXGC/2UPvWLlvn0p4lJaP?= =?us-ascii?Q?xEnAN8y9T/xLo2Gd517xPgNfP/XCl7qEoUZ//pTmzXphIvhIT/u48wjSrA6W?= =?us-ascii?Q?1OzFQUI7E8SdMV9QZe8WCt1KsQtwcwWLq1HHrkQz5KMeAGAqmRlKVixU2vuN?= =?us-ascii?Q?qQbGakcKWskd5EcwHRBpLFrPRbIz/e9v5qXFuzDq2nAI7+sgd5VSe5A7LPwE?= =?us-ascii?Q?vCP0DLUscZDjisRJYucWYe2vLM8CsHXkUxKcHuwU+r5oD7oVOkVKZJ0+uHHe?= =?us-ascii?Q?oN3Ezsfmm0QVE6GFQJM3DAyN3jhwF+GF1OFcDY6RdFbvY2d6oFppGEZm+8fO?= =?us-ascii?Q?sKYhaNutOC47H46S2QA6Fvqo8YVSy+H3zkigkXMOOehijqUk7AXayrjyohkv?= =?us-ascii?Q?7FJ8YzzJQ8Tq6AjGyTUA5OVXrQxhk6qeVOuHqJmH4Vc1MCW+sRlH5msl2VOQ?= =?us-ascii?Q?bnkxrkpmUNDLgWngmRBwEyPgisMWJQPEWEcwwGmxYwAnLPnnCMPFdfxUWDqL?= =?us-ascii?Q?Qgq/y1wdEXC89V28WY+9kHngV1AKxoUaOyLqgsYGkmJ9Z+EUO5N6uJfGTACn?= =?us-ascii?Q?L2fiZerkZVHxNjwxRW+OnitK/Yz7fvl99FrBVTqxZ9JNRPqykYsGQjnPsSkr?= =?us-ascii?Q?kj4q1tV1W1EZuNFjLI84BTv141tfV7cPOaoRdhC9m9kR8yJ0RkN+W7t/sNwn?= =?us-ascii?Q?ghZOxLTQIBKFGivn4wmpxVgG2/guq6sfeIm5SSuNuIi87QajPbbky/BfhnnB?= =?us-ascii?Q?/2kbFqtUpHNYv+HFPgl06JX93Ridg1JLvX9xab1P/s6pD239ebfjLgkHk5YB?= =?us-ascii?Q?S24a6bya2bU2NA3D4rT83T5hziWniyxFSaSGOVQ+3TZy9R2z5bH/fR/FChNP?= =?us-ascii?Q?j8scRsnSEeWrcolz1B3wXGRqT3YYrR1Oc4iHTbm5ugdx4HMC1oLGmknciC81?= =?us-ascii?Q?TKdcEVs1d1Ezxx0dczd/tFMl1Yi0k42UUlzuFm3VXxGrho6yxI4n9G6SHco+?= =?us-ascii?Q?TjwS5p+gmKaFuiSUc0qCId6Ui6NZUjesKvkVh5/kN4kt3pdWKjAS4Hctf4fC?= =?us-ascii?Q?9nxuFNkZ211eWf/75DsXzlpIIDrAUYN3HmIiL3TaVcyn6ejBeunuHeDMfN0P?= =?us-ascii?Q?DctZZoYLL6EYUhFtWbG8r209mkzNiSbX1BJhkx1THM4YgycNuKuv3atvZ0bU?= =?us-ascii?Q?k++Uh8/tUoiT4wk3XollifsWY+syzKic9kkg4fV4x27D6cWlVaH0w2lUnTsc?= =?us-ascii?Q?u+xUjMhkEIwawMNnOTc2m734BQV5TLtE6hkHfYkyJYzxwZeJUSjH4BxwEkI4?= =?us-ascii?Q?5Nk8zkFx9qOWRbY+FFTFfsBL61L1q1NOBrWolA+3Shv1tWSXU+fOnUU0SOOm?= =?us-ascii?Q?1CLlXbvkdDhVVj0VugmWOiJtpockKdWwyXLSP2VUHmEApvM1ho/CPVRDinjr?= =?us-ascii?Q?QiuvHzqYONE3FXyin0sk6qvMRHpHEdYG5q1N5hnsyQoaJ/1c?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26a13f00-8c78-48f9-085d-08da212f3209 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2022 11:33:01.2666 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wRZ3KfjJjCvKcrzySOR1KNEfCGvUDwtxPEnj2FH6HLPe85yEoXzLpBCP+MIx3VeF X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2869 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Friday, April 15, 2022 8:30 PM > To: Ferruh Yigit > Cc: Gagandeep Singh ; Harold Huang > ; dev@dpdk.org > Subject: Re: [PATCH] kni: update kernel API to receive packets >=20 > On Fri, 15 Apr 2022 13:30:33 +0100 > Ferruh Yigit wrote: >=20 > > >> But this change would cause KNI kernel module does not work in the > > >> old kernel without this patch. I suggested using netif_rx_ni to keep > compatibility. > > > > > > netif_rx() API exists from very older versions of kernel before > > > v2.6. There will be no compilation issues. Only difference was, > > > netif_rx_ni() can be used in noninterrupt contexts to improve perform= ance. > > > > May not be compilation issue, but with old kernels won't the behavior > > be different when 'netif_rx_ni()' switched to 'netif_rx() >=20 > Probably best handled by #ifdef on kernel version but will be a mess for > backports to distro kernels. >=20 > Looks like: >=20 > Older -> New > netif_rx_ni netif_rx > neitf_rx __netif_rx If it is ok for everyone, I can add #ifdef for kernel version >=3D 5.17 to = use API netif_rx, to avoid any functional/performance impact with old kernels.=20