From: Gagandeep Singh <G.Singh@nxp.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec operation
Date: Wed, 17 Nov 2021 07:00:05 +0000 [thread overview]
Message-ID: <AS8PR04MB8198BCFB9D5E6EB4A868D93BE19A9@AS8PR04MB8198.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB4484A69C689953493D4AB1D4D89A9@CO6PR18MB4484.namprd18.prod.outlook.com>
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Wednesday, November 17, 2021 12:06 PM
> To: Gagandeep Singh <G.Singh@nxp.com>; dev@dpdk.org
> Subject: RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec
> operation
>
> > > Can you explain the calculation for 73 bytes in the code?
> > > Will it be sufficient for IPv6?
> > No, it will not cover IPv6, As currently only IPv4 test cases are there in the
> > app.
> > But I guess it covers all the scenario which are supported by the app.
> > 73 are the maximum bytes which can be added in
> > AES - SHA algo mode (41 +12 + 20 (including any padding))
>
> Please explain and define macros appropriately so that we know what all is
> Covered in 73Bytes. Or why not increase it by RTE_PKTMBUF_HEADROOM.
>
> >
> > But it will also not cover other complex scenario like NAT-T, AH.
> > I have verified this change with aes-cbc-hmac-sha1 and aes-gcm algos for
> > 64,128,256, 512, 1280 bytes.
> >
> > What's your opinion on this?
> >
> I believe using RTE_PKTMBUF_HEADROOM will resolve most of the scenarios.
Agree with you, I will verify it and send the next version soon.
next prev parent reply other threads:[~2021-11-17 7:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 10:23 [PATCH] " Gagandeep Singh
2021-11-16 10:37 ` [PATCH v2] " Gagandeep Singh
2021-11-16 10:42 ` [EXT] " Akhil Goyal
2021-11-16 11:47 ` Gagandeep Singh
2021-11-17 6:36 ` Akhil Goyal
2021-11-17 7:00 ` Gagandeep Singh [this message]
2021-11-17 7:40 ` [PATCH v3] " Gagandeep Singh
2021-11-23 19:49 ` [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR04MB8198BCFB9D5E6EB4A868D93BE19A9@AS8PR04MB8198.eurprd04.prod.outlook.com \
--to=g.singh@nxp.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).