From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61EEAA09D3; Wed, 19 Oct 2022 17:13:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46A2A42BCF; Wed, 19 Oct 2022 17:13:31 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) by mails.dpdk.org (Postfix) with ESMTP id DB40942BB1 for ; Wed, 19 Oct 2022 17:13:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dofv75LhgKHcUXhCuivXtzIuyVo39AQuqc5+WkLhzjKrH6svk3s/LNXRaN1gEqmK9AiRDJlSaSzG9QIT+cC0DIVOK3TsDn1kKNuHc9ooF4H8Tm016ByjbLwOIhYEg+52j3CX4+BxAkDHc5wOLwJ0935CL0MJECDgba3NFWxE5kcQUM7yxEqhFsw/zCtK+TYTeEoMGtMgMe0tLYRppmfO7n/IYAbZFFZD8/yrKmBB/8PwF8WL8JoQNd/tm1WkkXzENx8jSwVV4Hb0p2iAQKUMqExLIY0dTlupFgJQ7wExQjvSTc0Qw4Cx4Kyw30tTO82lMygYFaQ+WoMQxTvMB2c3dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=idvDVSaZB0bkOd7i58qJUczMQwu2MblDKlRRvAQqaVY=; b=CWhuzuLcxE+061zSoIK2XBCjxoZwAkb0MwSoyRH3uaODVz7qbT7YZHP+vn1JJRdJwi82nuJo7w/zOP8mdDXnSHF28ZQOMImukw49FbHPNEnqIFkgeYhQucvDa85exx6DzMHhzXVLf8Q6lo6P1YAAU+zVXT0/A8yvUxSZkw/0kCEjazFYblmYgsfg4nfbu45aYbUddTOyZw7sEY/ncO4CCnKhBntP3rLk8AmfX3XTH+jymHVhwrz6dG0EwwqH+b64jX41XW/H0HqO5mWiadDlPT+hkglk8riJ3dSJSm//5Kmr7GaVw1HE3NWEJvsmL7n15sgWpbT5qcPy2Jw0gYsxug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=idvDVSaZB0bkOd7i58qJUczMQwu2MblDKlRRvAQqaVY=; b=IqSDdnU3radziv3IJcT2DKl6K1IpdPNMP/6Mj5WzPAHvMKetK0FxCvvwSyC7ulqE2NNlaLg4uEdYAuQuMoXODECRRgxEVl+LYo1srbEv7UUoeHL7wbRF7USv2mYjRG4izwqUFQ7OIiK4/1WgrDAQtq51l34QKkMxBzvuMHRlO3c= Received: from AS8PR04MB9064.eurprd04.prod.outlook.com (2603:10a6:20b:447::17) by PAXPR04MB9256.eurprd04.prod.outlook.com (2603:10a6:102:2ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct 2022 15:13:29 +0000 Received: from AS8PR04MB9064.eurprd04.prod.outlook.com ([fe80::f7e8:d402:a393:6205]) by AS8PR04MB9064.eurprd04.prod.outlook.com ([fe80::f7e8:d402:a393:6205%3]) with mapi id 15.20.5723.033; Wed, 19 Oct 2022 15:13:28 +0000 From: Hemant Agrawal To: Ferruh Yigit , Junfeng Guo , "qi.z.zhang@intel.com" , "jingjing.wu@intel.com" , Stephen Hemminger CC: "dev@dpdk.org" , "xiaoyun.li@intel.com" , "awogbemila@google.com" , "bruce.richardson@intel.com" , "xueqin.lin@intel.com" , Haiyue Wang Subject: RE: [PATCH v5 1/8] net/gve/base: introduce GVE PMD base code Thread-Topic: [PATCH v5 1/8] net/gve/base: introduce GVE PMD base code Thread-Index: AQHY3JG+nPx9x/rt+0S3uQQFTzYA1a4VyNMAgAAYABA= Date: Wed, 19 Oct 2022 15:13:28 +0000 Message-ID: References: <20220927073255.1803892-2-junfeng.guo@intel.com> <20221010101757.878317-1-junfeng.guo@intel.com> <20221010101757.878317-2-junfeng.guo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR04MB9064:EE_|PAXPR04MB9256:EE_ x-ms-office365-filtering-correlation-id: 4e888a32-8a42-4d5a-fa38-08dab1e47a58 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N6Fj0iQUwWc2AXe/Mv423B5KxTijeq2vI6BLHYZRZQaCN9i/wpUZHnBJleHg2PiRWplou/i2CVKRAMr1OnFlVAbkcJo9C9/gvpfaE+s5f69EvSyDuJ5VhQEeh77d53FPS68jPZON4KkZehBELFfJcOfGm+tfLYcdOy4Ba4aWpefFh3WGNbOAQANiPILhToBqka81XtgnpJDnkHkymbvJxR8mz4uyYF2P6tLQxDCskbE3KPcEVmDddvdQZqRQqMTkJ1qDqBKP43eYnLs/qw1wEkuuO5/5WtgAwXH5CCwDj5QZY3ysvngApKitPBfjzEAkD/oaRmYopb1MDBUM8Tb+7j2vYW+nIwErT2jYxfVGBDb9WM63tTjFJFL3S4xy6RydWzA+mPp8QD3ZlbTpszdypm7TFR5poI4yGBj7qc+uFN/vxeQyhprTHJltjMj8SVyPlkIqxRKqfQclnuRCwDv1qidJDEdVBE+SUX8lnx0Gm/o9n0Kz2sHDkc6P39gXwMJqkhK8f4ojg6G/7m1tWmZvWvLl/SdxYj09HlZan37WCsTLnd2LHub2QFElgXIa+HxfhOZ/FvWuQ13ann9Y4YgFwGj+iEQp25KrWIh+YrnlESEdg3bI19tt3Qd/5T97Ve3Gg4CYVB0IqI93jmCSPmCbxgcvB0Dak8Z/uzORLG+cUrwlM0CDQB1zJnNUvZXe2FgrgeSFzrFviFodm4pcnGvJv6IR2O4KKlYVEPMh7qW7qphCPC3s2/HYbP3fN/+mXNmCR1OMrfEzkzFFVfHRCiAyaOBbZVm+JiDRC22REy8bK6M= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB9064.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199015)(54906003)(186003)(316002)(110136005)(9686003)(44832011)(7696005)(6506007)(33656002)(4326008)(52536014)(26005)(5660300002)(86362001)(8936002)(2906002)(53546011)(83380400001)(7416002)(41300700001)(66556008)(66446008)(66476007)(64756008)(66946007)(76116006)(55016003)(8676002)(122000001)(71200400001)(38070700005)(45080400002)(966005)(478600001)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d30qyM2/JOBCDoQcnTjyHixTsKTQfsC5AV4kVcoygx+REHOipAOvdeNqa0Xs?= =?us-ascii?Q?uFGWdMSp/MJsEvqqZ2bpn8VDzNFO6DYFTBMGQIuY71Tezwwmi9W56VmWXgLn?= =?us-ascii?Q?8Kffda1ROBgGORfCcbtTXqi6FsuWNwTtZJnWig3LnfKUSjTAkIOo6RtyGjiU?= =?us-ascii?Q?/dMVHgHVwdowzekerkfFIaX1LtUJIzcci7R9cYz+YHN8OZ8VqaPo/5TilPOl?= =?us-ascii?Q?lr+Y3svD9MrgXWTc/9X4cKExoo0b/wa4zJYG/CgRy6drddu4zCLjbUFFMu6C?= =?us-ascii?Q?f6QOicjGCF/QOlnVEi5YffX/fXjlfi5hVeHCMfZCouWwRO4zxzCDfjn9B8qT?= =?us-ascii?Q?JwBMl7E/OtOW0rm2ESXj6WbzEvEDFW6fg+NTslPOPhkdGYaW25ajzmh5P3HI?= =?us-ascii?Q?wQBC0cdrTrkJ70ghXVGSwiKc/IrW3cuBbwMekxXfFIp4m3wAKhjqk7FfOacW?= =?us-ascii?Q?CmwH5sXQQr9/K/JmiZOuzpDVGnZA979H19zu1Nvmkrz9A2u6vmIshc+5aBVd?= =?us-ascii?Q?jL5U0WxjYVWemPDr+RogSMB5eb/sFSsgLHdAgVkOQRrXv0hLK26g0mL55rsv?= =?us-ascii?Q?9mIjWGDGk5Lbppu0wLCr3hyHCZQOWCsVtnmXq2COlmTlaOJznz5QheHB13vx?= =?us-ascii?Q?fktEMl9QfzsEj/HI22f14dbiUQL+99CPTmdc49uA3eEvhmXvKZq8qh3+4S/2?= =?us-ascii?Q?nL2XrGqjHfv/5QFinNCfsPnWT4qbrDBye0rQbCNk3i75fs/t0KzXa2DS3XKL?= =?us-ascii?Q?HJ09g8g38cDj3BAf/QfqNPFqr2JwJDMdnuXfxFQlP64Mj6b08vPyQ8fAEbJg?= =?us-ascii?Q?DKEaQHomvuC1ncCa8sN+NNMgW4cqzCVUw6K1vNGcizq+NnlnCW3XGPGctX9k?= =?us-ascii?Q?BgjWUDmijocvEb9pEcMT15xxXD1SvhObsfloV9M2OKhyYIM6E03KBp9Emxms?= =?us-ascii?Q?wev6bStjYgtWleh+jfZeiIqr1Gfdms09ALtDZ/I/7RES+geaEjjkQCxYgzUo?= =?us-ascii?Q?cM57+yijX95vCu2XjQ65DblATwxQtU3YGOt4iXBZoCrz4IJdC3i9avC9sXAJ?= =?us-ascii?Q?b6uHNKnhe7kd/U6uK4XlfZybVX+a4tqy2i0sjHGULMW58H6E8lcxZvw5iQX+?= =?us-ascii?Q?B++a7DrIcnrF6oTfA2Eg68S4dhftjBz5/tkErxxDtGtWElaem6SUtWEVoz5R?= =?us-ascii?Q?8Cqnr8tCzR0G9jQmz2wnBhFGxEJa18DJe8fZHkJk0Bgs9OXLvYjHM+ajmrc+?= =?us-ascii?Q?BhQ/PQU4d2oCzFFRMN5NCJ4NstAxR7C84zKgMSknrWLVA2Gk5cBX5bCQVD6P?= =?us-ascii?Q?a3ykOxTw6tiP/QoNNsfbV2Jov42HyMAqvHn+WSoZPlFcWirQYuZCfWrSbKhe?= =?us-ascii?Q?HdzQclaco2gcsnkzyU+yicFcfk8EH9Y2zMnM0exjy6Vt32NkCHYlkIiqwAoq?= =?us-ascii?Q?ZTPIq7FqSWWlek4DRCtmseiu2s7t9AAJ5w6TFDtod2HYh9J28PQeBBUQmbuk?= =?us-ascii?Q?EWJLUWBX1bHrvBCVwAYrpbxdv+U5YFgigDrItRae7WfSRNh6kVxbKORB7eT+?= =?us-ascii?Q?R1mrb8xT6aZ1HLDufQgOAMqBH7Bfl7Ae9B55sV6y?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9064.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e888a32-8a42-4d5a-fa38-08dab1e47a58 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 15:13:28.9345 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6C1sIfhaqwyFVpEaJkLNeQTK2G5xbHUKK0UKcDL6xIoIO+Dntickuz65iH7sCQxcdeWNTADca6Un0Sd8VL8aag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9256 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On 10/10/2022 11:17 AM, Junfeng Guo wrote: > > The following base code is based on Google Virtual Ethernet (gve) > > driver v1.3.0 under MIT license. > > - gve_adminq.c > > - gve_adminq.h > > - gve_desc.h > > - gve_desc_dqo.h > > - gve_register.h > > - gve.h > > > > The original code is in: > > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit= h > > ub.com%2FGoogleCloudPlatform%2Fcompute-virtual-ethernet- > linux%2F%2F&am > > > p;data=3D05%7C01%7Chemant.agrawal%40nxp.com%7C45cbc9718dcc40d04e4 > 508dab1 > > > d82440%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6380178391 > 21579415 > > %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi > LCJBTiI6I > > > k1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DLHunq53xMl8i > W6%2B3scjZ > > q0Bx7oF08yLWk424aw5lnwA%3D&reserved=3D0 > > tree/v1.3.0/google/gve > > > > Note that these code are not Intel files and they come from the kernel > > community. The base code there has the statement of > > SPDX-License-Identifier: (GPL-2.0 OR MIT). Here we just follow the > > required MIT license as an exception to DPDK. > > > > Signed-off-by: Xiaoyun Li > > Signed-off-by: Haiyue Wang > > Signed-off-by: Junfeng Guo >=20 > <...> >=20 > > diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h > > new file mode 100644 index 0000000000..1b0d59b639 > > --- /dev/null > > +++ b/drivers/net/gve/base/gve.h > > @@ -0,0 +1,58 @@ > > +/* SPDX-License-Identifier: MIT > > + * Google Virtual Ethernet (gve) driver > > + * Version: 1.3.0 >=20 > There is a version macro in the code, is version information required in = the > file comment? >=20 > > + * Copyright (C) 2015-2022 Google, Inc. > > + * Copyright(C) 2022 Intel Corporation >=20 > I don't know if it is OK to add Intel copyright, as far as I know this re= quires big > enough contribution to the code, if this is copy of existing code, may be= only > original copyright should exist. >=20 [Hemant] Yes, the general guideline is that one should add their copyright = if they have big enough contribution. But at the end it is a guideline - n= ot the rule. It is up-to the original copyright holder to object. > cc'ed @Hemant and @Stephen for more comment.