DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Stanislaw Kardach <kda@semihalf.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	David Marchand <david.marchand@redhat.com>,  nd <nd@arm.com>
Subject: RE: [PATCH] build: avoid deprecated function for Meson properties
Date: Thu, 5 Jan 2023 04:25:37 +0000	[thread overview]
Message-ID: <AS8PR08MB7080022D762DEA0367BCDB269EFA9@AS8PR08MB7080.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20230104113635.206506-1-thomas@monjalon.net>

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, January 4, 2023 7:37 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce Richardson <bruce.richardson@intel.com>;
> Stanislaw Kardach <kda@semihalf.com>
> Cc: dev@dpdk.org; David Marchand <david.marchand@redhat.com>
> Subject: [PATCH] build: avoid deprecated function for Meson properties
> 
> The function get_cross_property() has been deprecated in Meson 0.58, and is replaced by
> the function get_external_property() introduced in Meson 0.54.
> 
> This replacement requires to raise the minimal accepted Meson version from 0.53.2 to
> 0.54.0.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  config/arm/meson.build            | 4 ++--
>  config/meson.build                | 6 +++---
>  config/riscv/meson.build          | 4 ++--
>  doc/guides/linux_gsg/sys_reqs.rst | 2 +-
>  drivers/meson.build               | 4 ++--
>  kernel/linux/meson.build          | 4 ++--
>  6 files changed, 12 insertions(+), 12 deletions(-)
> 
<snip>

> diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst
> index a7e8261e22..e4f9b41251 100644
> --- a/doc/guides/linux_gsg/sys_reqs.rst
> +++ b/doc/guides/linux_gsg/sys_reqs.rst
> @@ -43,7 +43,7 @@ Compilation of the DPDK
> 
>  *   Python 3.6 or later.
> 
> -*   Meson (version 0.53.2+) and ninja
> +*   Meson (version 0.54+) and ninja
> 
meson.build:15 needs update to reflect the version pump.
And .ci/linux-setup.sh:7 also defines meson version. But I'm not sure whether this file is still in use.

With the changes:
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

  parent reply	other threads:[~2023-01-05  4:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 11:36 Thomas Monjalon
2023-01-04 11:59 ` Stanisław Kardach
2023-01-05  4:25 ` Ruifeng Wang [this message]
2023-01-05  9:14   ` Thomas Monjalon
2023-01-06 12:30     ` Bruce Richardson
2023-01-06 20:33       ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8PR08MB7080022D762DEA0367BCDB269EFA9@AS8PR08MB7080.eurprd08.prod.outlook.com \
    --to=ruifeng.wang@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=kda@semihalf.com \
    --cc=nd@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).