From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3647B42AA0; Tue, 9 May 2023 08:24:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0868541141; Tue, 9 May 2023 08:24:11 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2078.outbound.protection.outlook.com [40.107.13.78]) by mails.dpdk.org (Postfix) with ESMTP id 61666410D7 for ; Tue, 9 May 2023 08:24:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+aa+IzpzZkHfw5ovcl1dJTKyrkKzZI9mkwryXlfbphk=; b=0PTm+jBvrIkCVF2gScjM61oEcyxmUKA9JecMFo+M2Sl10ugtX+x5d+unI09IdwGtsmyDhHq6o+NGuMgQ6d6OBqsjuxv7OlHnxXzcbGVAP0QJM0p4cLj5yzSpcyBonaABJkIU3ECI82S3TiPEPJK2o1gLETF7yGG42/uGhrhLakU= Received: from DUZPR01CA0216.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b4::14) by GV1PR08MB8499.eurprd08.prod.outlook.com (2603:10a6:150:83::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Tue, 9 May 2023 06:23:57 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b4:cafe::b4) by DUZPR01CA0216.outlook.office365.com (2603:10a6:10:4b4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33 via Frontend Transport; Tue, 9 May 2023 06:23:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.18 via Frontend Transport; Tue, 9 May 2023 06:23:57 +0000 Received: ("Tessian outbound 3570909035da:v136"); Tue, 09 May 2023 06:23:56 +0000 X-CR-MTA-TID: 64aa7808 Received: from 96768e979889.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FB4C7DDB-C8E0-4B60-9477-3DD1A1C66114.1; Tue, 09 May 2023 06:23:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96768e979889.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 May 2023 06:23:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R6biXEg08Q8TahtiXNXvhNqry/IJ7B7Om26McuGtcVIBVZROtvNOhals36uQT6G71VBX0sUrltVoCLCK5eCa3aJhG3BsUec8b2x+Marfx5l2apk1CgCtVuyVCN3x2cdy2YvzRe9/mYhAJTHUhLesQzVie2GCxVgbYNTQAW3T4B/ontPqbNmSXXNeGKww0Y4+n7GmRDEGkSbLyxVqFnM1FfgDs1FFPAB6O9WfGA9YOEBds0rsd33e2hiRwWJg08etPNeGVAX+5WCBsEX+JdMkXCxWCWh6Nx72I60uILVHrIuO6PoP0Gn/MdPDGDw++HZKFvwEWPLwWpXVcVSMw7XI/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+aa+IzpzZkHfw5ovcl1dJTKyrkKzZI9mkwryXlfbphk=; b=CFeC/fdh8q7fp8VaBEVNzqzp1joFGd8qyB01yBGDKJSNtjAEwsknAgsZz+JFq5ERrC2TsHI3ksHg7cWvw8ZNAnooCOqdgj0VGdAOcDkC1j7BvWu3BiDKlHVZvofNGx88YxrzyvuFcPkoEQw3wF4DffZ5169QM1KALdSc0cGUSJ3WZ36SHAXDJGkXj58hDKUh2ymQ/6rt7r4s7eJOaGro+dpo7pRY4R2hmNrxeqv+Zo4uSCYFuqddbeq2gXNlsmDKQnfl3no8JY9XbiFGvoMNvJvY4DwAmXU1oSKSgaXBfu0urA48HpY8TN03v3P5npjnXHaY1/8xBNnZkffjv5lEXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+aa+IzpzZkHfw5ovcl1dJTKyrkKzZI9mkwryXlfbphk=; b=0PTm+jBvrIkCVF2gScjM61oEcyxmUKA9JecMFo+M2Sl10ugtX+x5d+unI09IdwGtsmyDhHq6o+NGuMgQ6d6OBqsjuxv7OlHnxXzcbGVAP0QJM0p4cLj5yzSpcyBonaABJkIU3ECI82S3TiPEPJK2o1gLETF7yGG42/uGhrhLakU= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by VE1PR08MB5584.eurprd08.prod.outlook.com (2603:10a6:800:1a4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Tue, 9 May 2023 06:23:43 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::56e7:ee73:bd05:e16a]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::56e7:ee73:bd05:e16a%4]) with mapi id 15.20.6363.033; Tue, 9 May 2023 06:23:43 +0000 From: Ruifeng Wang To: Jie Hai , Honnappa Nagarahalli , Konstantin Ananyev , Olivier Matz , Dharmik Jayesh Thakkar CC: "dev@dpdk.org" , "liudongdong3@huawei.com" , nd Subject: RE: [PATCH v5 1/3] ring: fix unmatched type definition and usage Thread-Topic: [PATCH v5 1/3] ring: fix unmatched type definition and usage Thread-Index: AQHZghX01fN1ZSY/1EiTwlse2xG5p69ReAmg Date: Tue, 9 May 2023 06:23:43 +0000 Message-ID: References: <20230210024835.33804-1-haijie1@huawei.com> <20230509012907.3817-1-haijie1@huawei.com> <20230509012907.3817-2-haijie1@huawei.com> In-Reply-To: <20230509012907.3817-2-haijie1@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: CECBAC51A671A34D8F604BC7009B4DE6.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7080:EE_|VE1PR08MB5584:EE_|DBAEUR03FT040:EE_|GV1PR08MB8499:EE_ X-MS-Office365-Filtering-Correlation-Id: fbd0e687-22f6-4fae-4753-08db5055f83e x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WMadZkPjVF+oltinnk/qFv/znmkmDvgZn/NrrTxbuPaaHvafo3OtfcsChjSpp7JXDu2mlpfEJl2L9ZUAnd4rWRQ5xyVq2DeznSyn+f8M2jybSmMqwX1fdLBMSMEfJlx7lTnYaJB0MbOsUjzVxX3gee0a8a9Fat+mkY3VOuGSFGeSIBvFxE8mTuKphfbJvGTKr+ztlWZ2tD2YwPXQ4kbfMK3RGeK5lLFTCUFFeI8OBoQR53UOUbtcZlbV0Xh6eEwIpc1F8UjBQZREDJNrPCQ/DsSQXH9+oR9gC1a+/hFYA45aU/nhzrBJzeQbBF0GTXZh3hAuXTbAiFDAXhQwfCFWq6jCq4+lbDjc/MO39+CM84rEQtt9L+dl345h5aa1vCBvjRyTEVyY5lfDjUgbXcD69R21ACevdJTNIAa+jtzsDQGc3JI+WcSJKIO44DUH52BCAh/yHNPQ3fDJIctDYW03dD54lZb06FO+mNEDfow986AFXSLzRSS5fruCTGA4nxY9++eH7AMrUrTE4jo7jemoMqh1BfNTq08xH7oEuFTYp1VyYdQ2A3Xp+m0WaxwKEaQFhbqAxvRxu2JB4peV6rIk9u84SsXvbYIHXxb8xVU1Mkpgx17t/gyr4SdCUjVCRwDm X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(136003)(366004)(346002)(39850400004)(396003)(451199021)(2906002)(38070700005)(186003)(86362001)(6636002)(4326008)(41300700001)(76116006)(66556008)(66476007)(66446008)(64756008)(66946007)(83380400001)(53546011)(9686003)(6506007)(26005)(5660300002)(33656002)(7696005)(38100700002)(52536014)(122000001)(55016003)(54906003)(110136005)(71200400001)(316002)(8936002)(8676002)(478600001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5584 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e1403fd8-9b27-43c6-5f67-08db5055f03d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3aMGBLCXpXRAm/emleCnnwUvsBnhuo5hDqH5ySI8mJxg59JxRuqusO7mA8V7idFIOeEsSSwu6sWLhENHv4GISKz5DsyX6O2Q3gbkrerSuG7RBXJMiCCXguSXH4hz4/Q5X1QjZmiAfX0BiFjLQZf78VlNRQv3slnkzUVrs8OLV2ZAvzkufnqmFmKTb72mP40ESQ/HlowV0oFge6C1Szj9NV2iGTm8ARN70jGbBTkcRIu6Fy46cGf3TWzZPMWkZd/6m2l5hC0B8KUJbkH4mGzUNzewsiauhiesoYb1GhIRE6U77UuRaCh4hUaUyutqXnXdSxa4bqtQGfRarVQy1W3MdNGsxeAtjRFkbVOk9vI64FUTmoE3pOhsdUd+VvOG4nNzEN2X+TFom5oMV4fAaG4yA17dwzjJMiauZ5PbA4Fxvn3G50Qb4uvdWqZ8x60hX55oUcovnKW8uyAJoyZuKb9c4t2PwN+l8MWb17eM4yFKRfaew0JNxi8WodU2+RuHNwRtS8QmqYcySzN9eJ1RqMhBps0uOAodo6VSWztyplNk0UEZ1aZHuysuFy4o82mXHryiY0jWplonK7nPE27WZqK+lPogvH9lNC3q67g433zNh1Kr9kHjfOhkTGy/4sx0okq2GSDxtIkorT+l63g4CdpsSo0EGaPahB6380bh3yLeGubnoBL+AImuw+8Wfgzsz6n8syVuY8BtgGc6Q4FoX8sFQXZ7gyPLGGcZkXZVVtHYCKQ= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199021)(36840700001)(40470700004)(46966006)(40460700003)(83380400001)(47076005)(336012)(9686003)(2906002)(53546011)(186003)(36860700001)(6506007)(6636002)(4326008)(70586007)(70206006)(316002)(110136005)(54906003)(41300700001)(478600001)(5660300002)(26005)(52536014)(7696005)(8676002)(8936002)(40480700001)(55016003)(356005)(81166007)(82740400003)(86362001)(82310400005)(33656002)(23180200003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 06:23:57.0174 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fbd0e687-22f6-4fae-4753-08db5055f83e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8499 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jie Hai > Sent: Tuesday, May 9, 2023 9:29 AM > To: Honnappa Nagarahalli ; Konstantin Anany= ev > ; Ruifeng Wang ; Ga= vin Hu > ; Olivier Matz ; Dharmik Jayesh= Thakkar > > Cc: dev@dpdk.org; liudongdong3@huawei.com > Subject: [PATCH v5 1/3] ring: fix unmatched type definition and usage >=20 > Field 'flags' of struct rte_ring is defined as int type. However, it is u= sed as unsigned > int. To ensure consistency, change the type of flags to unsigned int. Sin= ce these two > types has the same byte size, this change is not an ABI change. >=20 > Fixes: cc4b218790f6 ("ring: support configurable element size") The change looks good. However, I think the fix line is not accurate.=20 I suppose it fixes af75078fece3 ("first public release"). >=20 > Signed-off-by: Jie Hai > Acked-by: Konstantin Ananyev > Acked-by: Chengwen Feng > --- > lib/ring/rte_ring_core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h index > 82b237091b71..1c809abeb531 100644 > --- a/lib/ring/rte_ring_core.h > +++ b/lib/ring/rte_ring_core.h > @@ -120,7 +120,7 @@ struct rte_ring_hts_headtail { struct rte_ring { > char name[RTE_RING_NAMESIZE] __rte_cache_aligned; > /**< Name of the ring. */ > - int flags; /**< Flags supplied at creation. */ > + uint32_t flags; /**< Flags supplied at creation. */ > const struct rte_memzone *memzone; > /**< Memzone, if any, containing the rte_ring */ > uint32_t size; /**< Size of ring. */ > -- > 2.33.0