From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D10142D10; Wed, 21 Jun 2023 08:51:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9B0A42B7E; Wed, 21 Jun 2023 08:51:05 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2089.outbound.protection.outlook.com [40.107.20.89]) by mails.dpdk.org (Postfix) with ESMTP id B9C304068E; Wed, 21 Jun 2023 08:51:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pBX8lcRQTrVmUahkiOnpmIOHRNtPs+9MOcsBtj329YA=; b=zrz+bqItKpYsZiNcuIoLmeCzEwJLOq/rPFO9tQloADb2FL3MOx5xaNw7bhW8lHWpw9cLl1TYxssj05dvQeNCOkY4X5V/qu4u/ifqOYaH6RhJu3mYe1q6WszosUDToNpku0UzctNAW00W5QUfeVHsk63N1/ICyj+B+TrmKuBdabQ= Received: from DUZPR01CA0017.eurprd01.prod.exchangelabs.com (2603:10a6:10:46b::8) by GV1PR08MB8666.eurprd08.prod.outlook.com (2603:10a6:150:83::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Wed, 21 Jun 2023 06:50:47 +0000 Received: from DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:46b:cafe::9d) by DUZPR01CA0017.outlook.office365.com (2603:10a6:10:46b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23 via Frontend Transport; Wed, 21 Jun 2023 06:50:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT039.mail.protection.outlook.com (100.127.142.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23 via Frontend Transport; Wed, 21 Jun 2023 06:50:46 +0000 Received: ("Tessian outbound 8b05220b4215:v136"); Wed, 21 Jun 2023 06:50:46 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d1f50844c370e59b X-CR-MTA-TID: 64aa7808 Received: from 6ed1a5b031e0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E6F3EDD1-0178-4775-A6AE-6044114BD908.1; Wed, 21 Jun 2023 06:50:35 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6ed1a5b031e0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 21 Jun 2023 06:50:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O/Opz/XCHJpIaBmDLDzIJj8GLVjoHP6YCc6USwYL94kuiTMD/KxfE8zUxrwI/svJOmyl9uTUs5qeAjhgFVadjNcqNIq1s8p4469f2ArPwWfefq1B0oA8Qcqq7UT1KKbOv4S27STl2iL0SxCDQ/bJUrwSHQa/ygdvo5WP7U4CAZ3bitGSiWWeAcXBTsPr3mfsnN6wxJY6ruZ9setXCRPfZR0CYm/I5BpShDGhfbactSU6Qj3D6FvTxB5cs0OdONGcFm2RXmQ3LIAvfNB123urh4IKOYoPmoQZQ9rWcGRTETw8vmYRlI5OFXOY8PFlXENu9c6Tb2TEPjFSqZmQME23Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pBX8lcRQTrVmUahkiOnpmIOHRNtPs+9MOcsBtj329YA=; b=jPgsQDke+8fY/MA2OAKxguoAAQOmo1OD5rxhrC9VdjrW1xq6hyeYpIj0ch2tEN36h14LJWLCv8X54qRlzhOkgBD7Uj0sfSmh971KPnD6DcCMGOTQuf4a9k8iXxyTYqu5EY5Vre7wsvJPNkx8/CTI3lgcpv3HWjfDk1jp2Gr7/55Mz8xmamC5QUfe42UBXBtBrMUw4ziGS61KL6vnpsFz7W6RNe3Q2giikeUM4T2wVbO3TZcYUG7Mi5XYkAJLE3GkJrKu1vyBTfqQl4KR8FIERRSbz40t1DbvB5aLrbdoUSLZEAbMTgmNG7IPL5dhLl8ZgUlRpTHDzYDMMcUGaSEzlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pBX8lcRQTrVmUahkiOnpmIOHRNtPs+9MOcsBtj329YA=; b=zrz+bqItKpYsZiNcuIoLmeCzEwJLOq/rPFO9tQloADb2FL3MOx5xaNw7bhW8lHWpw9cLl1TYxssj05dvQeNCOkY4X5V/qu4u/ifqOYaH6RhJu3mYe1q6WszosUDToNpku0UzctNAW00W5QUfeVHsk63N1/ICyj+B+TrmKuBdabQ= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by PAXPR08MB6621.eurprd08.prod.outlook.com (2603:10a6:102:dc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Wed, 21 Jun 2023 06:50:33 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::dd71:31fd:80b0:c4e0]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::dd71:31fd:80b0:c4e0%4]) with mapi id 15.20.6521.023; Wed, 21 Jun 2023 06:50:33 +0000 From: Ruifeng Wang To: "thomas@monjalon.net" , "Zhang, Qi Z" , zhoumin CC: "dev@dpdk.org" , "mb@smartsharesystems.com" , "konstantin.v.ananyev@yandex.ru" , "Yang, Qiming" , "Wu, Wenjun1" , "drc@linux.vnet.ibm.com" , "roretzla@linux.microsoft.com" , "stable@dpdk.org" , "maobibo@loongson.cn" , nd , "david.marchand@redhat.com" , Honnappa Nagarahalli , Tyler Retzlaff , "konstantin.ananyev@huawei.com" , nd , nd Subject: RE: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions Thread-Topic: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions Thread-Index: AQHZgAT1MdYup7blB0m44Ir52qPlGK9P5WaQgAq/RYCALIviAIAAGeyAgAAM2ICAAVTz8IALciOAgAD6RMA= Date: Wed, 21 Jun 2023 06:50:33 +0000 Message-ID: References: <20230424090532.367194-1-zhoumin@loongson.cn> <38333053.10thIPus4b@thomas> <843639876.0ifERbkFSE@thomas> In-Reply-To: <843639876.0ifERbkFSE@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 92AD08FF84005C47B3D6248BC19CABB9.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7080:EE_|PAXPR08MB6621:EE_|DBAEUR03FT039:EE_|GV1PR08MB8666:EE_ X-MS-Office365-Filtering-Correlation-Id: 987d38cc-0a7b-446f-c279-08db7223d79a x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Es6w86cMBmBMItaOEKWw9rbU6B/eXl5HQlPUzDfzjfAZQ9i/raH9f0K4djDq74Segk6LPA7E5sgbjWopGvMIyYOKqptkEgkqYRaewwhiELNcLVGsC4UPTVr9b/wnpHFLP4GtnQVlUDlBQxWIi237/3H8nWvOS+HgyASbSn7ykde0zfv3w1gGk7OhYACbFl9Msug9feYYnxjQe6sJGqFzEElRwplXL4YGT1xTwSJqyGmXYvkQw3uq64MVDIr9zkxj8u5tDVv49UxKWhCWlPx3RVBYZfzwKI1M6XMkiSVSJLY59g94LJLr+h4JZOJPMFWjGEeYuvrGrMq/MI4G/9st97O/KMcKS6J9udpj50DsmS+byCnZDPY7qTZHtvmZuZVIEavUPumf62gWbpUlsQ95xyr2vE46LzE4fKokHUnWeyxyIn6WfZzEpx9x91NdyhYYP3n+K1HhVNhTkOGLPE0+UJNEhBgITQdSeLKpcKJwb09n+7D1aHo6gS4NJeIS/gmZm1Fq+5ziw6k+vKXN4u5oWM0Fo4wLwwqjqCebhu8+FBBObWMd5QqJy2kA1pd161adMNUhHiLkKjnx8MzBvA8sRFpOTLd5CTTOXF4EosVcqbOAw+f/WTOK1O+zi8LizfrRKN1h4Yr6Pj+a0OKNfystyg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(346002)(136003)(396003)(376002)(366004)(451199021)(38070700005)(86362001)(33656002)(38100700002)(122000001)(83380400001)(478600001)(54906003)(110136005)(966005)(7696005)(71200400001)(64756008)(316002)(66446008)(66476007)(4326008)(55016003)(76116006)(66946007)(66556008)(6506007)(53546011)(41300700001)(8676002)(8936002)(186003)(9686003)(26005)(2906002)(7416002)(5660300002)(52536014)(23180200003); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6621 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ad6a7d5e-4886-4df6-c3db-08db7223cf80 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IMK0Gw5OJhUfJMxAX9iRfuyXc/L6fAUAE0JRd9wQ2ElNFhIoa158WiR//I1t6JopbpdCRPKi1dIHNqlyKLhaKJtxryIfaJbwE7cuD4NxhoC7OHAKN2VEcjr64xVyOAXbiQaCKDbeFrW6vLQs0g00VvZP+PbijvDB3kk9uT7DhKtcb7AWmK10CTaAWsiRuU+pp7XojE1bfJKA/qeh8FmrFJqTimTolxQwplrT6WP5E0hiRggbNYxohO0uMYoS0eJKD+3oAWhdCvpDkH05/c8H4ZK+OSRpB4bE4hu7NNF+DleBMeMKRQT+aVtI4SX4EBLqDuuf9uDIxkDTW8Wxy2gCcCwpbXspCl0X4qmIBFNotn9qDJHMuHq0qAJRRJVbwQ6GYezqN5Vo48K0GxSL1z2Ua2c5ZL80yRQr2Zm4aQ5ZiETcwp2xJJCOMikPbtQUGsc768bZASzABSa59uNkLqDcMWE5q0p8FgO+JGTBqmJ48LRYOYZ2zs4VHpi9TwfRKdVp48nNwsITmi85RYzHzuZXosMQalOVJOqZtOrLHiwUCACKHYBUV08JdKY9aJUC1uu9g8Bbb+bJXb2t+lvwD6k3e/q8HyQyziBFwLDGucz8JRgAry0GwWAEQf5onSKVheaetJsqYpRmn5EIVzvArciMJMELjc3wru6Yunq2dtCaBgPZyNc1UdHa1j1iLX87lV+26nkL0cu0gC21lZKyOqOEkhxhDrjiTR/qLlLvCks/9XAg9zqFmZ2gzuptowV+A9Fd X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(376002)(346002)(136003)(396003)(451199021)(46966006)(40470700004)(36840700001)(2906002)(40460700003)(9686003)(186003)(7696005)(82310400005)(45080400002)(82740400003)(81166007)(83380400001)(356005)(336012)(6506007)(26005)(47076005)(966005)(36860700001)(41300700001)(55016003)(54906003)(110136005)(86362001)(316002)(40480700001)(478600001)(70206006)(53546011)(70586007)(450100002)(4326008)(33656002)(8936002)(8676002)(52536014)(5660300002)(23180200003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 06:50:46.9566 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 987d38cc-0a7b-446f-c279-08db7223d79a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8666 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, June 20, 2023 11:53 PM > To: Zhang, Qi Z ; zhoumin ; Ru= ifeng Wang > > Cc: dev@dpdk.org; mb@smartsharesystems.com; konstantin.v.ananyev@yandex.r= u; Yang, Qiming > ; Wu, Wenjun1 ; drc@linux.vn= et.ibm.com; > roretzla@linux.microsoft.com; stable@dpdk.org; maobibo@loongson.cn; nd ; > david.marchand@redhat.com; Honnappa Nagarahalli ; Tyler > Retzlaff ; konstantin.ananyev@huawei.com; nd > Subject: Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx= functions >=20 > 13/06/2023 11:25, Ruifeng Wang: > > From: Thomas Monjalon > > > 12/06/2023 13:58, zhoumin: > > > > On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: > > > > > 15/05/2023 04:10, Zhang, Qi Z: > > > > >> From: Ruifeng Wang > > > > >>> From: Min Zhou > > > > >>>> --- > > > > >>>> v3: > > > > >>>> - Use rte_smp_rmb() as the proper memory barrier instead of > > > > >>>> rte_rmb() > > > > >>>> --- > > > > >>>> v2: > > > > >>>> - Make the calling of rte_rmb() for all platforms > > > > >>>> --- > > > > > [...] > > > > >>> Reviewed-by: Ruifeng Wang > > > > >> Applied to dpdk-next-net-intel. > > > > >> > > > > >> Thanks > > > > >> Qi > > > > >> > > > > > Why ignoring checkpatch? > > > > > It is saying: > > > > > " > > > > > Warning in drivers/net/ixgbe/ixgbe_rxtx.c: > > > > > Using rte_smp_[r/w]mb > > > > > " > > > > > > > > > > > > I'm sorry. Should we never use rte_smp_[r/w]mb in the driver's code= ? > > > > > > No we should avoid. > > > It has been decided to slowly replace such barriers. > > > By the way, I think it is not enough documented. > > > You can find an explanation in doc/guides/rel_notes/deprecation.rst > > > > > > I think we should also add some notes to lib/eal/include/generic/rte_= atomic.h > > > Tyler, Honnappa, Ruifeng, Konstantin, what do you think? > > > > > > > Agree that we should add notes to rte_atomic.h. > > The notes were not there for the sake of avoiding warnings on existing = occurrences. > > With Tyler's rte_atomic series merged, rte_atomicNN_xx can be marked as= __rte_deprecated. > > rte_smp_*mb can be marked as __rte_deprecated after existing occurrence= s are converted. >=20 > Would you like to add some function comments to explain why it is depreca= ted? >=20 Sure. Added notes in patch: http://patches.dpdk.org/project/dpdk/patch/20230621064420.163931-1-ruifeng.= wang@arm.com/