From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C760D42CA8; Tue, 13 Jun 2023 11:25:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F61E41149; Tue, 13 Jun 2023 11:25:48 +0200 (CEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2089.outbound.protection.outlook.com [40.107.105.89]) by mails.dpdk.org (Postfix) with ESMTP id E506140698; Tue, 13 Jun 2023 11:25:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IeClgAkAcpYrGZA+do/PQ62fZJp44vjc7JYlbEbfSnE=; b=ATbO1sV4YzUxokpDGGajjBYvEoiyi6edMRgnKOsdMdqxBH19Za/O0uXOn1C+vkQU8jM3XAtayEQ1eDC27C61l7irLCQ6uZ21tCNWr6Ky24ipw7mBkxHW6vAkmmCElSRZFAKq7aOloVR8crmyKwXlTKZJmU7B6HCzprI5h8lAHbQ= Received: from AS8PR07CA0053.eurprd07.prod.outlook.com (2603:10a6:20b:459::20) by AS8PR08MB6198.eurprd08.prod.outlook.com (2603:10a6:20b:29f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Tue, 13 Jun 2023 09:25:43 +0000 Received: from AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:459:cafe::48) by AS8PR07CA0053.outlook.office365.com (2603:10a6:20b:459::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.21 via Frontend Transport; Tue, 13 Jun 2023 09:25:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT039.mail.protection.outlook.com (100.127.140.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.23 via Frontend Transport; Tue, 13 Jun 2023 09:25:43 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Tue, 13 Jun 2023 09:25:43 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 39e20b77c8367c46 X-CR-MTA-TID: 64aa7808 Received: from 0acd226cd244.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FAF1F45B-931F-4A80-B993-2AE9C6FEE819.1; Tue, 13 Jun 2023 09:25:32 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0acd226cd244.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 13 Jun 2023 09:25:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kzt2yg7KN+/sHc1Lto/xSLbtug3gmM39zOFqP31t/ufEGy5UFF9TkrumllXl7z/Q4i8reG35LP+HbdTEf+MDC10YPUTgWfdD8ovIxBmN/20YceszyZinF3EHonTrB5AR6h/IRMpdtoXC3XIufkKkgkwN7uLMGnPePpJx/cocEiNdFwpug6GdIctalv1ggYusNaeZOxYRCE0JnzLLwWaza6LPmSu5VDm3nd7tEMD4rcXCHxsYDdhmYIVZbFMXso3oUP2QZycjzLAKOYiryeg1QEKXXwbLf8P32q5Pb8U4k0zjSOSFlQ2XbchxYORfLVopTyk5NCu+gUWpRaOGlj+OXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IeClgAkAcpYrGZA+do/PQ62fZJp44vjc7JYlbEbfSnE=; b=LZWF0muZ/uIHVzgWZHtrpmQIrns7EwgabLYhACJjwVf756jdfuiOG7O4xee0ug0s+rgHw4V3e/aTfpG3K+mPGpp6/1B4ns9RMuMSc3VYfd/9R7yhDV1ejleUhWqBJlgf632xdxFVKByDhm4Crzn41oHJDOqKHCjh2yMnADeBvIKroim4iUndnoIM5BWsPynuQshm6xTMlZKMzyKd30ZjSsnGoip8gLeB4N0ghpkvvsR9GBmUHNSJbiORDa0SC6XVZoO9CIWE34/Kaphu9bczbv9D3xZTYcOJ9pz/3eHUwosMdc9x+02Mh4ulp3TBlP13Rh5zR3gaglwPsvjfJC11lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IeClgAkAcpYrGZA+do/PQ62fZJp44vjc7JYlbEbfSnE=; b=ATbO1sV4YzUxokpDGGajjBYvEoiyi6edMRgnKOsdMdqxBH19Za/O0uXOn1C+vkQU8jM3XAtayEQ1eDC27C61l7irLCQ6uZ21tCNWr6Ky24ipw7mBkxHW6vAkmmCElSRZFAKq7aOloVR8crmyKwXlTKZJmU7B6HCzprI5h8lAHbQ= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by PAXPR08MB6574.eurprd08.prod.outlook.com (2603:10a6:102:12d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Tue, 13 Jun 2023 09:25:28 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::dd71:31fd:80b0:c4e0]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::dd71:31fd:80b0:c4e0%4]) with mapi id 15.20.6477.028; Tue, 13 Jun 2023 09:25:28 +0000 From: Ruifeng Wang To: "thomas@monjalon.net" , "Zhang, Qi Z" , zhoumin CC: "dev@dpdk.org" , "mb@smartsharesystems.com" , "konstantin.v.ananyev@yandex.ru" , "Yang, Qiming" , "Wu, Wenjun1" , "drc@linux.vnet.ibm.com" , "roretzla@linux.microsoft.com" , "stable@dpdk.org" , "maobibo@loongson.cn" , nd , "david.marchand@redhat.com" , Honnappa Nagarahalli , Tyler Retzlaff , "konstantin.ananyev@huawei.com" , nd Subject: RE: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions Thread-Topic: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions Thread-Index: AQHZgAT1MdYup7blB0m44Ir52qPlGK9P5WaQgAq/RYCALIviAIAAGeyAgAAM2ICAAVTz8A== Date: Tue, 13 Jun 2023 09:25:28 +0000 Message-ID: References: <20230424090532.367194-1-zhoumin@loongson.cn> <3202143.AJdgDx1Vlc@thomas> <38333053.10thIPus4b@thomas> In-Reply-To: <38333053.10thIPus4b@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0037A4B97599F84BBA47C83C8F839155.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7080:EE_|PAXPR08MB6574:EE_|AM7EUR03FT039:EE_|AS8PR08MB6198:EE_ X-MS-Office365-Filtering-Correlation-Id: d97ebdf4-3808-4206-68fa-08db6bf029aa x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: quBiqSTAT/XNKDKsCSa2BmuEVAvrtZW/Oz8yxnWocF/qIG7ncEvravv345Scee/k7A/aYVllVXcrRUPoTtWa4tbGoO4rUXcge/vkE4n4kcLWZh/UBQ9KTfDGbZcmV03Tewm2hOXRpIwjlAlOpqBV5zdI/Hhne+DGqhLNVnD4fTmLmM0+3bLxnqW6Ke1XSj3BYKVsoSyLp2b52a/3S8Y7tIqM5wyJy1BMAs4ipJNQXjiQiUqXKz6AROIfWlPiFNgV4iyo3dAEmCv3URn+Wb7nGaMjejIWBvva1IGF9vSHsxrFVD+3WJLxj5ohKYnyICL3KlFLiHGd1s/VODntKg3Vu5KdfITNSz1QQCVufFmKLjNg+61tSYSok2Khu3sVQUfme5lF+3CoHe6SOKoc55R/fKnPHFhN6yvMf8A3w+8WhsJmSdt9O7A2MkTNLl69V/toZZkSuxYurjRzVyFGV8dGupql/uOMX5UeEeZaliEVNg81MT6a75ntUVqti39hxfkVDWlZ3baTgS6OFLFU6a5w1g9WpJcynDzc1pR0L+1jlEgBXrk1DXvf/UENv9LKZDm7ewLDUaXYMInQeabTyB6mLLg6Tht84zf6e+Sfwfi2idG5VzS9nodvw1AvFsEe/ZGs/brq9NIhJir7np//tKXDCg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(451199021)(38070700005)(33656002)(86362001)(66556008)(66446008)(66476007)(4326008)(54906003)(478600001)(110136005)(66946007)(64756008)(316002)(76116006)(71200400001)(7696005)(55016003)(7416002)(8936002)(5660300002)(2906002)(8676002)(52536014)(41300700001)(38100700002)(122000001)(6506007)(26005)(9686003)(186003)(53546011)(83380400001)(23180200003); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6574 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d05244fe-9bbb-4df9-54c9-08db6bf0209d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GNw+ndo/VxkyK/tyaR+3LYPpGNLGJDtB1Qzr+36jRm7CGV+NYxm0zaGJOkm7HNcPIZlw7tmIgYnNPeKa3u0BUuy3gg2nfXNf4rMelaJ+xAMG9F3Dc1io318GgF8oarlf6ZFnR7376XZWtlw1E6H1VHsIXHzTTtbjZi0F7F+BjmPam2d6TZP+ikdDWCYPPFD73pKrgisnAp1kCcG2gPPHm5ZqNJVbIW2pAzPeLgZiX7n1CfrUvHwxpyEKAEve/4iQ2n6QaEWx9u3RdoRzaTA4qhbMiDt53aP0Y2oxoYQL0hXODZMXao15Qv10M/TCbbuugbzzVx67fpUgBXSMOF/79UoulE4CTXsdC1ooYdb4r4iER2NC5YwaEBSJE/+TiBBcipfR4ogXHMjFLzkNPnN6lyRtjRgaRqfCnrLFhgPiy6d+DJRHr5s2Jb1nXVsBGjRlL9N0D6gvLcoOIXG0P9NuuahLdukZ7I77igJ3S2GEthHuBhv7AWtYi1nOUsDY4OnqTaM2TQUg/IIftygzziaj50DlVP9uEbqfkveqlce0d3mUKnhFNLHXFYRHXFSedU4t+0vOvecfANidODeSK4CBufXhC/AyaSaztpuZtcIRaC8QQBcYLBuMdXIDn4CCtuXgUrt8qn5vRpSOdHcCkq9rwB9mbhqJVRTYd9mFjmAAOTPkZFTAGbvhl5Bt4kM4HE1Wk/a9DDC53wXcEb1ACOt76XA2qtBwYsSYTDafKvkJDvr8OQHvjSts8hziV5rrZvxc9us3tKLHIxnGRYKkX/t3iQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199021)(46966006)(40470700004)(36840700001)(54906003)(4326008)(450100002)(47076005)(70206006)(70586007)(336012)(186003)(478600001)(2906002)(110136005)(45080400002)(8676002)(316002)(41300700001)(82310400005)(86362001)(40460700003)(7696005)(52536014)(356005)(36860700001)(33656002)(6506007)(53546011)(9686003)(8936002)(83380400001)(82740400003)(26005)(5660300002)(40480700001)(81166007)(55016003)(23180200003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 09:25:43.7632 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d97ebdf4-3808-4206-68fa-08db6bf029aa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6198 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, June 12, 2023 8:45 PM > To: Ruifeng Wang ; Zhang, Qi Z ; zhoumin > > Cc: dev@dpdk.org; mb@smartsharesystems.com; konstantin.v.ananyev@yandex.r= u; Yang, Qiming > ; Wu, Wenjun1 ; drc@linux.vn= et.ibm.com; > roretzla@linux.microsoft.com; stable@dpdk.org; maobibo@loongson.cn; nd ; > david.marchand@redhat.com; Honnappa Nagarahalli ; Tyler > Retzlaff ; konstantin.ananyev@huawei.com > Subject: Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx= functions >=20 > 12/06/2023 13:58, zhoumin: > > On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: > > > 15/05/2023 04:10, Zhang, Qi Z: > > >> From: Ruifeng Wang > > >>> From: Min Zhou > > >>>> --- > > >>>> v3: > > >>>> - Use rte_smp_rmb() as the proper memory barrier instead of > > >>>> rte_rmb() > > >>>> --- > > >>>> v2: > > >>>> - Make the calling of rte_rmb() for all platforms > > >>>> --- > > > [...] > > >>> Reviewed-by: Ruifeng Wang > > >> Applied to dpdk-next-net-intel. > > >> > > >> Thanks > > >> Qi > > >> > > > Why ignoring checkpatch? > > > It is saying: > > > " > > > Warning in drivers/net/ixgbe/ixgbe_rxtx.c: > > > Using rte_smp_[r/w]mb > > > " > > > > > > I'm sorry. Should we never use rte_smp_[r/w]mb in the driver's code? >=20 > No we should avoid. > It has been decided to slowly replace such barriers. > By the way, I think it is not enough documented. > You can find an explanation in doc/guides/rel_notes/deprecation.rst >=20 > I think we should also add some notes to lib/eal/include/generic/rte_atom= ic.h > Tyler, Honnappa, Ruifeng, Konstantin, what do you think? >=20 Agree that we should add notes to rte_atomic.h. The notes were not there for the sake of avoiding warnings on existing occu= rrences.=20 With Tyler's rte_atomic series merged, rte_atomicNN_xx can be marked as __r= te_deprecated. rte_smp_*mb can be marked as __rte_deprecated after existing occurrences ar= e converted.