DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"Honnappa Nagarahalli" <Honnappa.Nagarahalli@arm.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"christian.ehrhardt@canonical.com"
	<christian.ehrhardt@canonical.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: RE: [PATCH v1] config/arm: add armv7 native config
Date: Fri, 31 Dec 2021 07:11:43 +0000	[thread overview]
Message-ID: <AS8PR08MB708046FE896CD861104441489E469@AS8PR08MB7080.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1637232351-21856-1-git-send-email-juraj.linkes@pantheon.tech>

> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Thursday, November 18, 2021 6:46 PM
> To: thomas@monjalon.net; david.marchand@redhat.com;
> bruce.richardson@intel.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; ferruh.yigit@intel.com;
> christian.ehrhardt@canonical.com
> Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1] config/arm: add armv7 native config
> 
> Arvm7 native build fails with this error:

Typo, 'Armv7'

> ../config/meson.build:364:1: ERROR: Problem encountered:
> Number of CPU cores not specified.
> 
> This is because RTE_MAX_LCORE is not set. We also need to set
> RTE_MAX_NUMA_NODES in armv7 native builds.
> 
> Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>  config/arm/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 213324d262..57980661b2 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -432,6 +432,8 @@ if dpdk_conf.get('RTE_ARCH_32')
>      else
>          # armv7 build
>          dpdk_conf.set('RTE_ARCH_ARMv7', true)
> +        dpdk_conf.set('RTE_MAX_LCORE', 128)
> +        dpdk_conf.set('RTE_MAX_NUMA_NODES', 8)
>          # the minimum architecture supported, armv7-a, needs the following,
>          machine_args += '-mfpu=neon'
>      endif
> --
> 2.20.1
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

  reply	other threads:[~2021-12-31  7:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 10:45 Juraj Linkeš
2021-12-31  7:11 ` Ruifeng Wang [this message]
2021-12-31 17:23 ` Stephen Hemminger
2022-01-25 10:08 ` [PATCH v2] " Juraj Linkeš
2022-02-10 16:34   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8PR08MB708046FE896CD861104441489E469@AS8PR08MB7080.eurprd08.prod.outlook.com \
    --to=ruifeng.wang@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=juraj.linkes@pantheon.tech \
    --cc=nd@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).