From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7BD541D49; Thu, 23 Feb 2023 08:28:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99C2843008; Thu, 23 Feb 2023 08:28:00 +0100 (CET) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2084.outbound.protection.outlook.com [40.107.104.84]) by mails.dpdk.org (Postfix) with ESMTP id 199874021F for ; Thu, 23 Feb 2023 08:28:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wMzEScxMAa5rxRSpXomsu3I6aZ4lcz3TeuJ7i8pLZnQ=; b=p7TLnJCjGnaX9v1EZML8Sra4VQ0rBDCTwpumGPDtaS/ptvA5husx+Hg6/FuCZPLhEDkuUcxtY+ONiy0tb07IN7SZZHIxCNzsmN8Kh0WvVcF4A+UWPCH5YcDFwuubOTJPKAgijqnCLet5NaPPLUs2mNOsm7jZbAVs5utft0Fepyo= Received: from DB6PR0201CA0028.eurprd02.prod.outlook.com (2603:10a6:4:3f::38) by GV1PR08MB8081.eurprd08.prod.outlook.com (2603:10a6:150:97::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.20; Thu, 23 Feb 2023 07:27:58 +0000 Received: from DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::91) by DB6PR0201CA0028.outlook.office365.com (2603:10a6:4:3f::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.20 via Frontend Transport; Thu, 23 Feb 2023 07:27:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT047.mail.protection.outlook.com (100.127.143.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21 via Frontend Transport; Thu, 23 Feb 2023 07:27:57 +0000 Received: ("Tessian outbound b1d3ffe56e73:v132"); Thu, 23 Feb 2023 07:27:57 +0000 X-CR-MTA-TID: 64aa7808 Received: from 32bb63ca36f9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 07DE1DCC-B9B2-4610-8895-38D3030DD63A.1; Thu, 23 Feb 2023 07:27:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32bb63ca36f9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 23 Feb 2023 07:27:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PYGV05OJG/5cgFGUknP8cAcAQ1V/nP4pfkfiYdzPvkkWYV8Jtzj9DwYzNi+GGbTxCWOS8S+8mXncKGSK56r6m55aLZyW2hjDg4y9JSlVnCG42ihZ7SC9G4VMemP83SCZSn0XdhcuuKQTMGKg8kg8saK+blhoAFmZF28tBIvyyoOHfubb+GvjTtz7iRv7HzOyB5eAuF25HtpKn3S1RkeFvMyY/Mcal+QcHaMs8oHscN/nTet8brF+IaKesYD55E4pbkcpJc1QizSGLf0MRgouyco0ZpC1iqcDCv9T8dpWgOh5A7KazEIJba7jTmulnaLaflZKZN1lQUpQYhl8u5yZgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wMzEScxMAa5rxRSpXomsu3I6aZ4lcz3TeuJ7i8pLZnQ=; b=gCAQg9u+4eoaid/BIQvzhyKSEfCKGlZtqu+thYEXG5PuK0Zft93P7PE7b8xsXCyCkcnJwWeYbXIZFeeYoY2MLQQMtYn9KyMlNc5vr7fx5l8otF6/tT+IOx+xDfKrxRgSbByTPaIZIxbfoHnk9D3LbNOGglV/1XSb7mOJqaCl4cns9tiNkHNCIKapYcWfnLg3Nc3IXXDRv7kmreq8FA0ayQSYjgy7HFTHMOeLPDOoZhy01wFmgA8+NZdXD0Uam4bjbYxQwettuQGYvi551bE15fEvZo4oNIvekJFTjKgQ2aNWZmKQK6PmYr6PYrjeNxInapS5lfbDXIS/BNcWikydVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wMzEScxMAa5rxRSpXomsu3I6aZ4lcz3TeuJ7i8pLZnQ=; b=p7TLnJCjGnaX9v1EZML8Sra4VQ0rBDCTwpumGPDtaS/ptvA5husx+Hg6/FuCZPLhEDkuUcxtY+ONiy0tb07IN7SZZHIxCNzsmN8Kh0WvVcF4A+UWPCH5YcDFwuubOTJPKAgijqnCLet5NaPPLUs2mNOsm7jZbAVs5utft0Fepyo= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by AS8PR08MB10313.eurprd08.prod.outlook.com (2603:10a6:20b:5c1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Thu, 23 Feb 2023 07:27:50 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::3e2c:a99c:db5b:601f]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::3e2c:a99c:db5b:601f%5]) with mapi id 15.20.6134.021; Thu, 23 Feb 2023 07:27:50 +0000 From: Ruifeng Wang To: Stephen Hemminger , "dev@dpdk.org" CC: Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , nd , nd Subject: RE: [PATCH v11 21/22] hash: move rte_hash_set_alg out header Thread-Topic: [PATCH v11 21/22] hash: move rte_hash_set_alg out header Thread-Index: AQHZRwh9iWfbb8E4p0WJsgN33b7Meq7cGurQgAAFVnA= Date: Thu, 23 Feb 2023 07:27:50 +0000 Message-ID: References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230222215541.158205-1-stephen@networkplumber.org> <20230222215541.158205-22-stephen@networkplumber.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 656FA13E87BDA7409AE88EA502FB493A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7080:EE_|AS8PR08MB10313:EE_|DBAEUR03FT047:EE_|GV1PR08MB8081:EE_ X-MS-Office365-Filtering-Correlation-Id: ffae9940-10ee-4e35-1c07-08db156f7c90 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Zt+qAbiAToAhVttI0NC8HYiDMQmuim9rTOs86l+Ah4j0O/ty10WSLs8d9009po+2nSSubqe8l4oJQuVq3YCyP2pnmMJo9tMjPKMAyOG0GDZGYZ2GGLXQlRxQL3oOYWs+2mX1vsOGPd3O+VeEj2PbRcyVGqhuMvF7u3PPUG9Rn4UseDV/nzEZA8vGs82ITsUsacTkBuxgVmn1WKkQkhNMNaLxJvIqlJGcgyXPWojrTD728UBzO5aHBG4B4yyTXDZ/NmXqFMr+Z1rQ+MCPu6TYgejd/mc5O78IT5k7QyU8Im7bjmuOrVhZRqeZ2kH+bdY4GsJuypNKazKtxOk95lAcNexrJcXgOuEE8NwmNWrUdiUS/TVzoMNDhXDF0GEYRu2UVpMhAC4/koQ5+cgFASeTbmfiDGEY6TOrXsB32IRMvbxr9azXJAlh0BZHitYPvFpNPmB2VPs26BLrWKL4tjdi/fk4YwLVo1t+nZU5Y80ipfxszy1olvdRkmOzwF0n/LnihgO3Us02q6EUHQ0GfQJ9Ajk3+jSdqNhAn4gXzihk2hU1rOcrgy368464qvjq09DDGOHmHoM1PjBdrlIMASiPbc1eG0txQGTN16mTM8KcYG/VJ6y5+2gRn+hZRtVUUpfaVx5EgHJEL/3owCle8z5tHIBvc0t+V7qioMqkQiFWXcWoI9hozHUoZI/Voij0uDZ8zEKZspwfGhmRQe+Ua4J0DQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(136003)(39860400002)(376002)(346002)(396003)(451199018)(83380400001)(38100700002)(122000001)(33656002)(86362001)(38070700005)(41300700001)(2906002)(52536014)(5660300002)(316002)(8936002)(26005)(186003)(55016003)(9686003)(4326008)(53546011)(6506007)(2940100002)(71200400001)(54906003)(8676002)(66446008)(110136005)(66556008)(7696005)(66476007)(478600001)(76116006)(64756008)(66946007); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10313 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0959f917-cb0e-4105-0bee-08db156f786b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rwcit6XH5fMQV1X+zoopKeE3jc8SZcBTVhglYwXdDi+Zz+qPqkOaH/73Qyw0udhP5VX+FkMsCXVG8/UlHDTNlsgAaVsmv7W5Sm1St4uFeiCF6zz/FSMX/08DVenXNj8Rx1u/iFaB9+x4tkoE9F4ET8cV0Rpqh9uaPmW/arP1A88dQgpb5uIw8+j5UJi0tNcUYiYHh+lrO9RcA3duSMeKwP8dp6S9fZt7iKHnf5t1qn6IgHVrRnhGSDWPVVpVePGLmzgCiUOgIoB/ne8mUt311Aa/jBSh8Ksf2naO8ESINDKz4zcDIq+MRcriW7/7FwoRKp8OwAzFPKQcLsPzx+oYi+qBuhUXpU5URzBHgu+NtpSP0DpptgaJBcn3NQsBgKpyN9y8e+pE0okzq3ncT4EjOxGrQvp5G74eoQb75RbC3phT21Vktgh4ioXVtX9iSShukPXg2OxTxZR4+DomCDxZXjoGzw7lkTgIJKPKdAMcOkuOrL0vrpCE9MPjp5FeazjBvGXnfWWEammRgNtdW6wOHd7zAvM6M50SQqUS+IvmonxMYO+8hIBOlS/3WPI0//6AP7HNpUSlzKdN8B2sdbz2suY3wX5S9IzbzjckCj85h+nglOrgnlv9MFUlDoXvgsdfj/asNnNjDpFBTzTVoieELndf12U22rqcf7E8Z5WbOmYivyqZkFt/wDwU6qeJJKGqQX0n/3vop1/4807LrkKBVQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230025)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199018)(46966006)(36840700001)(40470700004)(40460700003)(2940100002)(9686003)(2906002)(82740400003)(81166007)(83380400001)(356005)(52536014)(8936002)(8676002)(5660300002)(4326008)(41300700001)(36860700001)(70586007)(70206006)(40480700001)(7696005)(336012)(55016003)(47076005)(478600001)(6506007)(53546011)(26005)(186003)(86362001)(82310400005)(33656002)(54906003)(316002)(110136005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 07:27:57.8429 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ffae9940-10ee-4e35-1c07-08db156f7c90 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8081 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ruifeng Wang > Sent: Thursday, February 23, 2023 3:11 PM > To: Stephen Hemminger ; dev@dpdk.org > Cc: Yipeng Wang ; Sameh Gobriel ; Bruce > Richardson ; Vladimir Medvedkin ; > nd > Subject: RE: [PATCH v11 21/22] hash: move rte_hash_set_alg out header >=20 > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Thursday, February 23, 2023 5:56 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Yipeng Wang > > ; Sameh Gobriel ; > > Bruce Richardson ; Vladimir Medvedkin > > ; Ruifeng Wang > > Subject: [PATCH v11 21/22] hash: move rte_hash_set_alg out header > > > > The code for setting algorithm for hash is not at all perf sensitive, > > and doing it inline has a couple of problems. First, it means that if > > multiple files include the header, then the initialization gets done > > multiple times. But also, it makes it harder to fix usage of RTE_LOG(). > > > > Despite what the checking script say. This is not an ABI change, the > > previous version inlined the same code; therefore both old and new code= will work the > same. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/hash/meson.build | 1 + > > lib/hash/rte_crc_arm64.h | 8 ++--- > > lib/hash/rte_crc_x86.h | 10 +++--- > > lib/hash/rte_hash_crc.c | 68 > > ++++++++++++++++++++++++++++++++++++++++ > > lib/hash/rte_hash_crc.h | 48 ++-------------------------- > > lib/hash/version.map | 7 +++++ > > 6 files changed, 88 insertions(+), 54 deletions(-) create mode > > 100644 lib/hash/rte_hash_crc.c > > > > diff --git a/lib/hash/meson.build b/lib/hash/meson.build index > > e56ee8572564..c345c6f561fc > > 100644 > > --- a/lib/hash/meson.build > > +++ b/lib/hash/meson.build > > @@ -19,6 +19,7 @@ indirect_headers +=3D files( > > > > sources =3D files( > > 'rte_cuckoo_hash.c', > > + 'rte_hash_crc.c', >=20 > I suppose this list is alphabetically ordered. >=20 > > 'rte_fbk_hash.c', > > 'rte_thash.c', > > 'rte_thash_gfni.c' > > > diff --git a/lib/hash/rte_hash_crc.h b/lib/hash/rte_hash_crc.h index > > 0249ad16c5b6..e8145ee44204 100644 > > --- a/lib/hash/rte_hash_crc.h > > +++ b/lib/hash/rte_hash_crc.h > > @@ -20,8 +20,6 @@ extern "C" { > > #include > > #include > > #include > > -#include >=20 > A couple of files need update with this change. > rte_cpuflags.h should be included in rte_fbk_hash.c (for ARM) and rte_efd= .c. OK, I see the changes already there in other patches in the same series. Please ignore this comment. Thanks. >=20 > > -#include > > > > #include "rte_crc_sw.h" > > >