From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D79ED41D5F; Fri, 24 Feb 2023 10:45:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64E7E40697; Fri, 24 Feb 2023 10:45:41 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2080.outbound.protection.outlook.com [40.107.7.80]) by mails.dpdk.org (Postfix) with ESMTP id 05DBF40693 for ; Fri, 24 Feb 2023 10:45:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4/ao/gCtMmcc7TYmVHAmjEHWz4kHgWw4OXnjMcTO4JQ=; b=PrAfzvhEGxyYmOfvWJBEjDE8lDhO9/zrfiSLc4c4Hrn+6kCvL5jtnmaoN4PKHwcVHHH1Nrjp5Vbf5BseEIXsmoPqyLViIEhT+swBRqSh8LJmLyWRErFW/+SB0Hyb9bEkAph7gn10651imKgO/OHGVIXGciONrtImZ2vttboWQ+E= Received: from DUZPR01CA0107.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bb::25) by PAXPR08MB6493.eurprd08.prod.outlook.com (2603:10a6:102:15a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 09:45:31 +0000 Received: from DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4bb:cafe::6) by DUZPR01CA0107.outlook.office365.com (2603:10a6:10:4bb::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21 via Frontend Transport; Fri, 24 Feb 2023 09:45:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT040.mail.protection.outlook.com (100.127.142.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.11 via Frontend Transport; Fri, 24 Feb 2023 09:45:31 +0000 Received: ("Tessian outbound 6e565e48ed4a:v132"); Fri, 24 Feb 2023 09:45:31 +0000 X-CR-MTA-TID: 64aa7808 Received: from 95e49ed396a5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FD2ADB03-FF58-456D-AFDC-E1981120A368.1; Fri, 24 Feb 2023 09:45:26 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 95e49ed396a5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 24 Feb 2023 09:45:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D4332Zf8ighvg3NYUQGzmrKA16L5y5bpL+MuTMxpKbc/kDDq8Bn2JBcgjVl4FS5ITYQH0sEQ4Tjm3yvk+MP57xDhEj9qQvZnhmIMk/tk2BGNpdSwYcok72F68zUm/L+Zw9XFC1C903X8tg4dh6QpvM3WDsHCgramSzMRzIS2biulWRIuj9qzng4bWG7TBSvDK8nVBq+SVxWJD2zzeB8Hy8XhxyfckmTmiPdQRhQgITyK9PHJrty98lL+njiZVwC+DyS2je2tMxbeG2DTuqyqdoKIseJKDUESIxwD8esOsQ7VcrS7bPkBSie1mnoQAEq8lmFMxSwI519s9pLs41DkAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/ao/gCtMmcc7TYmVHAmjEHWz4kHgWw4OXnjMcTO4JQ=; b=RAfingQYGlkYqR8TokBCjcIqOVGVzO95+ZTOpWv18ETTL+2IjEPh4JO0gpZlp3+30G0WDsaiI/+UPmyMcbcSuJPO9WbQK+KacY5yA+BXv5vYq8fW/94+xjmloxIB5rIB4Uu8Wd4GYtG6VoB+QxQvszGcXbzungXENj0Q/dtK7t1FjGwuDN1Su8yPH86llI6X75RQGCRfxV4ilT5xMLQuuH8rQ0DgK/Zk5txpbXssd6SFxmQ440yXy60lQMNiuQcshnM5AsNH2e2A4Ya68c2Jo3LygTcSbDzDHWLJXg6UGK0ym3xOo1ThwqQMXm1Rj71zZm7nZuPcfB41oHcYThJbaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4/ao/gCtMmcc7TYmVHAmjEHWz4kHgWw4OXnjMcTO4JQ=; b=PrAfzvhEGxyYmOfvWJBEjDE8lDhO9/zrfiSLc4c4Hrn+6kCvL5jtnmaoN4PKHwcVHHH1Nrjp5Vbf5BseEIXsmoPqyLViIEhT+swBRqSh8LJmLyWRErFW/+SB0Hyb9bEkAph7gn10651imKgO/OHGVIXGciONrtImZ2vttboWQ+E= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by PA4PR08MB6016.eurprd08.prod.outlook.com (2603:10a6:102:e3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 09:45:24 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::3e2c:a99c:db5b:601f]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::3e2c:a99c:db5b:601f%6]) with mapi id 15.20.6134.024; Fri, 24 Feb 2023 09:45:23 +0000 From: Ruifeng Wang To: Stephen Hemminger , "dev@dpdk.org" CC: Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , nd Subject: RE: [PATCH v11 21/22] hash: move rte_hash_set_alg out header Thread-Topic: [PATCH v11 21/22] hash: move rte_hash_set_alg out header Thread-Index: AQHZRwh9iWfbb8E4p0WJsgN33b7Meq7d2wJg Date: Fri, 24 Feb 2023 09:45:22 +0000 Message-ID: References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230222215541.158205-1-stephen@networkplumber.org> <20230222215541.158205-22-stephen@networkplumber.org> In-Reply-To: <20230222215541.158205-22-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3993C8746535514885C753264AB9A997.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7080:EE_|PA4PR08MB6016:EE_|DBAEUR03FT040:EE_|PAXPR08MB6493:EE_ X-MS-Office365-Filtering-Correlation-Id: c821d0ab-2a7b-4be4-cd47-08db164bdeba x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qUcm4ljhX0PzcDJAhK8mcjMN1XuTT6/T+PC1vKegkQsNhHrH6Ew6rOa63cA4u0bW5ScXTKE9nCww5BH/gUjBnFwujfpkW6457A/T3BMYFT4DVJdHZg9ngHvBJxjXe4nxqaGvEhMhkdNVZkbJqOGmCW7zVvGrXzxOKnv0CRe5ub0F+1LI4vucQ3M7mr5szjPO85fRvQQLj5RzWdp/xN636mihbt0jOPg5+mjwOdI9rRNmNjRroFkpPR/R/t1h2aV9zGTnpyEnw/W2RGAkx2nEw4wF29Gz6m3JdaljHojbVwFmMO5pKIpJXDnm5Z1bIcSEvkJqIa76qrMdi759dFMJEdaNj7wqcvqPkxY2tex9zFqwqv2VfdofNqlEo2GRccVjBGdM7cBPLea405ulzmcsgv73A0eYq28MiKvvpLUvmggB888yyrvi9vDA0Pn13CpLuxRgTQlBr4gyvrCUS7AVsQ7asK1nf0kpMMVYvQ1eR5LOKtAZyYymhuderiWi7cMSpd5dKy6vWRZe+FVT49bkZeUV/xAL4BliHnN0qr/in9a5yh7v0rqRokSCAFBNTAAjpBf3eXlYjof1snICx2c3fMJ7c9cqIxDbItv2wFykD9qe7UP8sqa3drf2pUaGTW6dXpJDyvmiloFKWH1Yc61uGDDfPVr2V4Abaf7z4ttFx4fG+C0FVlbIjq9r89KiWfOQPgqfVYssB5cUUQmf1010PA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39860400002)(346002)(396003)(136003)(376002)(451199018)(8936002)(7696005)(33656002)(71200400001)(55016003)(66556008)(2906002)(38070700005)(86362001)(122000001)(110136005)(54906003)(66476007)(66946007)(38100700002)(186003)(4326008)(52536014)(316002)(5660300002)(83380400001)(64756008)(26005)(9686003)(6506007)(8676002)(53546011)(76116006)(66446008)(478600001)(41300700001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6016 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a05949f0-2233-4a67-6094-08db164bd938 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jla/MMlMH6BtgCkJTdmq/J7n6sGrNN2Vx3mIwFZOoa0jLmf+VWCpqNO8+wEwAUk0eSKtcddS4d3U141+1wmQlYEcTtDr+bNpCZ6YhlFzXzctCavg4e2y0PjX89OeWs0B3MRwqSiAFK7j55XPZONYDcZuzn/eB0Y1bbuMw7kdNoil4HeDFkLJ5jVZuSl/kyfHUT4m/zzHBvG0JiVvnhVytai8pkN9SzRS98zT4iiyYZmpwExYUaLluayMemZcikBLVvNxL1gXpiHD2w7uQ4mbYuIh95WTOHkcA3raDa4O0vKyNXLKPIfq/J0pvOferD7Mn+2DPh6rs4sHOxNUrHUWZFhqOj6VsP99C4aro9HlW5HRlcATOvdLo5F1alCy3BiIp1JXd/K5GVywxDnUibIxZyez/ePyegbVPUgSlL6becJ7OFR4pe4JLx4DcDSNUkZ3aaxUFvWeiequoQCeLV5SFXoaHnNVKuerQ8OQXUF7jHZfZ+qnRWvzB0ssiUPDmolUJh8klclF36X64xNiDfmhfs3GsC9uBuADQZ50E5mZJ6hjdzUKLEX35ZHY/pNDoQk248IzXRR4f4Uucti0kluroumomR+5g8KqW8ciDM1CS2YMQGRcVB0V0RG0wDK0Q65GeKJGSBi8lajsfuxMGRfWJ2P5joJaQBs6VR/DKoRifs3uddKKJJsrwv3Q/MBALRfN4+CsKGOCTMtPRsZY1B1MSg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230025)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199018)(36840700001)(46966006)(40470700004)(86362001)(478600001)(41300700001)(356005)(55016003)(40480700001)(33656002)(36860700001)(4326008)(9686003)(83380400001)(2906002)(70206006)(70586007)(316002)(336012)(8936002)(5660300002)(52536014)(110136005)(8676002)(47076005)(186003)(26005)(54906003)(6506007)(81166007)(40460700003)(53546011)(7696005)(82310400005)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 09:45:31.8199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c821d0ab-2a7b-4be4-cd47-08db164bdeba X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6493 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, February 23, 2023 5:56 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Yipeng Wang ; > Sameh Gobriel ; Bruce Richardson ; > Vladimir Medvedkin ; Ruifeng Wang > Subject: [PATCH v11 21/22] hash: move rte_hash_set_alg out header >=20 > The code for setting algorithm for hash is not at all perf sensitive, and= doing it inline > has a couple of problems. First, it means that if multiple files include = the header, then > the initialization gets done multiple times. But also, it makes it harder= to fix usage of > RTE_LOG(). >=20 > Despite what the checking script say. This is not an ABI change, the prev= ious version > inlined the same code; therefore both old and new code will work the same= . >=20 > Signed-off-by: Stephen Hemminger > --- > lib/hash/meson.build | 1 + > lib/hash/rte_crc_arm64.h | 8 ++--- > lib/hash/rte_crc_x86.h | 10 +++--- > lib/hash/rte_hash_crc.c | 68 ++++++++++++++++++++++++++++++++++++++++ > lib/hash/rte_hash_crc.h | 48 ++-------------------------- > lib/hash/version.map | 7 +++++ > 6 files changed, 88 insertions(+), 54 deletions(-) create mode 100644 > lib/hash/rte_hash_crc.c >=20 Acked-by: Ruifeng Wang