From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DCCFA0C4B; Tue, 9 Nov 2021 06:40:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF7C140687; Tue, 9 Nov 2021 06:40:06 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70057.outbound.protection.outlook.com [40.107.7.57]) by mails.dpdk.org (Postfix) with ESMTP id D7F6840151 for ; Tue, 9 Nov 2021 06:40:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2C4QenxjWjnq/5pFgQEddKjtpWOj1gyEMT80Mm204c0=; b=nnTIysqZP9H0M6k5QAZhJQvw978Hojs2NbcOFnx6IK5y0HwSpPDSgM+M1eQzGpzaepcE3WR2/y6zUsPo7IvyHgeFU0WYxRdzOKQBoSaxsuchaUuQ6Fz6dXJrNAB/J4dLXpnZcSVWlRIp1WbmcczGr/ZMUcFsDJLY7LBkyhT6B4Q= Received: from DB6PR0801CA0047.eurprd08.prod.outlook.com (2603:10a6:4:2b::15) by DB6PR08MB2888.eurprd08.prod.outlook.com (2603:10a6:6:25::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Tue, 9 Nov 2021 05:40:02 +0000 Received: from DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:2b:cafe::7e) by DB6PR0801CA0047.outlook.office365.com (2603:10a6:4:2b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Tue, 9 Nov 2021 05:40:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT061.mail.protection.outlook.com (10.152.21.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Tue, 9 Nov 2021 05:40:02 +0000 Received: ("Tessian outbound 2bb1f94ba47e:v108"); Tue, 09 Nov 2021 05:40:02 +0000 X-CR-MTA-TID: 64aa7808 Received: from bfdd5db9bf3a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ABC4034A-645A-493C-9F23-0F8832D3C551.1; Tue, 09 Nov 2021 05:39:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bfdd5db9bf3a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Nov 2021 05:39:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fbtVFSWrFpyC+lmveyvNAeGiN3lHaUMV6nhijMO9jcFmHHfcjMRyyidv3RLq055h04+syisAOof3mfEvJkiefWQ8OyGgxeUpzZYfwiX3k7M5DrKTPLOrm9tDIMep7udzx0Z/JnZtW26hycpFKiiKB/zF/hkt5ePdHdieIEEA1lLKND2xBZHmFKlbAO6lcySD6NW3VnAUq0T/eid58rAMcohecJoCYItUOwcGu9q9sVb2A4ZX7uLhvxUeR/42HpZm1iMLQdgPinnwoxjljPtVNWyiLGukn0wdr2w/HXcsqrSq2Z7XYE09F6vWPdb0vI8iPb6CY0xxG19RZwyDX1d52w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2C4QenxjWjnq/5pFgQEddKjtpWOj1gyEMT80Mm204c0=; b=A9SuzheRL9cAzIPxgy2qryRrgdUWDfDcoRZlBiQr4OlTEY+Lc5iq3CcDJIazNGY0Wmo60QMDaVrinr45d0HXiPFw6mT2hciflO7sjHIyza4beXYO+D6RFvh2vhjHkLDmGysKryk7LyqU3EBRkmG8UhNF8ITGPNfMUlLJftyLEHUF3pvqeRGMK1fOhbuXoTb+TD8yrWKB0Ucxwd+DlTo0X3y19/nBSF0u1OjZbXfNT5/5JIb0L6RvW8Dkz2mvb2fIj21l0JwONYDoBcPh9LKiA6wT8UVfJxnaySLMTiNaCoKhqD5I+SQv3Q0GpkUYt51dzEeY9xe8I9SszVWvGK2l0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2C4QenxjWjnq/5pFgQEddKjtpWOj1gyEMT80Mm204c0=; b=nnTIysqZP9H0M6k5QAZhJQvw978Hojs2NbcOFnx6IK5y0HwSpPDSgM+M1eQzGpzaepcE3WR2/y6zUsPo7IvyHgeFU0WYxRdzOKQBoSaxsuchaUuQ6Fz6dXJrNAB/J4dLXpnZcSVWlRIp1WbmcczGr/ZMUcFsDJLY7LBkyhT6B4Q= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by AS8PR08MB7126.eurprd08.prod.outlook.com (2603:10a6:20b:401::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Tue, 9 Nov 2021 05:39:44 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::29a6:2647:cd31:788b]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::29a6:2647:cd31:788b%4]) with mapi id 15.20.4669.016; Tue, 9 Nov 2021 05:39:44 +0000 From: Ruifeng Wang To: Volodymyr Fialko , "dev@dpdk.org" , Bruce Richardson , Anatoly Burakov CC: "jerinj@marvell.com" , David Marchand , nd Thread-Topic: [dpdk-dev] [PATCH v2] eal/arm64: support ASan Thread-Index: AQHX1PKKvvgi8DzCSE23R8U6R5/68qv6q/wA Date: Tue, 9 Nov 2021 05:39:44 +0000 Message-ID: References: <20211108134547.3286191-1-vfialko@marvell.com> <20211108224548.3388687-1-vfialko@marvell.com> In-Reply-To: <20211108224548.3388687-1-vfialko@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7605C12CF2767643A528025B51B863A3.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 19b32f34-bfbb-4d1d-09b0-08d9a3436083 x-ms-traffictypediagnostic: AS8PR08MB7126:|DB6PR08MB2888: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4941;OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SKigmEp2I5Su8UaVclUthCKl5iEL10Z3NXAlnlOLW39yTIfiOE1+5nMQ4ernox16neKI+/SYRL+t9JTztRARNycfKhnI+T7DTIlLjBpoA4q0FEYEekTMuuHqToo7PMkSFGxZD+sN1Kv2whEer4SP5UGzbnL966lycTAaqxM7Qu1eyC80BE1R+Ch7TW6X8uwO8EbZK2E8HHpOK2Oo9b80UEO89DNt3xWsR5RvxC9SZwaGwDP0Wky9+T0XjwpwInlI52+vT6oG5/uAm5NMAWZYiTOkbQRut9ATXj8KTRvZSl7+7hAdQi4H4t/kiFMcjl/KpekZfrROUE6wSXNwAEvAR65q8E74+ni/3CK3vcNEVsvn23pTBotPopJhr2H+krtuvZCH3isn9M/T7wLQiubu7GbWH5icAm23MvzQISnuNHE0xybQADCLnBUdu5W3vDk7oiKI1b3GWtOcDhds/iwsWBhMXtCL1985QgOCN6gt2hNqcVM39f5rCupYTpB+f5Tm8oHk+JtLKRfb1rUx0fi2Y+8Tvj4gXSOAlGoJEpdXURvvQA1J6tB6VRg5qUSDtZO9EXKAmqulXldKUGqhhG+vps8N0gtgEunfEjd8By7JmjjW/UD8b9J1VjAWXKx5lAj6M+BltbDroSAl2J7AasU8IrhVZQTMF/EW2EMZsc45qeno/RuDlfGemUcvjer8EMoYpHsB/Zdhtvbq2ST00b5ZgA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4326008)(6506007)(38100700002)(53546011)(54906003)(122000001)(316002)(110136005)(9686003)(52536014)(38070700005)(19627235002)(8676002)(8936002)(186003)(26005)(66946007)(55016002)(7696005)(86362001)(64756008)(66476007)(66446008)(66556008)(2906002)(508600001)(76116006)(71200400001)(33656002)(5660300002)(83380400001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7126 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 09eb5541-67f2-4855-7b01-08d9a34355e9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m58EpxPcl1DX2ys8YSeG0kXSJ9935ubsTkN74wo0T8b4MAqKf/Vi3Ji9BYKFZgGrGQiOXbVAW8xaXKrOj8vTPMPz8EwTgCSpOe6FpFZ3bklPNa4R57A+ctgw/Q4iDFELLuoo6uTONDWDV8uBajHIyur2wUEy8LuEkjc22u2Y2PYRRg3O1NSPcq5HljzTRIF8DFuOEn5yWpeltIOhna4b2JBt5jW3KE2gLrOxA7Lyke8ZUDTpHQ/U1Mt0vq546aue3j/7OFX7fHfxYN5i+Ek+5CjtcKqvyJh8O7lmXWBuCTyZ/tvy45Eb/FOJSudLBlpSD+JHLzQMzBfOc3qTY9ruSgdHl/WsNs1El32O/5D+5ufUQCgqX6MzRAqt+zUwNB65mQeiOVFA0mSwX3XS+cS61YNtAdyzcfe+6iKMuKQyeXl1DmTdcBbMS3O4pHx5IoYTmhfTvhW2qRRtYL6jzdE1Rx5Eu44TAOg7WJePXgD4JrdRwYUIQ5coRLQ/6Laj+jaH63sYq5Kib7mPq563x5z3N85RRCLRqJil/XWNv/C42Ndc5GLfU04+HKbPGzozMVUqPvrhfaMzlW1YvGmMGKPd6hrteydU7Ss0vK0FyGvYrI3ZpfbsvEc7nQRjPLx5kvfmITnyameCHyV57fvqr2bII31Gkh0UNOeojnMO4nRvWn12RXpKbt6Cc/brq+TbDI7mQbhimrrDI5MZrhKcwk0n7Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(82310400003)(36860700001)(86362001)(316002)(54906003)(6506007)(53546011)(110136005)(70586007)(70206006)(26005)(186003)(2906002)(47076005)(19627235002)(508600001)(7696005)(33656002)(83380400001)(8936002)(356005)(81166007)(9686003)(52536014)(4326008)(55016002)(5660300002)(336012)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 05:40:02.6892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19b32f34-bfbb-4d1d-09b0-08d9a3436083 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2888 Subject: Re: [dpdk-dev] [PATCH v2] eal/arm64: support ASan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Volodymyr Fialko > Sent: Tuesday, November 9, 2021 6:46 AM > To: dev@dpdk.org; Bruce Richardson ; > Anatoly Burakov > Cc: jerinj@marvell.com; Volodymyr Fialko ; David > Marchand > Subject: [dpdk-dev] [PATCH v2] eal/arm64: support ASan >=20 > This patch defines ASAN_SHADOW_OFFSET for arm64 according to the ASan > documentation. This offset should cover all arm64 VMAs supported by ASan. >=20 > Signed-off-by: Volodymyr Fialko > Reviewed-by: David Marchand > Acked-by: Jerin Jacob > --- > Changes since v1: > - changed the subject > - rewrite checks in "elif" manner > --- > config/meson.build | 2 +- > doc/guides/prog_guide/asan.rst | 2 +- > lib/eal/common/malloc_elem.h | 2 ++ > 3 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/config/meson.build b/config/meson.build index > 17b5bec406..7eb710c08d 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -428,7 +428,7 @@ if get_option('b_sanitize') =3D=3D 'address' or > get_option('b_sanitize') =3D=3D 'address > dpdk_extra_ldflags +=3D '-lasan' > endif >=20 > - if is_linux and arch_subdir =3D=3D 'x86' and dpdk_conf.get('RTE_ARCH= _64') > + if is_linux and arch_subdir in ['x86', 'arm'] and > + dpdk_conf.get('RTE_ARCH_64') > dpdk_conf.set10('RTE_MALLOC_ASAN', true) > endif > endif > diff --git a/doc/guides/prog_guide/asan.rst > b/doc/guides/prog_guide/asan.rst index 6d1b871c93..28b2382fc7 100644 > --- a/doc/guides/prog_guide/asan.rst > +++ b/doc/guides/prog_guide/asan.rst > @@ -33,7 +33,7 @@ Example:: > "stty echo" command when an error occurs. >=20 > ASan is aware of DPDK memory allocations, thanks to added instrumentatio= n. > -This is only enabled on x86_64 at the moment. > +This is enabled on x86_64 and arm64 at the moment. > Other architectures may have to define ASAN_SHADOW_OFFSET. >=20 > Example heap-buffer-overflow error > diff --git a/lib/eal/common/malloc_elem.h b/lib/eal/common/malloc_elem.h > index 262d69bb3e..26e937cea0 100644 > --- a/lib/eal/common/malloc_elem.h > +++ b/lib/eal/common/malloc_elem.h > @@ -106,6 +106,8 @@ malloc_elem_cookies_ok(const struct malloc_elem > *elem) >=20 > #ifdef RTE_ARCH_X86_64 > #define ASAN_SHADOW_OFFSET 0x00007fff8000 > +#elif defined(RTE_ARCH_ARM64) > +#define ASAN_SHADOW_OFFSET 0x001000000000 As Jerin mentioned, it is better to add a comment on why this value was sel= ected. My search told me that "this value has to match kAArch64_ShadowOffset64 as = defined in libsanitizer/asan/asan_mapping.h". With the change, Acked-by: Ruifeng Wang > #endif >=20 > #define ASAN_SHADOW_GRAIN_SIZE 8 > -- > 2.25.1