From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8970E42969; Mon, 17 Apr 2023 09:41:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CDD540698; Mon, 17 Apr 2023 09:41:31 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2066.outbound.protection.outlook.com [40.107.20.66]) by mails.dpdk.org (Postfix) with ESMTP id 428A540144 for ; Mon, 17 Apr 2023 09:41:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fZ9G9UcCwfBntQTj5sj2+5+OPOjPpknSPkFZ0PSty8E=; b=2oZZOehythljrn8tqLKF4kojFwh0fLsmV768s0UUILVFHWk4viFKfapwVQj9eFDpMKknsIN01zPs20A5ja6ZYlwj8Xb1qW+s0zo3yCUvf6yLJ19j3jhpmQHmTMPQ4NeXL4rj2C6foWJTA1wH0HmqjCgVybJXubz9Ku+FItHyU+o= Received: from DB9PR05CA0020.eurprd05.prod.outlook.com (2603:10a6:10:1da::25) by AS8PR08MB8659.eurprd08.prod.outlook.com (2603:10a6:20b:563::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Mon, 17 Apr 2023 07:41:18 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1da:cafe::d) by DB9PR05CA0020.outlook.office365.com (2603:10a6:10:1da::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.46 via Frontend Transport; Mon, 17 Apr 2023 07:41:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.12 via Frontend Transport; Mon, 17 Apr 2023 07:41:18 +0000 Received: ("Tessian outbound e13c2446394c:v136"); Mon, 17 Apr 2023 07:41:18 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4fd12ec7fc449d6f X-CR-MTA-TID: 64aa7808 Received: from e596e2dc1869.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4FFA3E54-B5AB-41E6-8EDF-BC64E18E34FF.1; Mon, 17 Apr 2023 07:41:11 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e596e2dc1869.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 17 Apr 2023 07:41:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HfR0FVwC/H8ADOR6PGo4KXjMCciOZXJrpJjdvjH4wN/zw3KAwmyVuVZpPsuoi722UHQ06quLODmJ9Vo1BwxR1w9JvbBhJMGu+dV1RII/hrD31+iqxgkMNByA+odXF9LbnzmNfX90LXCM04O3+olFv+82zFul+gDjeh/Nuny6WmYFP/flNraPzLpU7MdCIh/M/FzmgEEn3hxcL1ZcGhxHXeRXT1jksznKnAdT4SMzlZMh7zI+qoVW+/i/dIfMLOLw04c17NOisZLBNXy1Yg1RfQZQffVAp/SL+iOMt2hlhtp5HTYa4Yd/w/NxRNKG+1OcjmvWyZvfPTNhBa5jbQ9Q8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fZ9G9UcCwfBntQTj5sj2+5+OPOjPpknSPkFZ0PSty8E=; b=DcrnEfCZzestSPg/8oKSlIMd0tBjwT9wHenm7M8L+MowedW3m946UqEbJjbBfuFngq1m5IYlZlmFxSlTJ/s0NPI+cyE76zEvAhwmT8a+f5a1l0uUOzvreg3ah5WtZt94zZ2/B5jJ5XRynaxWl7MVlM85vHYffT1nGuF5seIO5EqKAVwTGpuf66/Xq4774MthfdCYBJXaxylLR3ThhRMs9lTSGs2ZeWgktjKvjzaA6wK2xElddbyE4VbKpvg1gtWtJM2Js65hJ9Nizm2zJGuWARYjN551NyM7JO/EtIi807818s+fs04OfcNCndogFunp15FOPaI7hphBbXDIzLmDTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fZ9G9UcCwfBntQTj5sj2+5+OPOjPpknSPkFZ0PSty8E=; b=2oZZOehythljrn8tqLKF4kojFwh0fLsmV768s0UUILVFHWk4viFKfapwVQj9eFDpMKknsIN01zPs20A5ja6ZYlwj8Xb1qW+s0zo3yCUvf6yLJ19j3jhpmQHmTMPQ4NeXL4rj2C6foWJTA1wH0HmqjCgVybJXubz9Ku+FItHyU+o= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by DU0PR08MB9583.eurprd08.prod.outlook.com (2603:10a6:10:449::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Mon, 17 Apr 2023 07:41:08 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::56e7:ee73:bd05:e16a]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::56e7:ee73:bd05:e16a%2]) with mapi id 15.20.6298.045; Mon, 17 Apr 2023 07:41:08 +0000 From: Ruifeng Wang To: Akihiko Odaki , Bruce Richardson , =?iso-8859-2?Q?Juraj_Linke=B9?= CC: "dev@dpdk.org" , nd Subject: RE: [PATCH 1/2] config/arm: Do not require processor information Thread-Topic: [PATCH 1/2] config/arm: Do not require processor information Thread-Index: AQHZbs6JxD99jHYaW0eqRuvGw8O5mq8vHf2A Date: Mon, 17 Apr 2023 07:41:08 +0000 Message-ID: References: <20230414124139.66443-1-akihiko.odaki@daynix.com> <20230414124139.66443-2-akihiko.odaki@daynix.com> In-Reply-To: <20230414124139.66443-2-akihiko.odaki@daynix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 896AA93F49F67044A9DA9DEDE70BEE81.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7080:EE_|DU0PR08MB9583:EE_|DBAEUR03FT062:EE_|AS8PR08MB8659:EE_ X-MS-Office365-Filtering-Correlation-Id: ab92f799-04d6-4e8f-7cca-08db3f172198 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dS7EOoGHLecyB+Y6pjiQuKG/m5gCcRmT4EbbZgIK5Vv2BSsOXsKMHTDYSy3ojnUlJEBHRaMiaY4YS+ulJOq6fuBBLIFeQtd2I6jIVIws8gd0Es/ZYQ+b2GHbQ4jSv3YHyng72eCMVpOz+ScpvT3NoMY9aMWvIstiT1nQjy7YwYFraFRRw0JtvlYlajuXXvogErDBh2EFsEDNxtuZ/NhPx5HxXEE8SeBjkojuKA15g6VvjtqSv7542vCyN51jVqZx8Gia/dDFXrAMQ9in9eY5j/1GAo3fhSLN/JWJObo6Ls5i4QSjRg8E/c+d+M3wc9DZd4s3WGtnTZOes+yH9Ln2a3oB8NFGQuQwjL26LIdvmd7rl9Ca41CSb8QAYF/mYLZHeMkiihUNGqgfBjZWb6Y0OulXrk72Gua7BQIPyfFF44BC/TBjhKYvoGwu2KQxJ7jF1kERmMXmNfDnzdp7vl0l7nawL3mlT+Sv5M0If9ZZf9aLMNTgcvRsOMg5qhlYb6ZGzW46dIogcG3S+e9psCSEPtLQXJsLhJHwURP+fSzShrHpl/zXpXhi9u12VZmv94wIFSAO0PXfKOcMgHC4ZhJeVD4UjKRb+J9eWvxDGrLDVmCOUGwKJInYI+I5SqliPLo2 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(451199021)(316002)(4326008)(38100700002)(64756008)(66446008)(66556008)(66946007)(66476007)(76116006)(5660300002)(52536014)(7696005)(71200400001)(86362001)(41300700001)(54906003)(9686003)(53546011)(6506007)(26005)(186003)(38070700005)(2906002)(8676002)(83380400001)(8936002)(55016003)(478600001)(33656002)(110136005)(122000001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9583 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 11e73a69-1a7f-4b53-3aa5-08db3f171bf3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B+wm/dbku7UbJGxw0xj+87kx21NjuN86w/z3qhfa5XxHSsMnNVf9CkUpu1/eDTZDQO6agBALDmD5zjNBAbnyPW9XSnpyu465vkG7YfVsOmkYiCtIkrxFd7zIyap/7whpYJIE5fM93Tq8Ddg1ABrGxpW/UQFQEB2MWlK5yleSSH2BfA0+/2ArWMIKjM+pmaC1CbI/hLlxYf1+I9Qg08eXBnHfBnMh7HBH55RRAyZywBGOLo9JQnuDk1z9rKULaEMaWqq0HMiNrtdQPwbBdA4pRWZwF8au1kMOaWdxfZA6nCiJt1/AT5mYSu4prXb15mIusRsHTs0O/YikoJFeHSMfcZVqE0Q/u9sRFrnihOo49VJHvuuUv1VdrYzEFbclFxJJsCZ0mN0ZZEm3QiBMSbA5izreybQDAH4UHUHiLMmRCLyIFGRGI0MR3QO88lDvetu6k/3bWvodH/e87+GKr25OpAZsLYhj/vhVhy3j3sjYXmDvlSFDpsWkdWuWazfD5raP0smoRSHFsSHFtQQhu43c10Ll39hh1VoNNezZhchr3+/pvjvHQwwXd+yLzhrZS2efV0DtBaNeNnX4f5x83SW/r8y8syU+C7MUfTui+j+/r3DvllHKhvep71AL4Nqz5/kxJZHLP+FfDG1lA0dQvHZW///Bn3aNbUiQuOKSZpPUe9WqqFJkjZDeFxO+HaBomqUxhbFSD8lAOQVbORa6OWhuIA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199021)(36840700001)(46966006)(40470700004)(54906003)(36860700001)(55016003)(83380400001)(478600001)(7696005)(40480700001)(6506007)(9686003)(53546011)(26005)(70586007)(316002)(70206006)(110136005)(4326008)(82740400003)(47076005)(336012)(186003)(5660300002)(52536014)(8676002)(8936002)(81166007)(356005)(2906002)(40460700003)(41300700001)(86362001)(33656002)(82310400005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2023 07:41:18.3340 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab92f799-04d6-4e8f-7cca-08db3f172198 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8659 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akihiko Odaki > Sent: Friday, April 14, 2023 8:42 PM > To: Ruifeng Wang ; Bruce Richardson > Cc: dev@dpdk.org; Akihiko Odaki > Subject: [PATCH 1/2] config/arm: Do not require processor information >=20 > DPDK can be built even without exact processor information for x86 and pp= c so allow to > build for Arm even if we don't know the targeted processor is unknown. Hi Akihiko, The design idea was to require an explicit generic build. Default/native build doesn't fall back to generic build when SoC info is no= t on the list. So the user has less chance to generate a suboptimal binary by accident. >=20 > Signed-off-by: Akihiko Odaki > --- > config/arm/meson.build | 36 +++++++++++++++++++----------------- > 1 file changed, 19 insertions(+), 17 deletions(-) >=20 > diff --git a/config/arm/meson.build b/config/arm/meson.build index 6442ec= 9596..724c00ad7e > 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -582,29 +582,31 @@ if update_flags > enable_drivers +=3D ',' + soc_config.get('enable_drivers', '') > endif >=20 > - if implementers.has_key(implementer_id) > + if not implementers.has_key(implementer_id) > + implementer_id =3D 'generic' > + endif > + > + implementer_config =3D implementers[implementer_id] > + part_number_config =3D implementer_config['part_number_config'] > + > + if not part_number_config.has_key(part_number) > + implementer_id =3D 'generic' > + > + if dpdk_conf.get('RTE_ARCH_32') > + part_number =3D 'generic_aarch32' > + else > + part_number =3D 'generic' > + endif > + > implementer_config =3D implementers[implementer_id] > - else > - error('Unsupported Arm implementer: @0@. '.format(implementer_id= ) + > - 'Please add support for it or use the generic ' + > - '(-Dplatform=3Dgeneric) build.') > + part_number_config =3D implementer_config['part_number_config'] > endif >=20 > + part_number_config =3D part_number_config[part_number] > + > message('Arm implementer: ' + implementer_config['description']) > message('Arm part number: ' + part_number) >=20 > - part_number_config =3D implementer_config['part_number_config'] > - if part_number_config.has_key(part_number) > - # use the specified part_number machine args if found > - part_number_config =3D part_number_config[part_number] > - else > - # unknown part number > - error('Unsupported part number @0@ of implementer @1@. ' > - .format(part_number, implementer_id) + > - 'Please add support for it or use the generic ' + > - '(-Dplatform=3Dgeneric) build.') > - endif > - > # add/overwrite flags in the proper order > dpdk_flags =3D flags_common + implementer_config['flags'] + > part_number_config.get('flags', []) + soc_flags >=20 > -- > 2.40.0