From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52D8441D49; Thu, 23 Feb 2023 08:11:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20D1143004; Thu, 23 Feb 2023 08:11:30 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2041.outbound.protection.outlook.com [40.107.7.41]) by mails.dpdk.org (Postfix) with ESMTP id 071524021F for ; Thu, 23 Feb 2023 08:11:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JohUUDABl95zNJeyGmxXAqZ2OZz20akptTj4QUIObWg=; b=BOAKe/1OpTfg1TZKTP+THPmm7WvvYNCO2y3dBU7vpYbqw0oNpLxElLhw0bHpdvIyH+AyzcuhecbHE0pv1QCBQCBovg4+KJJJc/Sq1les9ZY+TKbK7zqQogH9LZGEaEFsvQEOuf/QRlrdfiBHmC0zm6Jbynzumw4Cez00QHeNg3Y= Received: from AS9PR06CA0483.eurprd06.prod.outlook.com (2603:10a6:20b:49b::8) by AM0PR08MB5332.eurprd08.prod.outlook.com (2603:10a6:208:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Thu, 23 Feb 2023 07:11:19 +0000 Received: from AM7EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49b:cafe::e) by AS9PR06CA0483.outlook.office365.com (2603:10a6:20b:49b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21 via Frontend Transport; Thu, 23 Feb 2023 07:11:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT003.mail.protection.outlook.com (100.127.140.227) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21 via Frontend Transport; Thu, 23 Feb 2023 07:11:19 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Thu, 23 Feb 2023 07:11:19 +0000 X-CR-MTA-TID: 64aa7808 Received: from 9f2c303237f8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 02F50B0F-16DC-4664-993B-6F353DADD3F6.1; Thu, 23 Feb 2023 07:11:12 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f2c303237f8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 23 Feb 2023 07:11:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KTM6SlMA611DuUj/K0IccdncvIlBqtfQGwcPXh5CxSQBWnl6GLlVv+7XiLod6Bh4+tx6q/9+IXGVKPIhCwA1BGo8jyHdsfpKDQA0OViGukOSWdNYD/5Iq/4QS6+98HmUYwgBmszVSt2DIxthb2crB+lyQW9JYUjWkHIewMLRPTxBKcwssjcZGQV1thtzzvr0iiTG4i/ZNMsVSF3ebQUysD/wLbgV33SxhD4kzWhrgPVoYSzSsi6wK4/KIFhOxgS/+iT1lkRuGxB/cf6GgHz8xNDCA3B/vPKmf5wSbSskG3mf8wj9mxxuEzE/WqnU8grRd2s09xMkzlmwctJfukUfIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JohUUDABl95zNJeyGmxXAqZ2OZz20akptTj4QUIObWg=; b=agpBNlQTpUhmqXGNAx/Ey7vBaeXvA6gIob5RY/Rc+fWHOcQFqd+GpuOsiYiy90EjDHmhRF0xqH02vR0iCE56zlin1vvEMMKGYoTtwEGYZTfUlKqCVT7nE8Kcl48XdtorpF0iT+pBwcCqoyJD4lFVCAQVESCAvA+4bCbUGcI/3hq1R4ogOxH1JPVZLTz6EhuKB++SlKC0eWOuSe8BdBDs0e34F/SKVAbVUaNxPaIKMU/qxv5686rmOCfOJpGuMohM+SatYMpxPAvRuaDH+WyhtA6R7tGvpVXLqBwpSQb3Q+uWFh2e5+yGyV5m9sVIJaJ6nREyJMBUwuCn1rzcKWhJgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JohUUDABl95zNJeyGmxXAqZ2OZz20akptTj4QUIObWg=; b=BOAKe/1OpTfg1TZKTP+THPmm7WvvYNCO2y3dBU7vpYbqw0oNpLxElLhw0bHpdvIyH+AyzcuhecbHE0pv1QCBQCBovg4+KJJJc/Sq1les9ZY+TKbK7zqQogH9LZGEaEFsvQEOuf/QRlrdfiBHmC0zm6Jbynzumw4Cez00QHeNg3Y= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by DBBPR08MB5883.eurprd08.prod.outlook.com (2603:10a6:10:206::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.21; Thu, 23 Feb 2023 07:11:06 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::3e2c:a99c:db5b:601f]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::3e2c:a99c:db5b:601f%5]) with mapi id 15.20.6134.021; Thu, 23 Feb 2023 07:11:06 +0000 From: Ruifeng Wang To: Stephen Hemminger , "dev@dpdk.org" CC: Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , nd Subject: RE: [PATCH v11 21/22] hash: move rte_hash_set_alg out header Thread-Topic: [PATCH v11 21/22] hash: move rte_hash_set_alg out header Thread-Index: AQHZRwh9iWfbb8E4p0WJsgN33b7Meq7cGurQ Date: Thu, 23 Feb 2023 07:11:06 +0000 Message-ID: References: <20230207204151.1503491-1-stephen@networkplumber.org> <20230222215541.158205-1-stephen@networkplumber.org> <20230222215541.158205-22-stephen@networkplumber.org> In-Reply-To: <20230222215541.158205-22-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6B943378DEE37D479E8E762A0D4F2171.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7080:EE_|DBBPR08MB5883:EE_|AM7EUR03FT003:EE_|AM0PR08MB5332:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cb73968-ca64-48e3-8aa1-08db156d2990 x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cikmDFc10Ezco/HNwoj/ws903aaNGOwN4R3pu+7e4qRGqumZ+RzrwgIfBMoUq0DNqW5Yc0uIZMmvAydFjBQvCZr81jY6/ZzefTFGzF9hDZz5xK+8AsdC0LL9WAMT8SIpqePXpK6NPYwq/CGltRocx0GSPuZQANVfnQmJ6ugwZ/OR4jtL+r7VaU5mio5nZYh1Vjs5vOexb9xZlRqb2Y19RoTnB2JfIjXruO9h4ZV5pzZiY3+FRJUkywbzhvjnO2HCPjp8CjkbtMxyetV66Zq4MAFN5V8iNOWwhfG7AFwN/5fUApTO0q+PQe6esk7BHqhAxWa/YCUsdKSHQ6F57SQ9fQk+P/vzKRyqgrRva3IkBHOowccocl/DjGxOQ4yFFHYYHMrzFxnOcNX/2wOnTQQNTpuX/0dFZ19tn3EsASNdHo/xMGYyLxmIZH5J8hlnlN2vHl+EQY3sx7jcu5O7LVk60K7rdPxyp4tkzhwiuusV+Em5mrhUDTQ5X7ZYRwUSx6Yi5AWLN1YCJhG59OtmBNlwbfk4javGGUvU1Ec4/zB5QKQevDKn1j4++uD0/BSjFWM1t8eKmunC4ZRF6l80B7EhPsGZM4AQSPIemcmV60kCAC7NGfwQmcPl+w6JWJxZgmpeHGgsriAgLahjeg0Bv+Cwu6AAS2LsQeK4m5u3QkuWX78CXPzmgN7uol7wbZ3ot2MJ5TPpIR0f2X2P/dYFg2mTYg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39860400002)(396003)(376002)(346002)(136003)(451199018)(38100700002)(38070700005)(83380400001)(122000001)(86362001)(33656002)(41300700001)(2906002)(8936002)(52536014)(5660300002)(55016003)(26005)(9686003)(186003)(53546011)(6506007)(54906003)(8676002)(4326008)(316002)(64756008)(66476007)(66446008)(110136005)(66946007)(76116006)(478600001)(66556008)(7696005)(71200400001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5883 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 56db91a5-d4d5-4c73-39e1-08db156d21eb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uqUcUc5rE6BjNXQrhE9TuIf1vnk/v+NIAuVNQ5yduXYxzdtIyUOZ3qAGPgUQf3AltV+P5Fb5+wELaUPUR+TMFHP79gamw+gIhUlz0jTE1d5h4/wIAT8AMMTximrf0+CqE/kD7INYoEfWvEoYcTbKho332nIcSs0toXRE6sMJ5AT5vziU5ZEr2KgQs8+kBkaZ7FnDbSG792kY38X4ZKc24fFjnoBs4gsWybAmjrTQKCYT1qJi95N73Ds/If/nl7ct3tUaiI7ppoZzdqmkIpDzyX1pYc7o7HIzeIV4cqUWk47v3bwp3YhR826opvD1il/yQ99whxeJhwIhzD3l++LrGpWinn8hzFiZZjpAZvkc7EhWz10nnEikFiIHmPYPGw78yD8b2aaNEOtX7X9bKSYIOB2HvlU9f9g1ND9tdHhzpewdN+VCgvwMbLQIvXw74D6v7y944Bdb25YoW/rCGjiDDK3wdkMb3XgMy+8sf1pmbk79xynGgljSduBiunGzi504p8nR+cj1X62LmrOVJZWSFgFYNAcKO98Hv2NMcj9XM5dG4nrvFSkBOYxPyJT0MevlzyMlJ/ZJ39cG9VBvZxAmqXevn3LGseX4v+T+hID8liWrmPC1pd0TlUiLgHGrE3MMxm3vtjkAzOze7hxg09+LoNtkcKH8LwNDrPQZXWPJuNlb4QeBdwRukkHDl3SWL2FYnlWAl4KzNu4XkSguV8I+EA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(376002)(396003)(346002)(136003)(451199018)(46966006)(36840700001)(40470700004)(356005)(83380400001)(82740400003)(36860700001)(81166007)(86362001)(33656002)(2906002)(52536014)(41300700001)(8936002)(5660300002)(55016003)(40480700001)(82310400005)(40460700003)(26005)(9686003)(186003)(53546011)(47076005)(6506007)(336012)(54906003)(8676002)(4326008)(70206006)(316002)(110136005)(70586007)(7696005)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 07:11:19.5545 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4cb73968-ca64-48e3-8aa1-08db156d2990 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5332 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, February 23, 2023 5:56 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Yipeng Wang ; > Sameh Gobriel ; Bruce Richardson ; > Vladimir Medvedkin ; Ruifeng Wang > Subject: [PATCH v11 21/22] hash: move rte_hash_set_alg out header >=20 > The code for setting algorithm for hash is not at all perf sensitive, and= doing it inline > has a couple of problems. First, it means that if multiple files include = the header, then > the initialization gets done multiple times. But also, it makes it harder= to fix usage of > RTE_LOG(). >=20 > Despite what the checking script say. This is not an ABI change, the prev= ious version > inlined the same code; therefore both old and new code will work the same= . >=20 > Signed-off-by: Stephen Hemminger > --- > lib/hash/meson.build | 1 + > lib/hash/rte_crc_arm64.h | 8 ++--- > lib/hash/rte_crc_x86.h | 10 +++--- > lib/hash/rte_hash_crc.c | 68 ++++++++++++++++++++++++++++++++++++++++ > lib/hash/rte_hash_crc.h | 48 ++-------------------------- > lib/hash/version.map | 7 +++++ > 6 files changed, 88 insertions(+), 54 deletions(-) create mode 100644 > lib/hash/rte_hash_crc.c >=20 > diff --git a/lib/hash/meson.build b/lib/hash/meson.build index e56ee85725= 64..c345c6f561fc > 100644 > --- a/lib/hash/meson.build > +++ b/lib/hash/meson.build > @@ -19,6 +19,7 @@ indirect_headers +=3D files( >=20 > sources =3D files( > 'rte_cuckoo_hash.c', > + 'rte_hash_crc.c', I suppose this list is alphabetically ordered. > 'rte_fbk_hash.c', > 'rte_thash.c', > 'rte_thash_gfni.c' > diff --git a/lib/hash/rte_hash_crc.h b/lib/hash/rte_hash_crc.h index > 0249ad16c5b6..e8145ee44204 100644 > --- a/lib/hash/rte_hash_crc.h > +++ b/lib/hash/rte_hash_crc.h > @@ -20,8 +20,6 @@ extern "C" { > #include > #include > #include > -#include A couple of files need update with this change. rte_cpuflags.h should be included in rte_fbk_hash.c (for ARM) and rte_efd.c= . > -#include >=20 > #include "rte_crc_sw.h" >=20