From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 597CC42BDF; Tue, 30 May 2023 09:44:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D52AE40F18; Tue, 30 May 2023 09:44:22 +0200 (CEST) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2074.outbound.protection.outlook.com [40.107.247.74]) by mails.dpdk.org (Postfix) with ESMTP id BB799406BC for ; Tue, 30 May 2023 09:44:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q5gKafUvmPo6jYVBD+7mWAqXlrQiU1KuOwjCEGAHb3g=; b=gD6kWwij48tCoS6vSgEbPc5rn0u62qzJtFfk9EmTFcJHtFRDh2Qrtv/iYofpnXTDaxYREs2nGSxYDl6b8biGDrTladZRPP/a72Fw5KfCYMFB7tFcS9txBTGXkzWj2Dt3UjkuIagVqhK/W9y8yzvA53lo5WPVLBmsc1vBHvc03fg= Received: from AM6P194CA0044.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::21) by DBBPR08MB5930.eurprd08.prod.outlook.com (2603:10a6:10:200::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Tue, 30 May 2023 07:44:19 +0000 Received: from AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:84:cafe::b6) by AM6P194CA0044.outlook.office365.com (2603:10a6:209:84::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23 via Frontend Transport; Tue, 30 May 2023 07:44:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT049.mail.protection.outlook.com (100.127.140.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15 via Frontend Transport; Tue, 30 May 2023 07:44:19 +0000 Received: ("Tessian outbound 945aec65ec65:v136"); Tue, 30 May 2023 07:44:18 +0000 X-CR-MTA-TID: 64aa7808 Received: from 7d5b8aa86d81.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B3E0F264-350A-47FF-8510-CC38D7B0A147.1; Tue, 30 May 2023 07:44:12 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7d5b8aa86d81.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 30 May 2023 07:44:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VhGxDFZ0+YHHIvodOXS8U9L7vxIMvwNrpkJ9nc2VnrXvGtLDwKPW4Mq2Ri6dsJAoYGuKuYh671GC04XQHjtMu3XPtfQbHK3BDC14zkzq0sLGnJzQAUiBS4j4XL9qgbgFpJ5RnkKA1msTiaB+UlgRIzMmxhZM6/N6m5nAb9yLIk3v9b1tsjCilx0OC36gfLOaoWxtVMb/aQYS6tf6WeJqIjMGQW5yb485oPI7Om1Q4BRFTxbzpnOz54+2ZPaRx5mEHoCZ1oyYGUSx1X8I0lQS63rpY2+32lfVAMRKtOuWC3De2KX1YwF3juFwtDvaQrQj2MR//YjX0IShuGQ5R/HdCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q5gKafUvmPo6jYVBD+7mWAqXlrQiU1KuOwjCEGAHb3g=; b=JDIAgto2qarX6Zli6EdNjQT/dJLQBCGM15aKi4C4idhkVkXvje7voJ+th2Qp1Qsi3InRecyjw+G+fRORip6pesklcnGC53wW/O4thvZpjVtFheUBOYxtjZ30dlVbbua/Hdux6coDZ2HW+SfvrdvpCQSpI7itaZUtINgigoh4t9rKYB67z3Qra9moVlUpWF5PTbaF/8X1jNGrpnCtsPWum+dhsSgFRBwCVlUSar6y6W1tfigZsoSljA6M61kTLM59hsl90dyHB8aGTbEqlsMXfF4GHdW8BzwLKiz0H72ZjYYZUM5IxOhYWvR2sXN+PlTH/AFhqUuyJOawapv0vu0Zvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q5gKafUvmPo6jYVBD+7mWAqXlrQiU1KuOwjCEGAHb3g=; b=gD6kWwij48tCoS6vSgEbPc5rn0u62qzJtFfk9EmTFcJHtFRDh2Qrtv/iYofpnXTDaxYREs2nGSxYDl6b8biGDrTladZRPP/a72Fw5KfCYMFB7tFcS9txBTGXkzWj2Dt3UjkuIagVqhK/W9y8yzvA53lo5WPVLBmsc1vBHvc03fg= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by GV1PR08MB7347.eurprd08.prod.outlook.com (2603:10a6:150:22::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15; Tue, 30 May 2023 07:44:09 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::56e7:ee73:bd05:e16a]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::56e7:ee73:bd05:e16a%4]) with mapi id 15.20.6433.022; Tue, 30 May 2023 07:44:09 +0000 From: Ruifeng Wang To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Konstantin Ananyev CC: "dev@dpdk.org" , nd Subject: RE: [PATCH v3 1/2] ip_frag: optimize key compare and hash generation Thread-Topic: [PATCH v3 1/2] ip_frag: optimize key compare and hash generation Thread-Index: AQHZkj2cCho7JI2sHUuNQQhZkKXl2q9ycCjA Date: Tue, 30 May 2023 07:44:09 +0000 Message-ID: References: <20230523143921.7420-1-pbhagavatula@marvell.com> <20230529145502.11805-1-pbhagavatula@marvell.com> In-Reply-To: <20230529145502.11805-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A4CBC6055DE55D42B1BC849110826D09.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: AS8PR08MB7080:EE_|GV1PR08MB7347:EE_|AM7EUR03FT049:EE_|DBBPR08MB5930:EE_ X-MS-Office365-Filtering-Correlation-Id: 859d881c-5d3c-4365-ce3a-08db60e1ad1c x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fdGOf+rvbKyC4RHrOfOsJMaOd9uBB3NlRDfJ+p0K/Xx5t3o1dTDgZ6b6h01z83oyFSYYElCVcaq5bc5xxk4QUOPYe/N+jjwq0RcvddkFho6c6pE4TErY4s0+51MhTOM7IbXa255bPcOVyvQwSy7huhzUSs4NhcL5C+VdHOb2wnvLBsPOx8nsasnGvkIQ1grTyFR++ILl3N5gi5tK2ZGIsTNWMkUXp5WQe9ayUcQHaVrhuRJPCjqVV+/A7f5D36P3OenUd50xwrMj8XvYbdR09x5xPLNIVE4VyCzm0eKqwhSZwRdKfj1LcaBq2ApnHrZU0/1hyu9L+XqzCawX/fPVMmTw0rXJdaINpZ/OQwd2Epz1Z7rzfuwEqpX6ZAj/q9FjE4HLkp4cZtd7Jc4huMFrQCv6UcQRRwi3pENEevTV+97NEdb4wqmPzn6a0MqCjls1YvtegSlUElwZguuTYBUDwPw7HaT7d5T0MTXiZBIFxtzE+QrQTvrQagdxTAnYQBicvBGQQ28ZrlAKAaSXpEk1N/CFPI5hSaEVsHpkNRI9NVUoopyFHPgVHduSbqIjRRibHwSKHtDgfAVXb2nsXoC4Blelhp8MI4hTdDfkc9QXSg5mVfzgucFbBj7XSq4mEVz5 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(346002)(396003)(366004)(376002)(451199021)(54906003)(2906002)(52536014)(110136005)(5660300002)(8676002)(8936002)(186003)(38070700005)(71200400001)(41300700001)(316002)(478600001)(7696005)(55016003)(66556008)(66446008)(64756008)(66946007)(33656002)(76116006)(4326008)(66476007)(53546011)(38100700002)(26005)(9686003)(83380400001)(6506007)(122000001)(86362001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7347 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5ab3e1b7-483f-411b-1fa3-08db60e1a721 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8MKOf8X7tEXF41VWefetfke9JDQ9LAS91PoK1dq4Pd6ncOsePRbMTEQRdw35aOvdjVKk0oroAjsVkPao/Q1/At3oPpQcZ8n2P3iyahZE1owN0q0mmATzo8YdPVqa/90RuKE1HxFb5Bm+QcS1lAomRsXQdv1/be0CiEUWUgjrXnRWU6/dvBJyje+lylsR9E2lytE1Ht0xKC0FcCyXGMIobHjsy4FytHb4Ug/d6IuhiD2+3ni5f2W6a+7GXHSgklSPbVEcDt8OF8hTrt9Sg9FBLXMpq9FLBEzSFoi6ElQ2ZN9DmRX8f9re3bCvf1oIdE34fMd2zPRNiJugbNg2d+PRZWOL0Q2T8keTjoSSKC47R/6S6AgoH/HdmiisvMOXC4PrBgg+FE3wHcm1t6ifEyk4vMTAKf3ZGgBG39AW8j/X+eOi6qniCiPVdCdijOaWWEpp+kdem0QXINpxrH+59lRzTd+iJrUL1fBClQTDFSx6Ol5YoaOjbF9efWtitOcqn9KT2nuNkjOl9SBiWAKfgKG7Gh9pKCQYNMbtkYcnjLLUPXsdphHkBkSvsdUtRqvGHPBgKQ83XYjCz3UGZJN7VLxpsrnpT2UbmG/6FqiJYdDhmafTYEApHBQHkIJXaPHgGFldZRLcbN55LTPjgXIkYDE0QctQhTVfHKlbJFI+mjdQe4FlSGzGhBuAcOrhhA1eXSqY8b2vTYLPgpANb9OBH83c24x6ZTPalvLgxmk/jOT320S4KuMDm3HpgujEsof/hxmpGGgzJf0syhQlKRmVmsekPA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199021)(46966006)(40470700004)(36840700001)(186003)(41300700001)(336012)(83380400001)(9686003)(53546011)(6506007)(26005)(36860700001)(47076005)(7696005)(478600001)(40460700003)(110136005)(54906003)(356005)(4326008)(82740400003)(70206006)(70586007)(81166007)(40480700001)(55016003)(316002)(52536014)(5660300002)(8676002)(8936002)(2906002)(86362001)(33656002)(82310400005)(23180200003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 07:44:19.0842 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 859d881c-5d3c-4365-ce3a-08db60e1ad1c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5930 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Monday, May 29, 2023 10:55 PM > To: jerinj@marvell.com; Ruifeng Wang ; Yipeng Wang > ; Sameh Gobriel ; Bruce = Richardson > ; Vladimir Medvedkin ; > Konstantin Ananyev > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH v3 1/2] ip_frag: optimize key compare and hash generation >=20 > From: Pavan Nikhilesh >=20 > Use optimized rte_hash_k32_cmp_eq routine for key comparison for > x86 and ARM64. > Use CRC instructions for hash generation on ARM64. >=20 > Signed-off-by: Pavan Nikhilesh > --- > On Neoverse-N2, performance improved by 10% when measured with examples/i= p_reassembly. >=20 > v3 Changes: > - Drop NEON patch. > v2 Changes: > - Fix compilation failure with non ARM64/x86 targets >=20 > lib/hash/rte_cmp_arm64.h | 16 ++++++++-------- > lib/hash/rte_cmp_x86.h | 16 ++++++++-------- > lib/ip_frag/ip_frag_common.h | 14 +++++++++++++- > lib/ip_frag/ip_frag_internal.c | 4 ++-- > 4 files changed, 31 insertions(+), 19 deletions(-) >=20 Reviewed-by: Ruifeng Wang