From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3C1AA0093; Fri, 29 Apr 2022 09:20:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2C2342823; Fri, 29 Apr 2022 09:20:10 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2085.outbound.protection.outlook.com [40.107.21.85]) by mails.dpdk.org (Postfix) with ESMTP id B370F410E3 for ; Fri, 29 Apr 2022 09:20:08 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=G9sJ2w8ha5geHhD0IcWWBcB0wCymoV0+DAbV7ayMzrcczXaA/NEFigtrghPFUcH1dnlerzJbEM2a8tB6j13PaNzLqwqMaBMKn3z/mnlTCLiZQYO5T1lQ1T9OtFDjfWaCOnPv03nmpmrRxzQtJylUMt9bgJHhyZ9BI6ZP1KO4kcoJ5IdeIl/xpincbH33+wNwoAJ8Y3FYpcruTf9Ij6BY9Tc0PHKcGAfdDuKegCmthBuUfrgh4Iy6HFKwVtyUMtHr+Wa75M6A9g4LC9WOxgmHEO77xaAdXvR+NfRLKGPor/phDJnuumuJYGl4g0otb+aQDlr0q7xNIQMyAAPMkAqtgg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lAVJCoUdhJdlL/ZssLRF7c8Ep8aG+hgh+8wJL2byk2w=; b=LUJ7BtICSGq4fafmm8JaqFTGcVihID2yG/Wc623JvFy0f7BfVBSE8fOKCyTr5M5AsLxkVQk6G0Eubr9gg/zTp30qlfPkBZxD1Udm9zJkZc+ABTuWDgoh4cYNy4kzaO1r89S8UHYxp9+I3rjSbzN8M84fVCQYeI3d7V0hsgw5hVfqvHGwvl+75AzUjTxvuzms52ZoEkrCmtomsMjDjJ0WEFS8c+uQgub8oJcWMZxy4RkcfKO+BiLOGzNSMbmrlGzcaq6Woa7mvXov7kRyb94B8iw0Cm5teB9pf1gSbbkQ+ibUygs5XM83xrF3r9jQkY28NYNE9DQnnTYzLkPecDmHtg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lAVJCoUdhJdlL/ZssLRF7c8Ep8aG+hgh+8wJL2byk2w=; b=HVJ5IvQIbHMnBpe60HxWwGUAkQEty9kVJwIHJ0E+2lUxNd1UDFp9Y/sZBgpXIOHwdpZFuggWkZLRvhh6D5ku9GNgt2KxyEZOby+ug0WYs3nP0hsq4K2ahpXvXhkZ8CElieRVDZMSWUpMydgQvt5XXuovWPVxkud1a3jAC/7mXlU= Received: from AM7PR04CA0022.eurprd04.prod.outlook.com (2603:10a6:20b:110::32) by DB9PR08MB7052.eurprd08.prod.outlook.com (2603:10a6:10:2bf::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Fri, 29 Apr 2022 07:20:00 +0000 Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:110:cafe::da) by AM7PR04CA0022.outlook.office365.com (2603:10a6:20b:110::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13 via Frontend Transport; Fri, 29 Apr 2022 07:20:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 07:20:00 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Fri, 29 Apr 2022 07:20:00 +0000 X-CR-MTA-TID: 64aa7808 Received: from 161847901f2d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DD8D5863-4F3F-47D4-9CC4-B63319F76D25.1; Fri, 29 Apr 2022 07:19:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 161847901f2d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 29 Apr 2022 07:19:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ngDV4keq4F5w0JAMZenMED7fOBRsmrU3XGfpvM2okVhXa26OODpE22SrIEeZOCBKmxybwLx8YnNyedDfbfRiO5/O0P1aUU7vYTN0BWR6/iAOAY3pqrhTG5B1S8akbWAQkA0vLLuFLcXMPVO02QWcxmlSRp5O7qz0Qt5NcA+R5gZe9o3S4PlMpZIgEFp5YZIzCNYOLNIW8wIur+7lcfOtXnTjuM2z79YGAA5oj0ywnxhzbI2cDtCiDqVio6mtOv4bZQw7IUrGaZEwMosmMmF3JqIK0CqiJAizRp9DTlFzHuhAfcsq+TxBNJ7dTP0z9IJCxTt/9yxzvkOn2gOXQ813Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lAVJCoUdhJdlL/ZssLRF7c8Ep8aG+hgh+8wJL2byk2w=; b=ihQK8Zst8bRZ9OnM96LIL1PEDq6XHQ4wQV4J+jTLAIYgkg76V0fA9gi7Arc/YV6K4Jg83v8nLakXMDxZ3Hz4CbY5X/gW1wL516bmyM0LpXQ/j0Qo8P9vEupWOBxZNrwCMeUMINut1c+CbAwcpR6KBio6gK7UJcHcR1h/4Jha/CGFrEBiDomze8lGOLbXax+7fFWmp0ejQHZD+mpYAB8ce9ayu9f0Q4rOhUmiNRvmZf0ZLDIhn4epVD2Nob+4UHHZCIm50OU32zCor4SmNSFhHc7B4KW5siDyH1lSFJ3yZLQOjtEdSmrR3PHjj5Y86Kybt3T0EKaLhOcZOTig8fcwuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lAVJCoUdhJdlL/ZssLRF7c8Ep8aG+hgh+8wJL2byk2w=; b=HVJ5IvQIbHMnBpe60HxWwGUAkQEty9kVJwIHJ0E+2lUxNd1UDFp9Y/sZBgpXIOHwdpZFuggWkZLRvhh6D5ku9GNgt2KxyEZOby+ug0WYs3nP0hsq4K2ahpXvXhkZ8CElieRVDZMSWUpMydgQvt5XXuovWPVxkud1a3jAC/7mXlU= Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by AM5PR0801MB1634.eurprd08.prod.outlook.com (2603:10a6:203:39::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr 2022 07:19:50 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::f8d4:2ff0:3cc9:56dd]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::f8d4:2ff0:3cc9:56dd%4]) with mapi id 15.20.5206.014; Fri, 29 Apr 2022 07:19:50 +0000 From: Ruifeng Wang To: Pavan Nikhilesh , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin CC: "jerinj@marvell.com" , "dev@dpdk.org" , nd Subject: RE: [PATCH v7 2/2] hash: unify crc32 selection for x86 and Arm Thread-Topic: [PATCH v7 2/2] hash: unify crc32 selection for x86 and Arm Thread-Index: AQHYWkqzn1ta5UZ9ykKgO9vuHbD02a0GfkwA Date: Fri, 29 Apr 2022 07:19:50 +0000 Message-ID: References: <20220427133519.17837-1-pbhagavatula@marvell.com> <20220427152232.19223-1-pbhagavatula@marvell.com> <20220427152232.19223-2-pbhagavatula@marvell.com> In-Reply-To: <20220427152232.19223-2-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BA21496FFB451040B98CB363266F89B2.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 837ba0d5-3691-4389-56a2-08da29b0ac23 x-ms-traffictypediagnostic: AM5PR0801MB1634:EE_|AM5EUR03FT027:EE_|DB9PR08MB7052:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fbNFO11NKofzCNvRhTOF7V4YHzOwbQ9tp97ei81P0wUtXQeryaowm8ENk1Am1yz2rqHQLdZC3sN4w1zcWJ4AK8lliVGMjtwJ++rSMjcH5gGyERGUHPjXrqDV6Oe5n0UfZfmHgyEUAQht/JLkqMkM30KQ2DQbuBrf/CVTsWsS4aijMZPGC9pb2SDJ6IW0Hk6kS5sf+zzLoePIuLeNsplCyeOuBhuRxmZHOPWX27Vl3LixxV84lQrYXBl6A8Dc6kuaksPLG5xYk/vGYn8ful/O7uVb2cln/O6fgWCk82Gh7YNcUHdb2asgzrBqPivlQ5QxJLC5babpYhKwZrRG9wSWoHZuAHJhciGNpJ4s/ckuwIxiHwq+jd54dlaO31yMtl/T8wQTVl6mIS9W8UNmGSFquLlLx5cONkaJ6DqPOxNjKi90XTqOKRDgDQNAx9CEkWb9uEtAJK3WMFqgSLgyasOgxSe7j76FUCKTkTO+VOnqeUTVt30uml1LQOYactZZiFnS4b92tUoyFoP7QeSrYppS+ulYIKhwVFi2jle9r6S36W86CooWFd0scxh6eLPBYoLOxYnFuQPbhDB5fhxZ1UnC0bKUmsoaTmV27uKCjYv0WQDGIvlrB1kWVFETo9ObDyjZ1prOELswgusT6g2LyypPFF+60k59rcnLoRHBX852X2VGXfmpfa4iww/P2+inVM7BTWaXFFpFCCxHchd5qfM6JA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(122000001)(83380400001)(26005)(7696005)(52536014)(8936002)(33656002)(508600001)(55016003)(186003)(54906003)(316002)(110136005)(64756008)(66446008)(66946007)(66476007)(53546011)(71200400001)(8676002)(2906002)(4326008)(76116006)(66556008)(6506007)(9686003)(38100700002)(38070700005)(86362001)(5660300002); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1634 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c7a3fdc2-47a5-4983-81c4-08da29b0a65e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lJb2FZs/nDaBuGrW6NXDYL5EokZnk1q5HOtcX0eMF2sPizAkgBZk7SwzMW4qIEW6vO40ZsEX84+oy2B3LJyCEiFG3CIw63vKcru9x+D5bvb3d5+Cl6mZ+KfbeijXxLds5AM8C472Kvn/6Uy16eHb3LgfKO5HQ8hdQa6F3x8Mr4+Qo6Em1Xe47kSTSQ3GHWUiT5hOGKSavmPDICz8Aq3ljqBDwjSyg3QzQWgICFJK1TGLBIou7EBwJPuT8Byj/US6DNNJojswHR5Ue56ZEW7JDnkiq+QRz8zbvB6GA3YqpsS7woq9TtFKmZPLr40HdnCUDBzWSajk5GFUdBM2I6fs3kbKxR4SVasG7n8nco15Sc64Nn7pAzFmbEyYpP0+ehq4iX3u+0xkiSXbBO8WqSFkNaexzLD0fwKx98Kgj7ovkxrqc7xca+IHHhElYYy4PtvzJoySdAPQnn+Kzy0XyAcJ+YcLLMh5ECZzWAFy/f8CZzcEqJ3vhvF43zy2yHNBpXf06RLR3cZ2U0TRKS874nIOpAVqlI2sQZWBrnX4m4abo3ngEcX1MvNQJXp58/hBr3xG+746LoOX7EVRqr+Qs/8TaBhOUpTjR3XOpY0zQVaxTHY3HyzZzGkgDKoGGPCQ3RctouR9wWf1H84qvjdPhksT98YeuPvhHnqtBwARd5Lg2WGcPXRFpN56fB8eUyMA4hMR X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(26005)(2906002)(36860700001)(82310400005)(86362001)(52536014)(508600001)(8936002)(316002)(9686003)(356005)(53546011)(186003)(7696005)(81166007)(33656002)(6506007)(54906003)(40460700003)(110136005)(336012)(8676002)(83380400001)(47076005)(4326008)(5660300002)(55016003)(70586007)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 07:20:00.4701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 837ba0d5-3691-4389-56a2-08da29b0ac23 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7052 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pavan Nikhilesh > Sent: Wednesday, April 27, 2022 11:23 PM > To: Ruifeng Wang ; Yipeng Wang > ; Sameh Gobriel ; > Bruce Richardson ; Vladimir Medvedkin > > Cc: jerinj@marvell.com; dev@dpdk.org; Pavan Nikhilesh > > Subject: [PATCH v7 2/2] hash: unify crc32 selection for x86 and Arm >=20 > Merge crc32 hash calculation public API implementation for x86 and Arm. > Select the best available CRC32 algorithm when unsupported algorithm on a > given CPU architecture is requested by an application. >=20 > Previously, if an application directly includes `rte_crc_arm64.h` without > including `rte_hash_crc.h` it will fail to compile. >=20 > Signed-off-by: Pavan Nikhilesh > --- > .../{rte_crc_arm64.h =3D> hash_crc_arm64.h} | 69 ++------ > lib/hash/hash_crc_generic.h | 72 +++++++++ > lib/hash/hash_crc_x86.h | 89 +++++++++++ > lib/hash/meson.build | 1 - > lib/hash/rte_hash_crc.h | 147 +++++------------- > 5 files changed, 210 insertions(+), 168 deletions(-) rename > lib/hash/{rte_crc_arm64.h =3D> hash_crc_arm64.h} (65%) create mode 10064= 4 > lib/hash/hash_crc_generic.h >=20 Reviewed-by: Ruifeng Wang