DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gagandeep Singh <G.Singh@nxp.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [v1 2/3] meson: add a meson option to install examples source
Date: Wed, 7 Aug 2024 04:08:35 +0000	[thread overview]
Message-ID: <AS8SPR01MB002498C0169C22F01EC3C64DE1B82@AS8SPR01MB0024.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <ZrIsujUL1oNsndmG@bricha3-mobl1.ger.corp.intel.com>

Hi,

> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Tuesday, August 6, 2024 7:32 PM
> To: Gagandeep Singh <G.Singh@nxp.com>
> Cc: dev@dpdk.org
> Subject: Re: [v1 2/3] meson: add a meson option to install examples source
> 
> On Tue, Aug 06, 2024 at 07:12:17PM +0530, Gagandeep Singh wrote:
> > Adding a meson option "enable_examples_source_install"
> > to enable or disable installation of examples source code.
> >
> > Default value is true.
> >
> > Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> > ---
> >  meson.build       | 7 ++++---
> >  meson_options.txt | 2 ++
> >  2 files changed, 6 insertions(+), 3 deletions(-)
> >
> Is installing sample code for DPDK a problem that we need to disable it? I
> was expecting that such filtering out of unwanted files could be done via
> packaging rather than us having to add lots of DPDK build options to control
> these things.
> 
I understand your point that packaging could handle filtering out unwanted files.
However, adding a build option to disable DPDK examples source code installation provides
more control and flexibility for users who may have specific requirements or constraints.

While packaging can filter out files, this option allows users to avoid
downloading and compiling the examples altogether, which can be beneficial for:

- Users with limited disk space or network bandwidth
- Users who only need the core DPDK libraries and binaries and don't want the examples source code.

By default, the option is set to true, so the behavior remains unchanged.
This option is only for those who need more control over their build process.
I believe this optional flag adds flexibility without imposing unnecessary files on users and is a minor
and useful extension to the build system.

> /Bruce

  reply	other threads:[~2024-08-07  4:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06 13:42 [v1 0/3] meson options related changes Gagandeep Singh
2024-08-06 13:42 ` [v1 1/3] meson: add a meson option to install examples Gagandeep Singh
2024-08-06 13:58   ` Bruce Richardson
2024-08-07  4:09     ` Gagandeep Singh
2024-10-17 15:46       ` Thomas Monjalon
2024-08-06 13:42 ` [v1 2/3] meson: add a meson option to install examples source Gagandeep Singh
2024-08-06 14:01   ` Bruce Richardson
2024-08-07  4:08     ` Gagandeep Singh [this message]
2024-10-17 15:50       ` Thomas Monjalon
2024-08-06 13:42 ` [v1 3/3] meson: skip symlinks to PMDs script on no sub directory Gagandeep Singh
2024-08-06 13:57   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8SPR01MB002498C0169C22F01EC3C64DE1B82@AS8SPR01MB0024.eurprd04.prod.outlook.com \
    --to=g.singh@nxp.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).