From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5148BC6BA for ; Fri, 31 Jul 2015 11:03:49 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 31 Jul 2015 02:03:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,583,1432623600"; d="scan'208";a="739437580" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga001.jf.intel.com with ESMTP; 31 Jul 2015 02:03:46 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.149]) by IRSMSX106.ger.corp.intel.com ([169.254.8.137]) with mapi id 14.03.0224.002; Fri, 31 Jul 2015 10:03:45 +0100 From: "Mcnamara, John" To: Neil Horman , Chao Zhu Thread-Topic: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code Thread-Index: AQHQvVZqZR1hms2NmEabJ+zyDXkQXZ3ZJb0AgAARv8CAACV4gIAcA1oA Date: Fri, 31 Jul 2015 09:03:45 +0000 Message-ID: References: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com> <20150713104218.GB9631@hmsreliant.think-freely.org> <20150713135955.GC9631@hmsreliant.think-freely.org> In-Reply-To: <20150713135955.GC9631@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2015 09:03:49 -0000 > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Monday, July 13, 2015 3:00 PM > To: Mcnamara, John > Cc: dev@dpdk.org; vladz@cloudius-systems.com > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code >=20 > On Mon, Jul 13, 2015 at 10:47:03AM +0000, Mcnamara, John wrote: > > > -----Original Message----- > > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > > Sent: Monday, July 13, 2015 11:42 AM > > > To: Mcnamara, John > > > Cc: dev@dpdk.org; vladz@cloudius-systems.com > > > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code > > > > > > On Mon, Jul 13, 2015 at 11:26:25AM +0100, John McNamara wrote: > > > > Fix for ABI breakage introduced in LRO addition. Moves lro > > > > bitfield to the end of the struct/member. > > > > > > > > Fixes: 8eecb3295aed (ixgbe: add LRO support) > > > > > > > > Signed-off-by: John McNamara > > > > --- > > > > lib/librte_ether/rte_ethdev.h | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/lib/librte_ether/rte_ethdev.h > > > > b/lib/librte_ether/rte_ethdev.h index 79bde89..1c3ace1 100644 > > > > --- a/lib/librte_ether/rte_ethdev.h > > > > +++ b/lib/librte_ether/rte_ethdev.h > > > > @@ -1578,9 +1578,9 @@ struct rte_eth_dev_data { > > > > uint8_t port_id; /**< Device [external] port > identifier. > > > */ > > > > uint8_t promiscuous : 1, /**< RX promiscuous mode ON(1) / > OFF(0). > > > */ > > > > scattered_rx : 1, /**< RX of scattered packets is ON(1) > / > > > OFF(0) */ > > > > - lro : 1, /**< RX LRO is ON(1) / OFF(0) */ > > > > all_multicast : 1, /**< RX all multicast mode ON(1) / > OFF(0). > > > */ > > > > - dev_started : 1; /**< Device state: STARTED(1) / > STOPPED(0). > > > */ > > > > + dev_started : 1, /**< Device state: STARTED(1) / > STOPPED(0). > > > */ > > > > + lro : 1; /**< RX LRO is ON(1) / OFF(0) */ > > > > }; > > > > > > > > /** > > > > -- > > > > 1.8.1.4 > > > > > > > > > > > I presume the ABI checker stopped complaining about this with the > > > patch, yes? > > > > Hi Neil, > > > > Yes, I replied about that in the previous thread. > > > Thank you, I'll ack as soon as Chao confirms its not a problem on ppc Nei= l Hi Chao, Any reply on this. Neil, if there is no reply to this from the PPC maintainer do you have any = objection to this going in as is.=20 It at least fixes the LRO ABI breakage on the platforms we can test on. John