From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 27C3A952 for ; Tue, 25 Aug 2015 15:34:53 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 25 Aug 2015 06:34:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,745,1432623600"; d="scan'208";a="775291362" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga001.fm.intel.com with ESMTP; 25 Aug 2015 06:34:52 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.251]) by IRSMSX153.ger.corp.intel.com ([169.254.9.13]) with mapi id 14.03.0224.002; Tue, 25 Aug 2015 14:34:51 +0100 From: "Mcnamara, John" To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] qos_meter: Fix compilation with APP_MODE_FWD Thread-Index: AQHQ2c5urveDUVqjUEm+FFKcNPkCg54coReAgAAe+NA= Date: Tue, 25 Aug 2015 13:34:50 +0000 Message-ID: References: <1439913312-14761-1-git-send-email-ian.stokes@intel.com> <1677849.ZVAMZEjUYk@xps13> In-Reply-To: <1677849.ZVAMZEjUYk@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] qos_meter: Fix compilation with APP_MODE_FWD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2015 13:34:54 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, August 25, 2015 1:37 PM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] qos_meter: Fix compilation with APP_MODE_= FWD >=20 > > --- a/examples/qos_meter/main.h > > +++ b/examples/qos_meter/main.h > > #if APP_MODE =3D=3D APP_MODE_FWD > > > > -#define FUNC_METER(a,b,c,d) color, flow_id=3Dflow_id, pkt_len=3Dpkt_le= n, > > time=3Dtime > > +#define FUNC_METER(a,b,c,d) input_color, flow_id=3Dflow_id, > > +pkt_len=3Dpkt_len, time=3Dtime >=20 > This patch should not be accepted to discourage build-time options. > Patch for run-time option is welcome. Hi, The patch is fixing a compilation issue, which seems reasonable. It isn't i= ntroducing a build time option, it is merely fixing an typo in an existing = one. Yes, it would be better not to have this build time option (in which case t= he issue would have been found sooner) but that isn't the responsibility of= the person submitting this patch. That is something that should be pushed back to the author/maintainer. In the meantime this patch is still valid and should be applied. John