From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 98DDFA6A for ; Wed, 14 Oct 2015 18:28:31 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 14 Oct 2015 09:28:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,681,1437462000"; d="scan'208";a="664284497" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga003.jf.intel.com with ESMTP; 14 Oct 2015 09:28:30 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.116]) by IRSMSX106.ger.corp.intel.com ([169.254.8.229]) with mapi id 14.03.0248.002; Wed, 14 Oct 2015 17:28:29 +0100 From: "Mcnamara, John" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 02/20] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data Thread-Index: AQHRBQq/Qr+xzV3L9EOLukdgTw4ZTJ5rMFiQ Date: Wed, 14 Oct 2015 16:28:28 +0000 Message-ID: References: <1444667120-12891-1-git-send-email-bernard.iremonger@intel.com> <1444667120-12891-3-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1444667120-12891-3-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 02/20] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 16:28:32 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Monday, October 12, 2015 5:25 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 02/20] librte_ether: add fields from > ... > > lro : 1; /**< RX LRO is ON(1) / OFF(0) */ > + uint32_t dev_flags; /**< Flags controlling handling of device. */ > + enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > + int numa_node; > + const char *drv_name; > }; >=20 Should the last two members have doxygen comments as well?