Re: [dpdk-dev] [PATCH v2 0/4] Support for Netronome´s NFP-6xxx card

["Mcnamara, John" <john.mcnamara@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alejandro.Lucero
> Sent: Tuesday, October 6, 2015 3:49 PM
> To: dev@dpdk.org
> Subject: [PATCH v2 0/4] Support for Netronome´s NFP-6xxx card
> 
> From: "Alejandro.Lucero" <alejandro.lucero@netronome.com>
> 
> This patchset adds a new PMD for Netronome´s NFP-6xxx card along with a
> new UIO driver, documentation and minor changes to configuration scrips.

Hi Alejandro,

Patch 1/4 doesn't build cleanly without patch 2/4:


    == Build lib/librte_eal/linuxapp/nfp_uio
    make[7]: /home/johnmc/dpdk_netronome/lib/librte_eal/linuxapp/nfp_uio/Makefile: 
             No such file or directory
    make[7]: *** No rule to make target
             `/tmp/dpdk_netronome/lib/librte_eal/linuxapp/nfp_uio/Makefile'.
             Stop.
    make[6]: *** [nfp_uio] Error 2
    make[5]: *** [linuxapp] Error 2
    make[4]: *** [librte_eal] Error 2
    make[3]: *** [lib] Error 2
    make[2]: *** [all] Error 2
    make[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2
    make: *** [install] Error 2


Patch 3/4 has a whitespace warning in the patch:

    $ pwclient git-am 7472

    Applying patch #7472 using 'git am'
    Description: [dpdk-dev,v2,3/4] This patch adds documentation about Netronome´s NFP nic
    Applying: This patch adds documentation about Netronome´s NFP nic
    /home/johnmc/dpdk_netronome/.git/rebase-apply/patch:291: new blank line at EOF.
    +
    warning: 1 line adds whitespace errors.


The commit messages don't follow the usual DPDK standard which is more or less the same as the Linux kernel format. The subject line should be lowercase, around 60 characters, and contain the component that is being modified. So Patch 1/4 should have a commit message like:

    nfp: add a pmd driver for netronome nfp pci cards

    This patch adds a PMD driver for Netronome NFP PCI cards.
    Or something more informative if necessary.

    Signed-off-by: etc

Do a git log on some of the other components and copy the ones that look right. :-)

John