From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 11F895A4D for ; Wed, 9 Dec 2015 15:43:49 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 09 Dec 2015 06:43:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,403,1444719600"; d="scan'208";a="857303891" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga001.fm.intel.com with ESMTP; 09 Dec 2015 06:43:50 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by irsmsx110.ger.corp.intel.com ([169.254.15.163]) with mapi id 14.03.0248.002; Wed, 9 Dec 2015 14:43:47 +0000 From: "Mcnamara, John" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide Thread-Index: AQHRMn48dNFqeN8IxESb81FB1fPCtJ7Ct7JA Date: Wed, 9 Dec 2015 14:43:47 +0000 Message-ID: References: <1449664541-9546-1-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1449664541-9546-1-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 14:43:50 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Wednesday, December 9, 2015 12:36 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application > guide >=20 > correct sample console commands >=20 > Fixes: d0dff9ba445e ("doc: sample application user guide" > Fixes: 9bc23cb8209c ("doc: add vhost-user to sample guide") > Fixes: 43866bf71d58 ("doc: fix vhost sample parameter") > Signed-off-by: Bernard Iremonger Hi Bernard, Thanks for that. One comment (in several places): > .. code-block:: console >=20 > - user@target:~$ ./build/app/vhost-switch -c f -n 4 --huge-dir /mn= t/huge -- -p 0x1 --dev-basename usvhost > + user@target:~$ ./build/app/vhost-switch -c f -n 4 --socket-mem 1= 024 --huge-dir /mnt/huge -- -p 0x1 --dev-basename usvhost These long lines in code blocks don't render correctly in the PDF docs. The= =20 Documentation Guidelines suggest using a commandline line continuation to maintain functionality within an 80 char doc limit: http://dpdk.org/doc/guides/contributing/documentation.html#code-and-lite= ral-block-sections So something like this: user@target:~$ ./build/app/vhost-switch -c f -n 4 --socket-mem 1024 --h= uge-dir /mnt/huge -- -p 0x1 --dev-basename usvhost Could be written as: user@target:~$ ./build/app/vhost-switch -c f -n 4 --socket-mem 1024 \ --huge-dir /mnt/huge -- -p 0x1 --dev-basename usvh= ost Or:=20 user@target:~$ ./build/app/vhost-switch -c f -n 4 \ --socket-mem 1024 \ --huge-dir /mnt/huge \ -- -p 0x1 --dev-basename usvhos= t Regards, John. --=20