From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8319168A5 for ; Wed, 9 Dec 2015 15:51:06 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 09 Dec 2015 06:50:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,404,1444719600"; d="scan'208";a="857310006" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga001.fm.intel.com with ESMTP; 09 Dec 2015 06:50:59 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by IRSMSX154.ger.corp.intel.com ([169.254.12.98]) with mapi id 14.03.0248.002; Wed, 9 Dec 2015 14:50:58 +0000 From: "Mcnamara, John" To: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide Thread-Index: AQHRMn48dNFqeN8IxESb81FB1fPCtJ7CuwwA Date: Wed, 9 Dec 2015 14:50:58 +0000 Message-ID: References: <1449664541-9546-1-git-send-email-bernard.iremonger@intel.com> In-Reply-To: <1449664541-9546-1-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 14:51:07 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Wednesday, December 9, 2015 12:36 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application > guide >=20 > correct sample console commands >=20 > Fixes: d0dff9ba445e ("doc: sample application user guide" > Fixes: 9bc23cb8209c ("doc: add vhost-user to sample guide") > Fixes: 43866bf71d58 ("doc: fix vhost sample parameter") > Signed-off-by: Bernard Iremonger > --- > doc/guides/sample_app_ug/vhost.rst | 40 +++++++++++++++++++-------------= - > > ... >=20 > Redistribution and use in source and binary forms, with or without @= @ > -386,13 +386,13 @@ Running the Sample Code >=20 > .. code-block:: console >=20 > - user@target:~$ ./build/app/vhost-switch -c f -n 4 --huge-dir / Also, as a general note, not just to this document/patch. I don't think the "user@target:~$" prefixes used in some DPDK Doc commandlines is useful. It prevents a straight copy and paste for testing, it makes the literal block lines longer than they should be, it isn't used consistently everywhere, it is visually distracting (in some cases it is longer than the command being shown), and it isn't always correct (I presume in the above case of "user@target" you would need run the application as sudo if you are a non root user). Any objections to removing these as documents are updated? John