From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 4B0CA8E7B
 for <dev@dpdk.org>; Fri, 11 Dec 2015 15:44:10 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga101.fm.intel.com with ESMTP; 11 Dec 2015 06:44:09 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,414,1444719600"; d="scan'208";a="858836927"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by fmsmga001.fm.intel.com with ESMTP; 11 Dec 2015 06:44:10 -0800
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.95]) with mapi id 14.03.0248.002;
 Fri, 11 Dec 2015 14:44:07 +0000
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] cxgbe: fix unnecessary check for freelist
 existence while freeing rxq
Thread-Index: AQHRM+2xURIRzqy35km87YfZ03NxIp7F3Cqg
Date: Fri, 11 Dec 2015 14:44:06 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE202403460@IRSMSX103.ger.corp.intel.com>
References: <66655e2d7666da09b80174d265eef304b8d93470.1449821728.git.rahul.lakkireddy@chelsio.com>
In-Reply-To: <66655e2d7666da09b80174d265eef304b8d93470.1449821728.git.rahul.lakkireddy@chelsio.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: Kumar Sanghvi <kumaras@chelsio.com>, Felix Marti <felix@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH] cxgbe: fix unnecessary check for
	freelist	existence while freeing rxq
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Dec 2015 14:44:10 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rahul Lakkireddy
> Sent: Friday, December 11, 2015 8:26 AM
> To: dev@dpdk.org
> Cc: Felix Marti; Kumar Sanghvi; Nirranjan Kirubaharan
> Subject: [dpdk-dev] [PATCH] cxgbe: fix unnecessary check for freelist
> existence while freeing rxq
>=20
> When refilling freelists for the first time and if it fails, the rxq is
> freed and returns ENOMEM. There is a check while freeing hardware rxq to
> pass freelist context id if the freelist exists or 0xffff otherwise.
> The error path is only reached if freelist exists. So, fix is to remove
> the useless check for freelist existence.
>=20
> Thanks to John McNamara <john.mcnamara@intel.com> for reporting it.
>=20
> Coverity issue: 107108
> Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support")
>=20
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>

Thanks for updating the Coverity Triage for the issue.

Acked-by: John McNamara <john.mcnamara@intel.com>