From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 667F3C40A for ; Thu, 18 Feb 2016 19:15:18 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 18 Feb 2016 10:15:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,466,1449561600"; d="scan'208";a="915970577" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga002.jf.intel.com with ESMTP; 18 Feb 2016 10:15:05 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.30]) by IRSMSX106.ger.corp.intel.com ([169.254.8.197]) with mapi id 14.03.0248.002; Thu, 18 Feb 2016 18:14:59 +0000 From: "Mcnamara, John" To: Marc Sune , "dev@dpdk.org" , "Lu, Wenzhuo" , "Zhang, Helin" , Harish Patil , "Chen, Jing D" Thread-Topic: [dpdk-dev] [PATCH v8 4/4] doc: update with link changes Thread-Index: AQHRZ4COyCzze/vQX0GmxRPX7hxp358yG8FQ Date: Thu, 18 Feb 2016 18:14:59 +0000 Message-ID: References: <1454028127-10401-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-5-git-send-email-marcdevel@gmail.com> In-Reply-To: <1455488259-1000-5-git-send-email-marcdevel@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjMwNjAzZjQtZDk4NC00Y2I4LWE5Y2ItYmQwNGI3MmM5N2RjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjdkMnJpSGIxSEROaHE2YVZmWGJBdzVEcmhaM1A0RUxMTE5GcDZXcEpcL3RJPSJ9 x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 4/4] doc: update with link changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 18:15:18 -0000 Hi, Some minor comments below in order to get a consistent set of release notes= . > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marc Sune > Sent: Sunday, February 14, 2016 10:18 PM > To: dev@dpdk.org; Lu, Wenzhuo ; Zhang, Helin > ; Harish Patil ; Chen, > Jing D > Subject: [dpdk-dev] [PATCH v8 4/4] doc: update with link changes >=20 > Add new features, ABI changes and resolved issues notice for the > refactored link patch. >=20 > Signed-off-by: Marc Sune > --- > doc/guides/rel_notes/release_2_3.rst | 102 This should be rebased and the notes added to doc/guides/rel_notes/release_= 16_04.rst. > + > +* **ethdev: define a set of advertised link speeds.** The title and the text should be in the past tense. See the hints/guidelines in the updated release notes: http://dpdk.org/browse/dpdk/tree/doc/guides/rel_notes/release_16_04.rst > + > + Allowing to define a set of advertised speeds for auto-negociation, Maybe something like: Added functionality to allow the definition of advert= ised speeds for ... > +* **ethdev: add speed_cap bitmap to recover eth device link speed > +capabilities > + define a set of advertised link speeds.** The title is a little long. Just give a brief overview here and more the de= tail to the text sections. > + > + ``struct rte_eth_dev_info`` has now speed_cap bitmap, which allows > + the application to recover the supported speeds for that ethernet > device. It would be good to use ```` quotes on speed_cap as well for consistency. + > +Examples > +~~~~~~~~ > + > +* New API call, rte_eth_speed_to_bm_flag(), in ethdev to map numerical > +speeds to bitmap fields. I don't think this should be in the "Examples" section. Maybe as a sub-item in the "New Featrues" or in "API Changes" if it is a change. > + > +ABI Changes > +----------- > + > +* The ethdev rte_eth_link and rte_eth_conf structures were changed to > + support the new link API, as well as ETH_LINK_HALF/FULL_DUPLEX. > + > +* The ethdev rte_eth_dev_info was changed to support device speed > capabilities. Better to put the struct names and variables in ```` quotes. Thanks, John. -=20